Skip to content

[Due for payment 2026-06-19] Invoices - Initial value page shows empty space above list value #93235

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.5-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #73887
Email or phone of affected tester (no customers): odjosdjosjnojdiosj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Enable Invoices in workspace settings.
  1. Go to staging.new.expensify.com
    2 Go to workspace settings > Invoices.
  2. Enable Invoice fields and upgrade workspace if needed.
  3. Click Add field.
  4. Click Name, enter name and save it.
  5. Click Type and select List.
  6. Click List values and add a list value.
  7. Click RHP back button.
  8. Click Initial value.

Expected Result:

Initial value page will not show empty space above list value.

Actual Result:

Initial value page shows empty space above list value.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7177422_1781135478343.5.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7177422

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 11, 2026
  2. applause-bot commented on Jun 11, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/453ffcf96c9e0b95cca1300da339a290c9133ab7a0b886f964f17aa3fcbbdf6e

  3. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #73887

  4. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 11, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On the Add field → Initial value selector for a List type invoice field, there is empty space above the list value rows.

    What is the root cause of that problem?

    In the create flow, the Initial value selector is rendered without a subtitle prop:

    CreateFieldsPage.tsx:269-275

    InitialListValueSelector defaults subtitle to an empty string (index.tsx:26) and forwards it to the modal. The modal always renders a padded subtitle container (ph5, pb4) regardless of whether the subtitle has text:

    InitialListValueSelectorModal.tsx:57-59

    With an empty subtitle, that container collapses to a blank, padded block — the "empty space above list value".

    Why this surfaced now (it's pre-existing, not a regression from PR #73887)

    The pre-refactor CreateReportFieldsPage.tsx also rendered InitialListValueSelector without a subtitle, so report fields show the same gap in production. PR #73887 reused the shared InitialListValueSelectorModal, so the new invoice fields flow inherited the same behavior. Note the edit flow (FieldsInitialValuePage.tsx:123-129) does show a listValuesInputSubtitle here, so the create flow is inconsistent with it.

    What changes do you think we should make in order to solve the problem?

    Pass a subtitle to the Initial value selector in CreateFieldsPage.tsx:269-275, matching the edit flow:

    <InputWrapper
        InputComponent={InitialListValueSelector}
        inputID={INPUT_IDS.INITIAL_VALUE}
        label={translate('common.initialValue')}
        subtitle={translate(isInvoiceField ? 'workspace.invoiceFields.listValuesInputSubtitle' : 'workspace.reportFields.listValuesInputSubtitle')}
    />

    This fills the space with the same helper text shown on the edit page and makes the two flows consistent.

    What alternative solutions did you explore?

    Alternatively (or additionally, as a defensive guard), only render the subtitle container in InitialListValueSelectorModal.tsx:57-59 when subtitle is non-empty ({!!subtitle && (<View>…</View>)}). This prevents the empty padded block for any future caller that omits a subtitle.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/93235) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. mollfpr commented on Jun 11, 2026

    @mollfpr
    Contributor

    Closing — the invoice fields feature has been reverted, so this no longer reproduces on staging.

  10. changed the title [-]Invoices - Initial value page shows empty space above list value[/-] [+][Due for payment 2026-06-19] Invoices - Initial value page shows empty space above list value[/+] on Jun 12, 2026
  11. melvin-bot commented on Jun 12, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.6-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-19. 🎊

  12. melvin-bot commented on Jun 12, 2026

    @melvin-bot

    @mollfpr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions