You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-19] Invoices - Initial value page shows empty space above list value #93235
Version Number: 9.4.5-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#73887 Email or phone of affected tester (no customers):odjosdjosjnojdiosj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Enable Invoices in workspace settings.
Go to staging.new.expensify.com
2 Go to workspace settings > Invoices.
Enable Invoice fields and upgrade workspace if needed.
Click Add field.
Click Name, enter name and save it.
Click Type and select List.
Click List values and add a list value.
Click RHP back button.
Click Initial value.
Expected Result:
Initial value page will not show empty space above list value.
Actual Result:
Initial value page shows empty space above list value.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
InitialListValueSelector defaults subtitle to an empty string (index.tsx:26) and forwards it to the modal. The modal always renders a padded subtitle container (ph5, pb4) regardless of whether the subtitle has text:
With an empty subtitle, that container collapses to a blank, padded block — the "empty space above list value".
Why this surfaced now (it's pre-existing, not a regression from PR #73887)
The pre-refactor CreateReportFieldsPage.tsx also rendered InitialListValueSelector without a subtitle, so report fields show the same gap in production. PR #73887 reused the shared InitialListValueSelectorModal, so the new invoice fields flow inherited the same behavior. Note the edit flow (FieldsInitialValuePage.tsx:123-129) does show a listValuesInputSubtitle here, so the create flow is inconsistent with it.
What changes do you think we should make in order to solve the problem?
This fills the space with the same helper text shown on the edit page and makes the two flows consistent.
What alternative solutions did you explore?
Alternatively (or additionally, as a defensive guard), only render the subtitle container in InitialListValueSelectorModal.tsx:57-59 when subtitle is non-empty ({!!subtitle && (<View>…</View>)}). This prevents the empty padded block for any future caller that omits a subtitle.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/93235) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Invoices - Initial value page shows empty space above list value[/-][+][Due for payment 2026-06-19] Invoices - Initial value page shows empty space above list value[/+]on Jun 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.6-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mollfpr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 11, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/453ffcf96c9e0b95cca1300da339a290c9133ab7a0b886f964f17aa3fcbbdf6e
melvin-bot commentedon Jun 11, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #73887
melvin-bot commentedon Jun 11, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 11, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On the Add field → Initial value selector for a
Listtype invoice field, there is empty space above the list value rows.What is the root cause of that problem?
In the create flow, the Initial value selector is rendered without a
subtitleprop:CreateFieldsPage.tsx:269-275InitialListValueSelectordefaultssubtitleto an empty string (index.tsx:26) and forwards it to the modal. The modal always renders a padded subtitle container (ph5,pb4) regardless of whether the subtitle has text:InitialListValueSelectorModal.tsx:57-59With an empty subtitle, that container collapses to a blank, padded block — the "empty space above list value".
Why this surfaced now (it's pre-existing, not a regression from PR #73887)
The pre-refactor
CreateReportFieldsPage.tsxalso renderedInitialListValueSelectorwithout asubtitle, so report fields show the same gap in production. PR #73887 reused the sharedInitialListValueSelectorModal, so the new invoice fields flow inherited the same behavior. Note the edit flow (FieldsInitialValuePage.tsx:123-129) does show alistValuesInputSubtitlehere, so the create flow is inconsistent with it.What changes do you think we should make in order to solve the problem?
Pass a
subtitleto the Initial value selector inCreateFieldsPage.tsx:269-275, matching the edit flow:This fills the space with the same helper text shown on the edit page and makes the two flows consistent.
What alternative solutions did you explore?
Alternatively (or additionally, as a defensive guard), only render the subtitle container in
InitialListValueSelectorModal.tsx:57-59whensubtitleis non-empty ({!!subtitle && (<View>…</View>)}). This prevents the empty padded block for any future caller that omits a subtitle.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/93235)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
melvin-bot commentedon Jun 11, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Jun 11, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mollfpr commentedon Jun 11, 2026
Closing — the invoice fields feature has been reverted, so this no longer reproduces on staging.
[-]Invoices - Initial value page shows empty space above list value[/-][+][Due for payment 2026-06-19] Invoices - Initial value page shows empty space above list value[/+]melvin-bot commentedon Jun 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.6-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-19. 🎊
melvin-bot commentedon Jun 12, 2026
@mollfpr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]