Skip to content

[Due for payment 2026-07-01] [$75] Android & iOS - Agents - "Create agents to handle your workflow.." sentence is missing #93638

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.8-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #93446
Email or phone of affected tester (no customers): jsodinjosdjsoinjsiojs@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 Pro Max / iOS 26.5
App Component: User Settings

Action Performed:

  1. Launch Expensify app.
  2. Go to Account > Agents.
  3. Create an agent.

Expected Result:

"Create agents to handle your workflow.." sentence will appear above the agent list.

Actual Result:

"Create agents to handle your workflow.." sentence is missing.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Image

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7181599

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 15, 2026
  2. melvin-bot commented on Jun 15, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #93446

  3. melvin-bot commented on Jun 15, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Jun 15, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 15, 2026
  6. NicolasBonet commented on Jun 15, 2026

    @NicolasBonet
    Contributor

    @MelvinBot investigate, demoting this from been a blocker

  7. MelvinBot commented on Jun 15, 2026

    @MelvinBot
    Contributor

    Issue Analysis

    Root cause: PR #92326 ("Link to the Custom Agents help article from the Agents page") changed the Agents page subtitle from a plain <Text> into an HTML string rendered via <RenderHTML>, and that HTML output does not render on native (iOS/Android app). This PR is in staging but not production, which is why the bug reproduces on staging only.

    Not the linked PR #93446 — that PR only touched the Edit/Add agent form pages (EditPromptPage, AddAgentRulePage, EditAgentRulePage), not the Agents list page. The deploy-blocker auto-assignment is based on "recently merged a PR," not on root cause.

    Recommended action (deploy blocker):

    • Fastest unblock: revert PR #92326. It changed two working plain-text subtitles into RenderHTML that breaks on native.
    • Proper fix (if keeping the "Learn more" link): make the subtitle render on native. The call site at AgentsPage.tsx:148 calls <RenderHTML html={...} /> without an onLinkPress prop. Per RenderHTML.tsx:78-88, when onLinkPress is omitted it renders a bare RenderHTMLSource (no local config provider). Passing onLinkPress (and verifying on a native build) is the likely fix and matches how RenderHTML is used elsewhere for linked content.
    Evidence

    Production vs. staging diff (via gh api .../contents/...?ref=production):

    agentsPage.subtitle string render
    production (works) Create agents to handle your workflow. Skip the manual work and get hours back in your day. <Text style={[styles.textSupporting,…]}>{translate('agentsPage.subtitle')}</Text>
    staging (broken on native) <muted-text>Create agents…day. <a href="${CUSTOM_AGENTS_HELP_URL}">Learn more</a>.</muted-text> <View style={[styles.renderHTML,…]}><RenderHTML html={translate('agentsPage.subtitle')} /></View>

    Why the whole sentence vanishes (not just the link): the subtitle <View> and the <FlatList> are siblings under the same hasAgents conditional, so the list rendering while the text is absent rules out a data/empty-state issue — it's a native RenderHTML rendering failure for this string. The HTML uses the custom <muted-text> block element (defined in BaseHTMLEngineProvider.tsx); without the local RenderHTMLConfigProvider (only mounted when onLinkPress is passed) the native output is empty.

    Confidence: High on the cause (PR #92326, staging-only, Text → RenderHTML). Medium on the exact native mechanism / sufficiency of the onLinkPress fix — I confirmed via the prod-vs-staging code diff but did not reproduce on a native build. A native repro (or testing the page with onLinkPress wired up) would confirm the fix.


    Next Steps: Reply with @MelvinBot implement this to create a draft PR with the fix (or a revert of #92326), or @MelvinBot <feedback> to refine this analysis.

  8. 69 remaining items

  9. thelullabyy commented on Jun 24, 2026

    @thelullabyy
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: NA
      Link to the comment on the Issue

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Test:

    1. Launch Expensify app.
    2. Go to Account > Agents.
    3. Create an agent.
    4. Verify "Agents handle your workflows for you, so you get hours back in your day. Learn more." sentence will appear above the agent list.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-23c3-a6c6-0aa5-155ecfe8a8b4
  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 24, 2026
  11. melvin-bot commented on Jun 30, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. mallenexpensify commented on Jul 2, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @lorretheboy paid $75 via Upwork
    Contributor+: @thelullabyy paid $75 via Upwork.

    @lorretheboy can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022066661999298746571

  13. lorretheboy commented on Jul 2, 2026

    @lorretheboy
    Contributor

    @mallenexpensify I accepted the job. Thx

  14. thelullabyy commented on Jul 2, 2026

    @thelullabyy
    Contributor

    @mallenexpensify I think you mentioned wrong person btw, I am due for payment here instead of @DylanDylann

  15. mallenexpensify commented on Jul 3, 2026

    @mallenexpensify
    Contributor

    @lorretheboy paid, summary updated above. Thx. Same with @thelullabyy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2DesignEngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions