You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Login-Spinner appears briefly after opening expired magic link and logging in with new account #93758
Version Number: 9.4.9-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90488 Email or phone of affected tester (no customers):jsodinjosdjsoinjsiojs@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Other
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
📣 @viktoriavikulya! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Root Cause: The brief spinner is intended behavior introduced by PR #90488 (the PR this was caught testing). That PR deliberately changed the AppNavigator Suspense fallback from null (a blank screen) to a LoadingIndicator, so users now see a loader instead of a blank screen while the lazy AuthScreens chunk downloads during the sign-in swap. See AppNavigator.tsx:14-21.
When you log in (step 6), authenticated flips to true, AppNavigator swaps PublicScreens → AuthScreens, and the brief spinner is the Suspense fallback shown while that chunk loads. This is not specific to the expired-magic-link path — it happens on any fresh sign-in. The expired-link steps are just the repro flow the tester was following for PR #90488.
This also explains "Reproducible in staging: Yes / production: No" — PR #90488 is on staging but not yet in production.
Recommendation: This likely should not block the deploy. The "regression" is an intentional UX improvement (loader instead of a blank screen). The previous behavior showed a blank screen during the same window, which is arguably worse.
If the team agrees the loader is acceptable → close this as working as intended and remove the deploy blocker.
Why it's the AppNavigator loader and not the ValidateLoginPage loader: For an expired link, autoAuthState resolves to FAILED. The ValidateLoginPageFullScreenLoadingIndicator only renders when autoAuthState === SIGNING_IN or isCompletingDirectSignIn is true (which itself requires SIGNING_IN/JUST_SIGNED_IN). Neither is met for an expired code, so the page-level loader does not fire. The spinner the tester sees comes from the AppNavigator Suspense fallback during the public→auth screen swap.
Alternative explanations considered:
Lingering /v/... ValidateLoginPage route showing its own loader — ruled out; the expired flow leaves autoAuthState = FAILED, which doesn't satisfy any of that page's loader conditions.
A genuinely stuck/hanging spinner — ruled out; the report says the spinner appears briefly then resolves, consistent with a one-time lazy-chunk download, not a hang.
Confidence: Medium-High. Code evidence and the PR author's own inline comments confirm the loader is intentional; "brief" duration and staging-only reproduction are consistent with the chunk-load swap. Not independently reproduced in a browser.
Next Steps for Contributor+ team: To accept (revert the fallback):@MelvinBot implement reverting the AppNavigator authenticated-branch fallback to null To refine:@MelvinBot <your feedback> To reject: Explain why you disagree this is intended behavior.
Activity
applause-bot commentedon Jun 16, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/4b2932b174023212414136e40d0c3d737c7ef8a2af611fa278d9a4a34c772b3a
melvin-bot commentedon Jun 16, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90488
melvin-bot commentedon Jun 16, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 16, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
blimpich commentedon Jun 16, 2026
Not important. Demoting.
viktoriavikulya commentedon Jun 16, 2026
This behavior changed in v2.4 — the migration guide mentions it but it's easy to miss. Adding a note to the docs PR.
melvin-bot commentedon Jun 16, 2026
📣 @viktoriavikulya! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
MelvinBot commentedon Jun 16, 2026
Issue Analysis
Root Cause: The brief spinner is intended behavior introduced by PR #90488 (the PR this was caught testing). That PR deliberately changed the
AppNavigatorSuspense fallback fromnull(a blank screen) to aLoadingIndicator, so users now see a loader instead of a blank screen while the lazyAuthScreenschunk downloads during the sign-in swap. SeeAppNavigator.tsx:14-21.When you log in (step 6),
authenticatedflips totrue,AppNavigatorswapsPublicScreens→AuthScreens, and the brief spinner is the Suspense fallback shown while that chunk loads. This is not specific to the expired-magic-link path — it happens on any fresh sign-in. The expired-link steps are just the repro flow the tester was following for PR #90488.This also explains "Reproducible in staging: Yes / production: No" — PR #90488 is on staging but not yet in production.
Recommendation: This likely should not block the deploy. The "regression" is an intentional UX improvement (loader instead of a blank screen). The previous behavior showed a blank screen during the same window, which is arguably worse.
authenticatedbranch fallback inAppNavigator.tsx:18back tofallback={null}, but that reintroduces the blank screen PR auto-sign in with sign in link in separate browser #90488 was fixing.Investigation details
Why it's the AppNavigator loader and not the ValidateLoginPage loader: For an expired link,
autoAuthStateresolves toFAILED. TheValidateLoginPageFullScreenLoadingIndicatoronly renders whenautoAuthState === SIGNING_INorisCompletingDirectSignInis true (which itself requiresSIGNING_IN/JUST_SIGNED_IN). Neither is met for an expired code, so the page-level loader does not fire. The spinner the tester sees comes from theAppNavigatorSuspense fallback during the public→auth screen swap.Alternative explanations considered:
/v/...ValidateLoginPage route showing its own loader — ruled out; the expired flow leavesautoAuthState = FAILED, which doesn't satisfy any of that page's loader conditions.Confidence: Medium-High. Code evidence and the PR author's own inline comments confirm the loader is intentional; "brief" duration and staging-only reproduction are consistent with the chunk-load swap. Not independently reproduced in a browser.
Next Steps for Contributor+ team:
To accept (revert the fallback):
@MelvinBot implement reverting the AppNavigator authenticated-branch fallback to nullTo refine:
@MelvinBot <your feedback>To reject: Explain why you disagree this is intended behavior.
blimpich commentedon Jun 16, 2026
closing as intended behavior