Skip to content

Login-Spinner appears briefly after opening expired magic link and logging in with new account #93758

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.9-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90488
Email or phone of affected tester (no customers): jsodinjosdjsoinjsiojs@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log out if logged in.
  3. Go to https://staging.new.expensify.com/v/22409515/220960
  4. Click just sign in here.
  5. Go to staging.new.expensify.com
  6. Log in with a new account.

Expected Result:

No spinner will appear after opening expired magic link and logging in with a new account.

Actual Result:

Spinner appears briefly after opening expired magic link and logging in with a new account.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7182821_1781643894637.3.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7182821

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 16, 2026
  2. applause-bot commented on Jun 16, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/4b2932b174023212414136e40d0c3d737c7ef8a2af611fa278d9a4a34c772b3a

  3. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #90488

  4. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 16, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 16, 2026
  7. blimpich commented on Jun 16, 2026

    @blimpich
    Contributor

    Not important. Demoting.

  8. viktoriavikulya commented on Jun 16, 2026

    @viktoriavikulya

    This behavior changed in v2.4 — the migration guide mentions it but it's easy to miss. Adding a note to the docs PR.

  9. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    📣 @viktoriavikulya! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  10. MelvinBot commented on Jun 16, 2026

    @MelvinBot
    Contributor

    Issue Analysis

    Root Cause: The brief spinner is intended behavior introduced by PR #90488 (the PR this was caught testing). That PR deliberately changed the AppNavigator Suspense fallback from null (a blank screen) to a LoadingIndicator, so users now see a loader instead of a blank screen while the lazy AuthScreens chunk downloads during the sign-in swap. See AppNavigator.tsx:14-21.

    When you log in (step 6), authenticated flips to true, AppNavigator swaps PublicScreens → AuthScreens, and the brief spinner is the Suspense fallback shown while that chunk loads. This is not specific to the expired-magic-link path — it happens on any fresh sign-in. The expired-link steps are just the repro flow the tester was following for PR #90488.

    This also explains "Reproducible in staging: Yes / production: No" — PR #90488 is on staging but not yet in production.

    Recommendation: This likely should not block the deploy. The "regression" is an intentional UX improvement (loader instead of a blank screen). The previous behavior showed a blank screen during the same window, which is arguably worse.

    • If the team agrees the loader is acceptable → close this as working as intended and remove the deploy blocker.
    • If a spinner is specifically unwanted in this window → the narrow change would be reverting the authenticated branch fallback in AppNavigator.tsx:18 back to fallback={null}, but that reintroduces the blank screen PR auto-sign in with sign in link in separate browser #90488 was fixing.
    Investigation details

    Why it's the AppNavigator loader and not the ValidateLoginPage loader: For an expired link, autoAuthState resolves to FAILED. The ValidateLoginPage FullScreenLoadingIndicator only renders when autoAuthState === SIGNING_IN or isCompletingDirectSignIn is true (which itself requires SIGNING_IN/JUST_SIGNED_IN). Neither is met for an expired code, so the page-level loader does not fire. The spinner the tester sees comes from the AppNavigator Suspense fallback during the public→auth screen swap.

    Alternative explanations considered:

    • Lingering /v/... ValidateLoginPage route showing its own loader — ruled out; the expired flow leaves autoAuthState = FAILED, which doesn't satisfy any of that page's loader conditions.
    • A genuinely stuck/hanging spinner — ruled out; the report says the spinner appears briefly then resolves, consistent with a one-time lazy-chunk download, not a hang.

    Confidence: Medium-High. Code evidence and the PR author's own inline comments confirm the loader is intentional; "brief" duration and staging-only reproduction are consistent with the chunk-load swap. Not independently reproduced in a browser.


    Next Steps for Contributor+ team:
    To accept (revert the fallback): @MelvinBot implement reverting the AppNavigator authenticated-branch fallback to null
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you disagree this is intended behavior.

  11. blimpich commented on Jun 16, 2026

    @blimpich
    Contributor

    closing as intended behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions