You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-17] Expense - No Delete modal when opening independant tag fields after disabling Tags #93945
Version Number: 9.4.14-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#86932 Email or phone of affected tester (no customers):sdjnoisdjdosijsonssjo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Workspace has independant or dependant tags.
Go to staging.new.expensify.com
Go to workspace chat.
Create an expense and assign independant tags.
Go to workspace settings > More features.
Disable Tags.
Go back to workspace chat.
Open the expense report.
Open any tag field.
Expected Result:
Delete confirmation modal will open (similar to single-level tag).
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
After disabling the Tags feature on a workspace, tapping a tag field on an expense that still has a multi-level (independent/dependent) tag assigned opens the Tag selection RHP instead of the delete-confirmation modal. Single-level tags correctly show the delete-confirmation modal in the same scenario.
What is the root cause of that problem?
PR #86932 added the disabled-tag delete-confirmation behavior but deliberately scoped it to single-level tag lists. The gating flag explicitly excludes multi-level tags:
The trailing && !isMultiLevelTags(policyTagList) forces the flag to false for any independent/dependent tag policy. Single-level and multi-level tag rows render through the same tagList map and share one onPress handler, which only shows the modal when this flag is truthy — otherwise it falls through to navigating to the Tag RHP:
So for multi-level tags the flag is always false, the alert branch is skipped, and the RHP opens.
Evidence & data flow
policyTagLists has one entry for single-level tags, N entries for multi-level — isMultiLevelTags(policyTagList) returns true for the latter.
shouldShowTagDisabledAlert is computed once at line 452 and consumed by the shared onPress: if (shouldShowTagDisabledAlert) { showTagDisabledAlert(); return; } then Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_TAG...).
The intent comment at line 448-450 confirms the single-level scoping was intentional: "Scoped to single-level tag lists."
showTagDisabledAlert clears the tag via updateMoneyRequestTag({ ..., tag: '' }), which empties the entire transactionTag string.
What changes do you think we should make in order to solve the problem?
Remove the && !isMultiLevelTags(policyTagList) exclusion at line 452 so multi-level tags also surface the delete-confirmation modal:
Validation needed before shipping: confirm showTagDisabledAlert → updateMoneyRequestTag({ tag: '' }) correctly clears a multi-level tag value. The transactionTag for multi-level tags is a colon-delimited string spanning all levels; setting it to '' should clear the whole value (matching the "delete" intent), but this should be verified for both independent and dependent tag configurations, since the shared per-row onPress does not pass a per-level index to the alert path.
What alternative solutions did you explore?
Since this is a deploy blocker introduced by PR #86932, reverting that PR is an option, but it would also drop the 8 other fixes it contains. The one-line scope change above is the targeted fix.
Next Steps for Contributor+ team: To accept:@MelvinBot implement this to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Ah, I mean, can we call this issue a follow-up to address the multiple-level tags? We previously addressed the single-level tag in PR #86932. I am open to hearing your opinions on this issue.
@lakchote Given this, will we be eligible to get paid for this issue, or are we not?
Yes, this is payable as its own issue, no regression penalty. The delete modal was new in #86932 and we deliberately scoped it to single-level tag lists. Nothing that worked before broke, it's added scope.
Activity
applause-bot commentedon Jun 18, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/4242ecf51798043ce66d51d3f34c338e1859b113193694956336cbc9c0e8dd54
https://platform.applause.com/services/links/v1/external/95493528a429e32211cceb69008955b1e6946de487996010cf513395c8000a8e
melvin-bot commentedon Jun 18, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #86932
melvin-bot commentedon Jun 18, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 18, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mukhrr commentedon Jun 18, 2026
I don't think this is blocker too
MelvinBot commentedon Jun 18, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
After disabling the Tags feature on a workspace, tapping a tag field on an expense that still has a multi-level (independent/dependent) tag assigned opens the Tag selection RHP instead of the delete-confirmation modal. Single-level tags correctly show the delete-confirmation modal in the same scenario.
What is the root cause of that problem?
PR #86932 added the disabled-tag delete-confirmation behavior but deliberately scoped it to single-level tag lists. The gating flag explicitly excludes multi-level tags:
src/components/ReportActionItem/MoneyRequestView.tsx:452The trailing
&& !isMultiLevelTags(policyTagList)forces the flag tofalsefor any independent/dependent tag policy. Single-level and multi-level tag rows render through the sametagListmap and share oneonPresshandler, which only shows the modal when this flag is truthy — otherwise it falls through to navigating to the Tag RHP:src/components/ReportActionItem/MoneyRequestView.tsx:1003-1021So for multi-level tags the flag is always
false, the alert branch is skipped, and the RHP opens.Evidence & data flow
policyTagListshas one entry for single-level tags, N entries for multi-level —isMultiLevelTags(policyTagList)returnstruefor the latter.shouldShowTagDisabledAlertis computed once at line 452 and consumed by the sharedonPress:if (shouldShowTagDisabledAlert) { showTagDisabledAlert(); return; }thenNavigation.navigate(ROUTES.MONEY_REQUEST_STEP_TAG...).showTagDisabledAlertclears the tag viaupdateMoneyRequestTag({ ..., tag: '' }), which empties the entire transactionTag string.What changes do you think we should make in order to solve the problem?
Remove the
&& !isMultiLevelTags(policyTagList)exclusion at line 452 so multi-level tags also surface the delete-confirmation modal:Validation needed before shipping: confirm
showTagDisabledAlert→updateMoneyRequestTag({ tag: '' })correctly clears a multi-level tag value. The transactionTag for multi-level tags is a colon-delimited string spanning all levels; setting it to''should clear the whole value (matching the "delete" intent), but this should be verified for both independent and dependent tag configurations, since the shared per-rowonPressdoes not pass a per-level index to the alert path.What alternative solutions did you explore?
Since this is a deploy blocker introduced by PR #86932, reverting that PR is an option, but it would also drop the 8 other fixes it contains. The one-line scope change above is the targeted fix.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement thisto create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
27 remaining items
mukhrr commentedon Jul 16, 2026
Ah, yes. I think that makes more sense.
hoangzinh commentedon Jul 16, 2026
@lakchote Given this, will we be eligible to get paid for this issue, or are we not?
lakchote commentedon Jul 16, 2026
Yes, this is payable as its own issue, no regression penalty. The delete modal was new in #86932 and we deliberately scoped it to single-level tag lists. Nothing that worked before broke, it's added scope.
lakchote commentedon Jul 16, 2026
@mallenexpensify would you be able to process payment here? Thanks!
melvin-bot commentedon Jul 16, 2026
Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.
melvin-bot commentedon Jul 16, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
hoangzinh commentedon Jul 17, 2026
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
mallenexpensify commentedon Jul 22, 2026
@mukhrr @hoangzinh one PR fixed four bug issues, removing payment summary here and will address in