Skip to content

[Due for payment 2026-07-17] Expense - No Delete modal when opening independant tag fields after disabling Tags #93945

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.14-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #86932
Email or phone of affected tester (no customers): sdjnoisdjdosijsonssjo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Workspace has independant or dependant tags.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense and assign independant tags.
  4. Go to workspace settings > More features.
  5. Disable Tags.
  6. Go back to workspace chat.
  7. Open the expense report.
  8. Open any tag field.

Expected Result:

Delete confirmation modal will open (similar to single-level tag).

Actual Result:

Tag RHP opens.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7184721_1781793315333!Independent.-.Multi.Level.tags.csv

Bug7184721_1781793315331.3.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7184721

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 18, 2026
  2. melvin-bot commented on Jun 18, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #86932

  3. melvin-bot commented on Jun 18, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Jun 18, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. mukhrr commented on Jun 18, 2026

    @mukhrr
    Contributor

    I don't think this is blocker too

  6. MelvinBot commented on Jun 18, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    After disabling the Tags feature on a workspace, tapping a tag field on an expense that still has a multi-level (independent/dependent) tag assigned opens the Tag selection RHP instead of the delete-confirmation modal. Single-level tags correctly show the delete-confirmation modal in the same scenario.

    What is the root cause of that problem?

    PR #86932 added the disabled-tag delete-confirmation behavior but deliberately scoped it to single-level tag lists. The gating flag explicitly excludes multi-level tags:

    src/components/ReportActionItem/MoneyRequestView.tsx:452

    const shouldShowTagDisabledAlert = (!policy?.areTagsEnabled || !hasEnabledTags(policyTagLists)) && !!transactionTag && !isMultiLevelTags(policyTagList);

    The trailing && !isMultiLevelTags(policyTagList) forces the flag to false for any independent/dependent tag policy. Single-level and multi-level tag rows render through the same tagList map and share one onPress handler, which only shows the modal when this flag is truthy — otherwise it falls through to navigating to the Tag RHP:

    src/components/ReportActionItem/MoneyRequestView.tsx:1003-1021

    So for multi-level tags the flag is always false, the alert branch is skipped, and the RHP opens.

    Evidence & data flow
    • policyTagLists has one entry for single-level tags, N entries for multi-level — isMultiLevelTags(policyTagList) returns true for the latter.
    • shouldShowTagDisabledAlert is computed once at line 452 and consumed by the shared onPress: if (shouldShowTagDisabledAlert) { showTagDisabledAlert(); return; } then Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_TAG...).
    • The intent comment at line 448-450 confirms the single-level scoping was intentional: "Scoped to single-level tag lists."
    • showTagDisabledAlert clears the tag via updateMoneyRequestTag({ ..., tag: '' }), which empties the entire transactionTag string.

    What changes do you think we should make in order to solve the problem?

    Remove the && !isMultiLevelTags(policyTagList) exclusion at line 452 so multi-level tags also surface the delete-confirmation modal:

    const shouldShowTagDisabledAlert = (!policy?.areTagsEnabled || !hasEnabledTags(policyTagLists)) && !!transactionTag;

    Validation needed before shipping: confirm showTagDisabledAlert → updateMoneyRequestTag({ tag: '' }) correctly clears a multi-level tag value. The transactionTag for multi-level tags is a colon-delimited string spanning all levels; setting it to '' should clear the whole value (matching the "delete" intent), but this should be verified for both independent and dependent tag configurations, since the shared per-row onPress does not pass a per-level index to the alert path.

    What alternative solutions did you explore?

    Since this is a deploy blocker introduced by PR #86932, reverting that PR is an option, but it would also drop the 8 other fixes it contains. The one-line scope change above is the targeted fix.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement this to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. 27 remaining items

  8. mukhrr commented on Jul 16, 2026

    @mukhrr
    Contributor

    Ah, yes. I think that makes more sense.

  9. hoangzinh commented on Jul 16, 2026

    @hoangzinh
    Contributor

    Ah, I mean, can we call this issue a follow-up to address the multiple-level tags? We previously addressed the single-level tag in PR #86932. I am open to hearing your opinions on this issue.

    @lakchote Given this, will we be eligible to get paid for this issue, or are we not?

  10. lakchote commented on Jul 16, 2026

    @lakchote
    Contributor

    Yes, this is payable as its own issue, no regression penalty. The delete modal was new in #86932 and we deliberately scoped it to single-level tag lists. Nothing that worked before broke, it's added scope.

  11. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 16, 2026
  12. lakchote commented on Jul 16, 2026

    @lakchote
    Contributor

    @mallenexpensify would you be able to process payment here? Thanks!

  13. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.

  14. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. hoangzinh commented on Jul 17, 2026

    @hoangzinh
    Contributor

    Regression Test Proposal

    Precondition:

    • Workspace has independant or dependant tags.

    Test:

    1. Go to workspace chat.
    2. Create an expense and assign independant tags.
    3. Go to workspace settings > More features.
    4. Disable Tags.
    5. Go back to workspace chat.
    6. Open the expense report.
    7. Open any tag field level.
    8. Verify delete confirmation modal will open

    Do we agree 👍 or 👎

  16. mallenexpensify commented on Jul 22, 2026

    @mallenexpensify
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions