You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-17] Expense - Splits are highlighted after splitting on Spend and opening report on Inbox #93967
Version Number: 9.4.15-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#92506 Email or phone of affected tester (no customers):sjdoisnjdodsnjoi@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses.
Go to Spend > Expenses.
Select one of the expenses via checkbox.
Click dropdown button > Split > Save.
Go back to Inbox.
Open the expense report.
Expected Result:
Splits should only be highlighted on where the expense was split, which is Spend > Expenses.
Actual Result:
Splits are highlighted after splitting on Spend and opening report on Inbox.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Regression from #92506 (this issue's linked PR). The PR registered split transactions for highlighting before the navigation branch, so the registration also runs on the Spend/Search path — where the report is never opened, leaving the highlight flags stranded until the report is opened later from Inbox.
When the user splits from Spend > Expenses (isSearchPageTopmostFullScreenRoute), the flow navigates back via navigateBackToLastSuperWideRHPScreen and returns — the expense report is never opened. So the flags are written but never read/cleared. They sit in REPORT_METADATA until the user later opens that report from Inbox, at which point the list mounts and incorrectly highlights the (no longer new) split rows.
What changes do you think we should make in order to solve the problem?
Only register the pending-new transaction IDs on the path that actually opens the expense report. The Spend/Search-page early-return branch (and the !params.transactionReport?.parentReportID case that shares it) should not pollute the report's metadata.
Practically: guard the registration loop with !isSearchPageTopmostFullScreenRoute && !!params.transactionReport?.parentReportID, or move the loop below the if (isSearchPageTopmostFullScreenRoute || !params.transactionReport?.parentReportID) { … return; } branch so it runs only for the dismissModalWithReport path. Splitting from within the report keeps working because that path mounts the report and clears the flags as designed.
Why the Spend page still highlights correctly + verification notes
The issue's Expected Result confirms the Spend > Expenses highlight is the desired behavior and is unaffected — that page does not rely on REPORT_METADATA.pendingNewTransactionIDs (the only reader is MoneyRequestReportActionsList for the routed report). So scoping the registration away from the Search path does not remove any wanted highlight there.
The clear path (useNewTransactions.ts) only fires after the list mounts with matching transactions, confirming nothing clears the flags while the user stays on the Search page.
Confidence: High — code-traced end to end; matches all reported symptoms and the staging-only reproduction.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/93967) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Expense - Splits are highlighted after splitting on Spend and opening report on Inbox[/-][+][Due for payment 2026-08-17] Expense - Splits are highlighted after splitting on Spend and opening report on Inbox[/+]on Aug 17, 2026
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Sign in and open the Reports (Spend) page from the left-hand nav.
Open a workspace expense report that already contains at least two expenses, so the report is multi-transaction.
From the Spend page, select an expense and split it into two.
Verify you are returned to the Spend page and the two new split rows are briefly highlighted in yellow there.
Navigate to Inbox and open the expense report that received the splits.
Verify no rows in that report are highlighted in yellow.
Now open the same expense report directly from the Inbox and split an expense from within the report.
Verify the newly created split rows are highlighted in yellow in the report, and that pre-existing rows are not.
@mallenexpensify
This is a follow-up to #92506 and #94139. Those PRs guarded the addPendingNewTransactionIDs loop in SplitTransactionUpdate.ts, but #94670 (merged mid-review) moved rail population down into buildOnyxDataForMoneyRequest, so the guarded loop was no longer the write site and the bug remained.
Activity
applause-bot commentedon Jun 18, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/d602575b2ad89357ff3c44d0e7ae892c1bd9773682525a7506b3c5d1fb924f25
melvin-bot commentedon Jun 18, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #92506
melvin-bot commentedon Jun 18, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 18, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 18, 2026
Proposal
What is the root cause of that problem?
In
updateSplitTransactionsFromSplitExpensesFlow, PR #92506 added a loop that callsaddPendingNewTransactionIDs(targetReportID, …)for each new split. This loop runs before the navigation branch atSplitTransactionUpdate.ts:1911.addPendingNewTransactionIDspersists{pendingNewTransactionIDs: {[id]: true}}into the report'sREPORT_METADATA(PendingNewTransactions.ts:18). These flags are only consumed — and only cleared — when the expense report'sMoneyRequestReportActionsListmounts anduseNewTransactionsruns (MoneyRequestReportActionsList.tsx:126-129,useNewTransactions.ts:39-41).When the user splits from Spend > Expenses (
isSearchPageTopmostFullScreenRoute), the flow navigates back vianavigateBackToLastSuperWideRHPScreenand returns — the expense report is never opened. So the flags are written but never read/cleared. They sit inREPORT_METADATAuntil the user later opens that report from Inbox, at which point the list mounts and incorrectly highlights the (no longer new) split rows.What changes do you think we should make in order to solve the problem?
Only register the pending-new transaction IDs on the path that actually opens the expense report. The Spend/Search-page early-return branch (and the
!params.transactionReport?.parentReportIDcase that shares it) should not pollute the report's metadata.Practically: guard the registration loop with
!isSearchPageTopmostFullScreenRoute && !!params.transactionReport?.parentReportID, or move the loop below theif (isSearchPageTopmostFullScreenRoute || !params.transactionReport?.parentReportID) { … return; }branch so it runs only for thedismissModalWithReportpath. Splitting from within the report keeps working because that path mounts the report and clears the flags as designed.Why the Spend page still highlights correctly + verification notes
REPORT_METADATA.pendingNewTransactionIDs(the only reader isMoneyRequestReportActionsListfor the routed report). So scoping the registration away from the Search path does not remove any wanted highlight there.useNewTransactions.ts) only fires after the list mounts with matching transactions, confirming nothing clears the flags while the user stays on the Search page.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/93967)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
mountiny commentedon Jun 18, 2026
cc @aswin-s
This sounds minor but the authors should follow up
36 remaining items
melvin-bot commentedon Aug 14, 2026
@gijoe0295 Eep! 4 days overdue now. Issues have feelings too...
[-]Expense - Splits are highlighted after splitting on Spend and opening report on Inbox[/-][+][Due for payment 2026-08-17] Expense - Splits are highlighted after splitting on Spend and opening report on Inbox[/+]melvin-bot commentedon Aug 17, 2026
Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.
mallenexpensify commentedon Aug 18, 2026
Is this due payment? If so, how much to whom? Looks like it's a regression.
gijoe0295 commentedon Aug 19, 2026
Yes regression from #91679. Please handle payment there and close this one
gijoe0295 commentedon Aug 19, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: Fix: Splits incorrectly highlighted in Inbox after splitting from Spend page #94139 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: No
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
gijoe0295 commentedon Aug 19, 2026
@mallenexpensify
This is a follow-up to #92506 and #94139. Those PRs guarded the addPendingNewTransactionIDs loop in SplitTransactionUpdate.ts, but #94670 (merged mid-review) moved rail population down into buildOnyxDataForMoneyRequest, so the guarded loop was no longer the write site and the bug remained.