You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-08] [Export current view] Standardize export filename and rename the export option #94056
Two small polish items came up while testing "Export current view":
1. Inconsistent export filenames
The downloaded filename differs depending on which export flow is taken:
Small set / immediate download → Expensify-2026-06-19 09_30_51.006.csv
When prompted to wait or send via Concierge (even when choosing to wait) → search_export_6a350c7b2fa9e9.03383144.csv
We should standardize on a single filename format regardless of the export flow.
Decisions from discussion:
Drop the date and time from the filename — the OS already records the download timestamp, and existing Classic/NewDot exports use arbitrary, inconsistent date formats anyway.
Keep a unique ID so Concierge-delivered files don't collide.
@flaviadefaria can you double check the names and cases? We were already lowercasing the custom template file names so it is easier to sanitize the name, so I kept that, but if you feel strongly that we should not I can update it.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: New Feature
Link to the comment on the Issue: New Feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Open Search and confirm the export menu option reads Current view (not "Export current view").
Select a few expenses and export via Basic export; verify the downloaded file is named expensify_easic_export_.csv with no date/time in the name.
Select a few expenses and export via Current view; verify the file is named expensify_current_view_.csv.
Select all matching items and export; verify the async/Concierge-delivered file uses the same expensify__.csv pattern.
Export via All Data - expense level; verify the file is named expensify_all_data_-expense_level_export.csv.
Download a receipt/attachment and verify it still includes a timestamp in its filename (regression check that the appendTimestamp default is unchanged).
Activity
rlinoz commentedon Jun 19, 2026
@flaviadefaria can you double check the names and cases? We were already lowercasing the custom template file names so it is easier to sanitize the name, so I kept that, but if you feel strongly that we should not I can update it.
current view all items - expensify_current_view_6a359a75ccd462.47569524.csv
basic export all items - expensify_basic_export_6a359a5aa9ac34.45267754.csv
current view few items - expensify_current_view_3335671262557474171.csv
basic export few items - expensify_basic_export_1774403603089890602.csv
policy template - expensify_export_1_6a359a4077ee40_07418607.csv
custom template with custom prefix - custom_base_name_custom_thing_6a359a23e15e22_12902904.csv
default templates - expensify_all_data_-_expense_level_6a359a10a4b7f6_83377776.csv
flaviadefaria commentedon Jun 19, 2026
Sounds good. Let’s stick with the current standard and keep it lowercase.
rlinoz commentedon Jun 22, 2026
Not overdue, putting PRs up today.
flaviadefaria commentedon Jun 26, 2026
@rlinoz when do you expect to have the PR ready?
rlinoz commentedon Jun 26, 2026
It is being reviewed currently. I will address the PR comments today and request another review.
10 remaining items
parasharrajat commentedon Jul 2, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: New Feature
Link to the comment on the Issue: New Feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/658054
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-6806-a096-d9a9-1055576697a4melvin-bot commentedon Jul 7, 2026
Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.
melvin-bot commentedon Jul 7, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Jul 9, 2026
Payment Summary
Contributor+: @parasharrajat due $250 via NewDot
^ Test case created. Thx
parasharrajat commentedon Aug 6, 2026
Payment requested as per #94056 (comment)
garrettmknight commentedon Aug 10, 2026
$250 approved for @parasharrajat