You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-30] [Due for payment 2026-06-29] Spend rule - Unable to navigate to All currencies option by keyboard #94092
Version Number: 9.4.16-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#93063 Email or phone of affected tester (no customers):applausetester+khcategory19@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Enable Expensify card and Rules.
Workspace has at least one virtual Expensify card.
Create a spend rule in workspace settings > Rules.
Go to staging.new.expensify.com
Go to workspace settings > Rules.
Open the spend rule.
Click Permitted currencies.
Press keyboard up or down to navigate to All currencies option.
Expected Result:
User can navigate to All currencies option by keyboard.
Actual Result:
User cannot navigate to All currencies option by keyboard.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The All currencies (select‑all) toggle is rendered inside the SelectionList's customListHeaderContent, which is purely presentational and lives outside the arrow‑key focus space. The SelectionList arrow‑key focus manager only iterates over items in the data array (maxIndex: data.length - 1), so header content can never receive keyboard focus — it's mouse/tap‑only.
In SpendRulesCurrencyBase.tsx the MultiSelectListItem for "All currencies" is built into ListHeaderContent and even hardcodes isFocused={false}, then passed via customListHeaderContent at line 181. Up/down arrows cycle only through the currency rows in data and skip it entirely.
Code evidence (SelectionList)
Focus manager is bounded by data only: BaseSelectionList.tsx:217-239 — useArrowKeyFocusManager({ maxIndex: data.length - 1, disabledIndexes: dataDetails.disabledArrowKeyIndexes, ... }).
customListHeaderContent is rendered in FlashList's ListHeaderComponent, outside the indexable dataset: BaseSelectionList.tsx:622-650.
This is why the bug is web/keyboard‑only — on touch/mouse the header item is still tappable.
What changes do you think we should make in order to solve the problem?
Make the "All currencies" toggle a real focusable list row instead of header content:
Prepend a synthetic select‑all item (e.g. keyForList: 'select-all') to the data passed to SelectionList, so it participates in arrow‑key navigation.
In onSelectRow, branch on that key and call toggleSelectAll for it, otherwise call toggleCurrency as today.
Keep the locked settlement‑currency row in customListHeaderContent (it's read‑only, so it doesn't need to be focusable).
Alternatively, use the SelectionList's built‑in select‑all (pass onSelectAll/shouldShowSelectAllButton). Note, however, that the built‑in select‑all also renders as a header checkbox/button reached via Tab, not arrow keys — so if the requirement is specifically up/down arrow navigation, the synthetic‑data‑row approach above is the reliable fix.
What alternative solutions did you explore? (Optional)
Considered leaving it as Tab‑focusable only, but the report explicitly expects up/down arrow navigation to reach "All currencies", which only the data‑row approach satisfies.
Confidence: High — code evidence end‑to‑end; the header item is structurally excluded from the arrow‑key index space and is also hardcoded isFocused={false}.
Since this is a deploy blocker on a brand‑new feature, a CP‑targeted fix (or revert of the currency‑selection portion) are both viable to clear the blocker quickly.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/94092) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Spend rule - Unable to navigate to All currencies option by keyboard[/-][+][Due for payment 2026-06-29] Spend rule - Unable to navigate to All currencies option by keyboard[/+]on Jun 22, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
changed the title [-][Due for payment 2026-06-29] Spend rule - Unable to navigate to All currencies option by keyboard[/-][+][Due for payment 2026-06-30] [Due for payment 2026-06-29] Spend rule - Unable to navigate to All currencies option by keyboard[/+]on Jun 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.17-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 19, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/b1bd9b03f428d1807cfed698cf86cd1bb692ce4550af93ec90a873b133db23ba
melvin-bot commentedon Jun 19, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #93063
melvin-bot commentedon Jun 19, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 19, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 19, 2026
Proposal
What is the root cause of that problem?
The All currencies (select‑all) toggle is rendered inside the SelectionList's
customListHeaderContent, which is purely presentational and lives outside the arrow‑key focus space. TheSelectionListarrow‑key focus manager only iterates over items in thedataarray (maxIndex: data.length - 1), so header content can never receive keyboard focus — it's mouse/tap‑only.In
SpendRulesCurrencyBase.tsxtheMultiSelectListItemfor "All currencies" is built intoListHeaderContentand even hardcodesisFocused={false}, then passed viacustomListHeaderContentat line 181. Up/down arrows cycle only through the currency rows indataand skip it entirely.Code evidence (SelectionList)
dataonly:BaseSelectionList.tsx:217-239—useArrowKeyFocusManager({ maxIndex: data.length - 1, disabledIndexes: dataDetails.disabledArrowKeyIndexes, ... }).disabledArrowKeyIndexesis reduced solely fromdata:BaseSelectionList.tsx:131-168.customListHeaderContentis rendered in FlashList'sListHeaderComponent, outside the indexable dataset:BaseSelectionList.tsx:622-650.This is why the bug is web/keyboard‑only — on touch/mouse the header item is still tappable.
What changes do you think we should make in order to solve the problem?
Make the "All currencies" toggle a real focusable list row instead of header content:
keyForList: 'select-all') to thedatapassed toSelectionList, so it participates in arrow‑key navigation.onSelectRow, branch on that key and calltoggleSelectAllfor it, otherwise calltoggleCurrencyas today.customListHeaderContent(it's read‑only, so it doesn't need to be focusable).Alternatively, use the SelectionList's built‑in select‑all (pass
onSelectAll/shouldShowSelectAllButton). Note, however, that the built‑in select‑all also renders as a header checkbox/button reached via Tab, not arrow keys — so if the requirement is specifically up/down arrow navigation, the synthetic‑data‑row approach above is the reliable fix.What alternative solutions did you explore? (Optional)
Considered leaving it as Tab‑focusable only, but the report explicitly expects up/down arrow navigation to reach "All currencies", which only the data‑row approach satisfies.
Investigation notes
SpendRulesCurrencyBase.tsxis a new file in that PR — consistent with "N/A in production, new feature".isFocused={false}.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/94092)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
JS00001 commentedon Jun 22, 2026
This feature was CPd to be hidden:
[-]Spend rule - Unable to navigate to All currencies option by keyboard[/-][+][Due for payment 2026-06-29] Spend rule - Unable to navigate to All currencies option by keyboard[/+]melvin-bot commentedon Jun 22, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 22, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-29. 🎊
melvin-bot commentedon Jun 22, 2026
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
JS00001 commentedon Jun 23, 2026
I think this one is fine. Its the header component, which follows the behavior of other 'select all's
[-][Due for payment 2026-06-29] Spend rule - Unable to navigate to All currencies option by keyboard[/-][+][Due for payment 2026-06-30] [Due for payment 2026-06-29] Spend rule - Unable to navigate to All currencies option by keyboard[/+]melvin-bot commentedon Jun 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.17-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-30. 🎊
melvin-bot commentedon Jun 23, 2026
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]