Skip to content

[Due for payment 2026-06-30] [Due for payment 2026-06-29] Spend rule - Unable to navigate to All currencies option by keyboard #94092

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.16-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #93063
Email or phone of affected tester (no customers): applausetester+khcategory19@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Enable Expensify card and Rules.
  • Workspace has at least one virtual Expensify card.
  • Create a spend rule in workspace settings > Rules.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Rules.
  3. Open the spend rule.
  4. Click Permitted currencies.
  5. Press keyboard up or down to navigate to All currencies option.

Expected Result:

User can navigate to All currencies option by keyboard.

Actual Result:

User cannot navigate to All currencies option by keyboard.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7185667_1781886950600.6.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Nathan Lemma
Bug ID: 7185667

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 19, 2026
  2. applause-bot commented on Jun 19, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/b1bd9b03f428d1807cfed698cf86cd1bb692ce4550af93ec90a873b133db23ba

  3. melvin-bot commented on Jun 19, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #93063

  4. melvin-bot commented on Jun 19, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 19, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 19, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The All currencies (select‑all) toggle is rendered inside the SelectionList's customListHeaderContent, which is purely presentational and lives outside the arrow‑key focus space. The SelectionList arrow‑key focus manager only iterates over items in the data array (maxIndex: data.length - 1), so header content can never receive keyboard focus — it's mouse/tap‑only.

    In SpendRulesCurrencyBase.tsx the MultiSelectListItem for "All currencies" is built into ListHeaderContent and even hardcodes isFocused={false}, then passed via customListHeaderContent at line 181. Up/down arrows cycle only through the currency rows in data and skip it entirely.

    Code evidence (SelectionList)

    This is why the bug is web/keyboard‑only — on touch/mouse the header item is still tappable.

    What changes do you think we should make in order to solve the problem?

    Make the "All currencies" toggle a real focusable list row instead of header content:

    • Prepend a synthetic select‑all item (e.g. keyForList: 'select-all') to the data passed to SelectionList, so it participates in arrow‑key navigation.
    • In onSelectRow, branch on that key and call toggleSelectAll for it, otherwise call toggleCurrency as today.
    • Keep the locked settlement‑currency row in customListHeaderContent (it's read‑only, so it doesn't need to be focusable).

    Alternatively, use the SelectionList's built‑in select‑all (pass onSelectAll/shouldShowSelectAllButton). Note, however, that the built‑in select‑all also renders as a header checkbox/button reached via Tab, not arrow keys — so if the requirement is specifically up/down arrow navigation, the synthetic‑data‑row approach above is the reliable fix.

    What alternative solutions did you explore? (Optional)

    Considered leaving it as Tab‑focusable only, but the report explicitly expects up/down arrow navigation to reach "All currencies", which only the data‑row approach satisfies.

    Investigation notes
    • Introduced by [Payment due @marufsharifi] Add currency selection to card rules #93063 ("Add currency selection to card rules"); SpendRulesCurrencyBase.tsx is a new file in that PR — consistent with "N/A in production, new feature".
    • Confidence: High — code evidence end‑to‑end; the header item is structurally excluded from the arrow‑key index space and is also hardcoded isFocused={false}.
    • Since this is a deploy blocker on a brand‑new feature, a CP‑targeted fix (or revert of the currency‑selection portion) are both viable to clear the blocker quickly.

    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94092) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. self-assigned this
    on Jun 22, 2026
  8. JS00001 commented on Jun 22, 2026

    @JS00001
    Contributor

    This feature was CPd to be hidden:

    Image
  9. added and removed
    ReviewingHas a PR in review
    on Jun 22, 2026
  10. changed the title [-]Spend rule - Unable to navigate to All currencies option by keyboard[/-] [+][Due for payment 2026-06-29] Spend rule - Unable to navigate to All currencies option by keyboard[/+] on Jun 22, 2026
  11. melvin-bot commented on Jun 22, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jun 22, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-29. 🎊

  13. melvin-bot commented on Jun 22, 2026

    @melvin-bot

    @luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  14. JS00001 commented on Jun 23, 2026

    @JS00001
    Contributor

    I think this one is fine. Its the header component, which follows the behavior of other 'select all's

  15. changed the title [-][Due for payment 2026-06-29] Spend rule - Unable to navigate to All currencies option by keyboard[/-] [+][Due for payment 2026-06-30] [Due for payment 2026-06-29] Spend rule - Unable to navigate to All currencies option by keyboard[/+] on Jun 23, 2026
  16. melvin-bot commented on Jun 23, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.17-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-30. 🎊

  17. melvin-bot commented on Jun 23, 2026

    @melvin-bot

    @luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions