You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version Number: 9.4.16-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#93063 Email or phone of affected tester (no customers):applausetester+bm889072@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: android App Component: Workspace Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The "currency mismatch" modal is the global confirm modal opened by openCurrenciesCurrencyMismatchModal, triggered from the Permitted Currencies menu item via chooseCurrencies when no shared settlement currency is found (e.g. no cards selected yet).
The flicker is a modal remount on repeated taps, which is exactly why the repro note says "might need to click a few times":
The Permitted Currencies row is a MenuItemWithTopDescription with a plain onPress={chooseCurrencies} and no singleExecution/throttle — onPress fires on every tap.
showConfirmModal is called without an id, so each tap pushes a brand-new modal onto the global stack with a fresh incrementing id (modalID = id ?? String(modalIDRef.current++)).
The provider renders only the top modal, keyed by that id: key={modalToRender.id}. A second tap changes the key, so React unmounts the in-flight ConfirmModalWrapper and mounts a new one, re-running the entrance animation while the previous one is torn down → visible flicker (most noticeable on Android).
A single tap keeps the key stable ("1") and animates in smoothly; multiple taps are what produce the flicker. This is a regression introduced by #93063 (new feature). The same pattern also affects openMaxAmountCurrencyMismatchModal.
What changes do you think we should make in order to solve the problem?
Pass a stable id to showConfirmModal for both currency-mismatch modals. The global modal system is designed to dedupe by id: when an id is supplied, showModal updates the existing modal in place instead of appending a new one, so the React key stays constant and the modal no longer remounts/flickers on repeated taps.
Give openCurrenciesCurrencyMismatchModal a constant id (e.g. id: 'spendRuleCurrenciesCurrencyMismatch') and openMaxAmountCurrencyMismatchModal its own (e.g. id: 'spendRuleMaxAmountCurrencyMismatch').
What alternative solutions did you explore? (Optional)
Guard re-entry by passing singleExecution/debouncing the menu item's onPress (or early-returning while a modal is already open). This also stops the flicker but the id approach is the system's intended dedup mechanism and is more localized.
Confidence & verification
Medium–High. The full chain is traced in code (no tap throttle → no id → incrementing modal id → keyed remount). Not yet runtime-verified that react-native-modal visibly re-animates on remount on Android, but the "click a few times" repro corroborates the remount mechanism. Worth a quick on-device confirmation after the fix.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/94116) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
changed the title [-][Due for payment 2026-06-29] Rules - Currency mismatch modal flickers[/-][+][Due for payment 2026-06-30] [Due for payment 2026-06-29] Rules - Currency mismatch modal flickers[/+]on Jun 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.17-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.27-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 20, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/021ee6cc44cefc470ba27c3e99647efc9393e19ce81130a61f45d36219e708c8
melvin-bot commentedon Jun 20, 2026
@luacmartins recently merged #93063, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Jun 20, 2026
Triggered auto assignment to @NikkiWines (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 20, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 20, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 20, 2026
Proposal
What is the root cause of that problem?
The "currency mismatch" modal is the global confirm modal opened by
openCurrenciesCurrencyMismatchModal, triggered from thePermitted Currenciesmenu item viachooseCurrencieswhen no shared settlement currency is found (e.g. no cards selected yet).The flicker is a modal remount on repeated taps, which is exactly why the repro note says "might need to click a few times":
Permitted Currenciesrow is aMenuItemWithTopDescriptionwith a plainonPress={chooseCurrencies}and nosingleExecution/throttle —onPressfires on every tap.showConfirmModalis called without anid, so each tap pushes a brand-new modal onto the global stack with a fresh incrementing id (modalID = id ?? String(modalIDRef.current++)).key={modalToRender.id}. A second tap changes the key, so React unmounts the in-flightConfirmModalWrapperand mounts a new one, re-running the entrance animation while the previous one is torn down → visible flicker (most noticeable on Android).A single tap keeps the key stable (
"1") and animates in smoothly; multiple taps are what produce the flicker. This is a regression introduced by #93063 (new feature). The same pattern also affectsopenMaxAmountCurrencyMismatchModal.What changes do you think we should make in order to solve the problem?
Pass a stable
idtoshowConfirmModalfor both currency-mismatch modals. The global modal system is designed to dedupe byid: when anidis supplied,showModalupdates the existing modal in place instead of appending a new one, so the Reactkeystays constant and the modal no longer remounts/flickers on repeated taps.openCurrenciesCurrencyMismatchModala constant id (e.g.id: 'spendRuleCurrenciesCurrencyMismatch') andopenMaxAmountCurrencyMismatchModalits own (e.g.id: 'spendRuleMaxAmountCurrencyMismatch').What alternative solutions did you explore? (Optional)
singleExecution/debouncing the menu item'sonPress(or early-returning while a modal is already open). This also stops the flicker but theidapproach is the system's intended dedup mechanism and is more localized.Confidence & verification
Medium–High. The full chain is traced in code (no tap throttle → no
id→ incrementing modal id → keyed remount). Not yet runtime-verified that react-native-modal visibly re-animates on remount on Android, but the "click a few times" repro corroborates the remount mechanism. Worth a quick on-device confirmation after the fix.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/94116)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
Dip-G-Git commentedon Jun 21, 2026
melvin-bot commentedon Jun 21, 2026
NikkiWines commentedon Jun 22, 2026
@JS00001 looks like #93063 introduced this issue. Could you please take a look 🙇 cc: @marufsharifi @luacmartins as you both approved
12 remaining items
melvin-bot commentedon Jun 22, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-29. 🎊
melvin-bot commentedon Jun 22, 2026
@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[-][Due for payment 2026-06-29] Rules - Currency mismatch modal flickers[/-][+][Due for payment 2026-06-30] [Due for payment 2026-06-29] Rules - Currency mismatch modal flickers[/+]melvin-bot commentedon Jun 23, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.17-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-30. 🎊
melvin-bot commentedon Jun 23, 2026
@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[-][Due for payment 2026-06-30] [Due for payment 2026-06-29] Rules - Currency mismatch modal flickers[/-][+][Due for payment 2026-07-13] Rules - Currency mismatch modal flickers[/+]melvin-bot commentedon Jul 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.27-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-13. 🎊
melvin-bot commentedon Jul 6, 2026
@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]