Skip to content

[Due for payment 2026-06-29] Payment issue for E/App PR#93588 #94223

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #93588
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @Ollyws.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Jun 22, 2026

    @melvin-bot
    Author

    @Ollyws The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. melvin-bot commented on Jun 26, 2026

    @melvin-bot
    Author

    @Ollyws Whoops! This issue is 2 days overdue. Let's get this updated quick!

  3. melvin-bot commented on Jun 28, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  4. melvin-bot commented on Jun 28, 2026

    @melvin-bot
    Author

    Payment Summary

    Upwork Job

    • Reviewer: @Ollyws owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  5. Ollyws commented on Jun 29, 2026

    @Ollyws
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other: Planned code removal

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A planned code removal

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    • Create a test account with + in email (e.g., yourname+test1@gmail.com) to mark it as a test account
      You will need access to at least one paid workspace (Team or Corporate type)
      If you don't have a paid workspace, create one via Settings → Workspaces → New Workspace → Select "Team" or "Corporate"

    Test:

    Test 1: Create an Expense — Choose recipient (Personal / self-DM vs. Workspace)
    
        1. Log in with a test account that is a member of a Team or Corporate workspace
        2. Tap the green FAB (+) button → "Create expense" from the menu
        3. Enter an amount (e.g., $25.00) on the Manual tab and tap Next
        4. On the "Choose recipient" page, Verify the following appears:
        5.     Personal (your own name/avatar at the top) — this creates a tracked expense in your self-DM
        6.     Your Team/Corporate workspaces — selecting one submits the expense to that workspace
        7. Tap your own name (Personal) and create the expense
        8. Verify: The expense is created in your self-DM (the "(you)" chat)
    
    Test 1b: Create Expense — Submit to a workspace
    
        1. Repeat steps 1–3 above
        2. Select one of your Team/Corporate workspaces instead of Personal
        3. Verify: The confirmation opens with that workspace as the recipient
        4. Tap Create expense
        5. Verify: The expense is created on the selected workspace
    
    Test 1c: Create Expense — Per Diem recipient filtering
    
        1. Ensure at least one Corporate workspace has Per diem enabled with rates and another paid workspace does NOT
        2. Tap FAB (+) → "Create expense" → switch to the Per Diem tab
        3. Enter a per diem destination/details and proceed to "Choose recipient"
        4. Verify: Only workspaces where per diem can be submitted are listed; the workspace without per diem is NOT shown
    
    Test 2: Per Diem Expense
    
    Setup: On a Corporate workspace, go to Settings → Workspaces → [workspace] → Per diem, enable Per diem, and add a rate (e.g., "Daily", $100).
    
        1. Tap the green FAB (+) button → "Create expense" → Per Diem tab
        2. Verify: Only workspaces with Per Diem enabled appear; others are NOT shown
        3. Select the workspace, pick your rate, enter dates, and create the expense
        4. Verify: The per diem expense is created with no console errors
    
    Test 2b: Per Diem — no eligible workspace
    
        1. Disable Per Diem on all your workspaces
        2. Tap FAB (+) → "Create expense"
        3. Verify: Per Diem tab is not available for selection
    
    Test 3: Time Tracking
    
    Setup: On a Corporate workspace, go to Settings → Workspaces → [workspace] → Time and enable Time tracking.
    
        1. Tap the green FAB (+) button → "Create expense" → Time tab
        2. Verify: Only workspaces with Time tracking enabled appear
        3. Select the workspace, enter time (e.g., 2 hours), add a description, and create the expense
        4. Verify: The time expense is created with no console errors
    
    Test 4: Split Expense
    
        1. Open a DM chat with another user
        2. Tap the green FAB (+) button → "Split expense"
        3. Enter an amount (e.g., $50.00) and select participants
        4. For a distance split, Verify: rates from your paid workspaces appear in the Rate field
        5. Submit the split
        6. Verify: The split appears in the chat with no console errors
    
    Test 5: Change Expense Workspace
    
        1. Log in with an account that has at least 2 paid workspaces
        2. Open an expense on Workspace A and tap more Change Workspace
        3. Verify: Only eligible paid workspaces are shown;
        4. Select Workspace B and save
        5. Verify: The expense moves to Workspace B with no console errors
    

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-33af-a228-c900-68ecd3fc8ac4
  6. melvin-bot commented on Jul 1, 2026

    @melvin-bot
    Author

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  7. mallenexpensify commented on Jul 2, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @Ollyws due $250 via NewDot

    ^ Test case created. Thx

  8. flaviadefaria commented on Jul 7, 2026

    @flaviadefaria
    Contributor

    Approved: @Ollyws owed $250 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions