Skip to content

[Due for payment 2026-07-03] [Due for payment 2026-07-01] [Due for payment 2026-06-30] Android & iOS - Expense - Description field is not visible when focused #94274

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.17-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #94134
Email or phone of affected tester (no customers): sdjnoisdjdosijsonssjo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Money Requests

Action Performed:

  1. Launch Expensify app.
  2. Open 1:1 DM with user.
  3. Tap + > Create expense > Manual.
  4. Tap Description field.

Expected Result:

Description field will be visible when focused.

Actual Result:

Description field is not visible when focused.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7188124_1782174619506.Screen_Recording_20260623_082828_Expensify.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7188124

Issue OwnerCurrent Issue Owner: @aimane-chnaif

Activity

  1. applause-bot commented on Jun 23, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/2898d187600fe647513bf343ead480d087a3e9a13828475806301613a1145994

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 23, 2026
  3. melvin-bot commented on Jun 23, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #94134

  4. melvin-bot commented on Jun 23, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 23, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 23, 2026

    @MelvinBot
    Contributor

    Issue Analysis

    Root Cause: PR #94134 ("remove isNewManualExpenseFlowEnabled beta flag") made the new inline manual‑expense flow the default for everyone. In that flow the Description field is now an inline TextInput rendered inside the confirmation list's FlashList footer (DescriptionField.tsx:88). The FlashList that renders it has no keyboard‑aware scrolling (BaseSelectionListWithSections.tsx:317-339 — keyboardShouldPersistTaps only, no automaticallyAdjustKeyboardInsets / scroll‑to‑focused‑input). On native, the ScreenWrapper KeyboardAvoidingView only shrinks the container; it never scrolls a focused footer input above the soft keyboard, so the focused Description field stays hidden behind it. Web/mWeb don't reproduce because the browser auto‑scrolls focused inputs into view.

    Before the PR, the default (beta‑off) behavior rendered a navigate‑away MenuItemWithTopDescription that opened a separate full‑screen page, so the keyboard never overlapped an inline field — which is why this is "new feature, not in prod."

    Recommended Fix: Add keyboard‑aware scroll‑into‑view to the confirmation list so the focused footer input scrolls above the keyboard on native. Practical options:

    • Add automaticallyAdjustKeyboardInsets to the FlashList in BaseSelectionListWithSections.tsx:317 (helps iOS; verify Android), and/or
    • Programmatically scrollToEnd/scroll-to-focused on the list when the Description (and Merchant) input focuses.

    ⚠️ Likely the same regression affects the Merchant field (MerchantField.tsx), which the same PR also flipped to an inline footer input — please verify and fix both.

    Fastest mitigation (deploy blocker): Since this is a 1:1 revert of a beta‑flag removal, reverting #94134 restores the previous (navigate‑away) Description/Merchant fields and unblocks the deploy if a proper keyboard‑aware fix can't land quickly.

    Investigation details & evidence

    Render path (new flow):

    1. + > Create expense > Manual → IOURequestStartPage.tsx renders the embedded IOURequestStepConfirmation (shouldHideHeader).
    2. → its own ScreenWrapper (IOURequestStepConfirmation.tsx:716) → MoneyRequestConfirmationList.
    3. → SelectionListWithSections (FlashList); the editable Description TextInput lives in the list's ListFooterComponent.
    4. Tap Description → TextInput focuses → soft keyboard opens → footer input is not scrolled into view on native (BUG).

    Why only native: KeyboardAvoidingView (via ScreenWrapper) only resizes the container. The FlashList has keyboardShouldPersistTaps="always" but no automaticallyAdjustKeyboardInsets and no scroll‑to‑focused‑input mechanism. On web the browser scrolls the focused input into view automatically, so it's not reproducible there.

    PR #94134 diff confirms scope: The two start/confirmation files only had beta‑gate removals (e.g. shouldEnableKeyboardAvoidingView={isNewManualExpenseFlowEnabled} → shouldEnableKeyboardAvoidingView); DescriptionField.tsx flipped {isNewManualExpenseFlowEnabled && !isReadOnly ? → {!isReadOnly ?. No scroll wrapper was deliberately removed — the missing scroll‑into‑view is inherent to the inline‑footer design, simply made default by the PR.

    Confidence: High — deterministic structural UI issue; root cause located with file:line evidence, no production logs needed.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94274) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. trjExpensify commented on Jun 23, 2026

    @trjExpensify
    Contributor

    This repro's reliably outside of a DM as well. CC: @thelullabyy

  8. m-natarajan commented on Jun 23, 2026

    @m-natarajan

    Xiaomi Redmi Note 10 / Android 12
    app 9.4.17-1 (Pending validation in iOS)
    Not repro

    Screenrecorder-2026-06-23-17-34-46-55.mp4
  9. 43 remaining items

  10. melvin-bot commented on Jul 2, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. aimane-chnaif commented on Jul 3, 2026

    @aimane-chnaif
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: follow-up of new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/656578

    Regression Test Proposal

    Precondition

    Enable newManualExpenseFlow beta until this feature is fully released to production

    Test:

    1. Tap + > Create expense > Manual.
    2. Tap Description field.
    3. Verify that description field is visible when focused.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-b749-a9d9-71f7-8fc120bee074
  12. mallenexpensify commented on Jul 6, 2026

    @mallenexpensify
    Contributor

    With this being a regression, was there a reason that @ikevin127 the reviewer on the PR that caused this regression wasn't assigned to review this?

    @thelullabyy are you due payment? I see this is a regression. Thx

  13. added and removed on Jul 9, 2026
  14. thelullabyy commented on Jul 9, 2026

    @thelullabyy
    Contributor

    @mallenexpensify Yes, I am due for payment here. This is not a regression but a pre-exist bug

    cc @puneetlath

  15. mallenexpensify commented on Jul 9, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @thelullabyy due $250 via NewDot
    Contributor+: @aimane-chnaif due $250 via NewDot

    I think/hope that's alright. Think we're good to close, comment or reopen if you disagree. cc @puneetlath

  16. laurenreidexpensify commented on Aug 12, 2026

    @laurenreidexpensify
    Contributor

    $250 approved for @thelullabyy

  17. garrettmknight commented on Aug 25, 2026

    @garrettmknight
    Contributor

    $250 approved for @aimane-chnaif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions