You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android - Rules - Save button is hidden behind nav bar, Save button disappears when offline #94468
Version Number: 9.4.18-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#93185 Email or phone of affected tester (no customers):applausetester+ssndjois2jd1@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Workspace Settings
Action Performed:
Precondition:
Set device navigation to bar instead of gestures.
Enable Rules.
Launch Expensify app.
Go to workspace settings > Rules.
Open Flag receipt line items.
→ BUG 1: Save button is hidden behind device navigation bar.
Go offline.
→ BUG 2: Save button disappears in offline mode.
Tap app back button.
Repeat Step 3 and 4 with Require fields for all expenses.
Expected Result:
BUG 1: Save button will appear above device navigation bar.
BUG 2: Save button will not disappear in offline mode.
Actual Result:
BUG 1: Save button is hidden behind device navigation bar.
BUG 2: Save button disappears in offline mode.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Both bugs share a single root cause introduced in #93185 (Rules Revamp R1).
What is the root cause of that problem?
The two new revamp screens — Flag receipt line items (RulesProhibitedDefaultPage.tsx:161-171) and Require fields (RulesRequireFieldsPage.tsx:139-147) — render their Save button in a plain <View style={[styles.ph5, styles.pb5]}> placed as a sibling of the ScrollView inside a ScreenWrapper that has enableEdgeToEdgeBottomSafeAreaPadding.
A plain View does not apply any bottom safe-area handling, so:
BUG 1 (hidden behind nav bar): With edge-to-edge enabled, content extends under the system navigation bar. The ScrollView gets addBottomSafeAreaPadding, but the footer View does not — so on a soft-key (nav-bar) device the button is drawn behind the nav bar.
BUG 2 (disappears offline):ScreenWrapper renders the offline indicator stuck to the bottom of the screen when offline (ScreenWrapperOfflineIndicators.tsx). The footer View reserves no space for it, so the indicator overlays the Save button.
The correct primitive is FixedFooter, which runs useBottomSafeSafeAreaPaddingStyle and exposes both addBottomSafeAreaPadding (clears the nav bar) and addOfflineIndicatorBottomSafeAreaPadding (clears the offline indicator). The sibling rules screens that use FormProvider (e.g. RulesRequireReceiptsPage) get this for free and are unaffected.
What changes do you think we should make in order to solve the problem?
In both pages, replace the plain footer <View style={[styles.ph5, styles.pb5]}> wrapping the Save Button with the FixedFooter component, passing addBottomSafeAreaPadding and addOfflineIndicatorBottomSafeAreaPadding. FixedFooter already applies ph5 and bottom padding, so the manual ph5/pb5 can be dropped. This fixes both bugs in both screens with one shared, established pattern.
Why this fixes both symptoms
addBottomSafeAreaPadding → button sits above the device navigation bar (BUG 1).
addOfflineIndicatorBottomSafeAreaPadding → footer reserves room for the bottom offline indicator instead of being covered by it (BUG 2).
Both buggy footers are guarded by isRevamp / the new pages only, which matches the report ("N/A - new feature, doesn't exist in prod").
What alternative solutions did you explore? (Optional)
Manually adding bottom safe-area insets to the existing View via useSafeAreaInsets would address BUG 1 but not the offline-indicator overlap (BUG 2) cleanly. Using FixedFooter is the canonical solution and covers both.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/94468) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Activity
applause-bot commentedon Jun 24, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/0e82c7655cbcbd27e2ecd6c3b7eff7068dad5c07939443516b436ef15e21522b
melvin-bot commentedon Jun 24, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #93185
melvin-bot commentedon Jun 24, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 24, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 24, 2026
Proposal
What is the root cause of that problem?
The two new revamp screens — Flag receipt line items (
RulesProhibitedDefaultPage.tsx:161-171) and Require fields (RulesRequireFieldsPage.tsx:139-147) — render their Save button in a plain<View style={[styles.ph5, styles.pb5]}>placed as a sibling of theScrollViewinside aScreenWrapperthat hasenableEdgeToEdgeBottomSafeAreaPadding.A plain
Viewdoes not apply any bottom safe-area handling, so:ScrollViewgetsaddBottomSafeAreaPadding, but the footerViewdoes not — so on a soft-key (nav-bar) device the button is drawn behind the nav bar.ScreenWrapperrenders the offline indicator stuck to the bottom of the screen when offline (ScreenWrapperOfflineIndicators.tsx). The footerViewreserves no space for it, so the indicator overlays the Save button.The correct primitive is
FixedFooter, which runsuseBottomSafeSafeAreaPaddingStyleand exposes bothaddBottomSafeAreaPadding(clears the nav bar) andaddOfflineIndicatorBottomSafeAreaPadding(clears the offline indicator). The sibling rules screens that useFormProvider(e.g.RulesRequireReceiptsPage) get this for free and are unaffected.What changes do you think we should make in order to solve the problem?
In both pages, replace the plain footer
<View style={[styles.ph5, styles.pb5]}>wrapping the SaveButtonwith theFixedFootercomponent, passingaddBottomSafeAreaPaddingandaddOfflineIndicatorBottomSafeAreaPadding.FixedFooteralready appliesph5and bottom padding, so the manualph5/pb5can be dropped. This fixes both bugs in both screens with one shared, established pattern.Why this fixes both symptoms
addBottomSafeAreaPadding→ button sits above the device navigation bar (BUG 1).addOfflineIndicatorBottomSafeAreaPadding→ footer reserves room for the bottom offline indicator instead of being covered by it (BUG 2).Both buggy footers are guarded by
isRevamp/ the new pages only, which matches the report ("N/A - new feature, doesn't exist in prod").What alternative solutions did you explore? (Optional)
Manually adding bottom safe-area insets to the existing
ViewviauseSafeAreaInsetswould address BUG 1 but not the offline-indicator overlap (BUG 2) cleanly. UsingFixedFooteris the canonical solution and covers both.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/94468)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
luacmartins commentedon Jun 24, 2026
Feature is behind a beta, NAB.
melvin-bot commentedon Jun 29, 2026
@Krishna2323 Eep! 4 days overdue now. Issues have feelings too...
Krishna2323 commentedon Jun 30, 2026
@luacmartins This is fixed on main, we can close this issue.
Monosnap.screencast.2026-07-01.04-39-59.mp4