You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [Exploratory] Public room - Unable to open Public room after tap the "here" hyperlink on Concierge message #94783
changed the title [-][Exploratory] Public room-Unable to open Public room after tap the "here" hyperlink on Concierge message[/-][+][Exploratory] Public room - Unable to open Public room after tap the "here" hyperlink on Concierge message[/+]on Jun 28, 2026
📣 @nonunosu29! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Please re-state the problem that we are trying to solve in this issue.
After a signed-out user opens a public room via deep link, signs in, completes onboarding, taps the “here” link on the Concierge message, backs out to the Account page, and then taps the public room in the LHN, nothing happens — the public room report never opens.
What is the root cause of that problem?
The LHN tap handler showReportPage early-returns (no navigation) when the tapped report is considered the "topmost" report. In this flow that guard fires incorrectly:
The guard at SidebarLinks.tsx:75-82 returns early when option.reportID === Navigation.getTopmostReportId().
getTopmostReportParams resolves the "topmost" report with findLast across the entire navigation tree and does not verify the ReportsSplitNavigator is the active/focused tab. The public room's REPORT screen is still sitting in that split-navigator stack from the original deep link, so getTopmostReportId() keeps returning the public room ID even while the user is on the Account page.
Reinforcing this on native (narrow layout), updateCurrentReportID intentionally does not clear currentReportID on Settings_* screens, so isActiveReport(option.reportID) (guard Fix spaces #2) also stays pinned to the public room.
Tapping the same public room therefore matches the guard and returns before Navigation.navigate is ever called → nothing happens.
Data flow & evidence
Deep link /r/1540486774487195 → after sign-in + onboarding, the public room REPORT screen is pushed into the REPORTS_SPLIT_NAVIGATOR (inside the TAB_NAVIGATOR).
User taps Concierge “here”, then Back repeatedly to Account/Settings. The public room REPORT screen is not popped from the split-navigator stack.
On Settings, updateCurrentReportID early-returns for Settings_*, so currentReportID stays = public room ID.
User taps Inbox → taps the public room row → showReportPage runs.
Navigation.getTopmostReportId() returns the still-buried public room ID; reportActionID/actionTargetReportActionID are falsy → guard at SidebarLinks.tsx:75-82 matches → early return → no navigation.
There is also a secondary no-op layer in linkTo/index.ts:172-175 (areNamesAndParamsEqual) that would still block if the report screen were actually focused underneath an overlay.
Confidence: Medium-High. The guard/no-op mechanism is confirmed in code. The one inferred link is that the public room REPORT screen remains in the split-navigator stack after the “here” tap + repeated Back — worth confirming with a native repro plus a temporary log of option.reportID vs Navigation.getTopmostReportId() inside showReportPage.
What changes do you think we should make in order to solve the problem?
Make the "topmost report" determination reflect what is actually on screen, so a report lingering in an inactive tab's stack doesn't suppress navigation:
Gate getTopmostReportParams on the ReportsSplitNavigator being the active/focused full-screen tab (rather than blindly findLast across all tabs). Compare with getCentralPaneReportID.ts, which already notes this "scans all tabs" limitation.
Alternatively/additionally, change the showReportPage guard at SidebarLinks.tsx:75-82 to use an "is this report currently on screen" check instead of the raw topmost ID.
A native repro with the temporary log above should confirm which of the two guards fires first and pin down the tightest fix.
What alternative solutions did you explore? (Optional)
Clearing the stale currentReportID/popping the deep-linked report screen when backing out to Settings — but that treats the symptom for guard #2 only and doesn't fix the primary getTopmostReportId mismatch, so gating on the active tab is preferred.
Related issues
This is part of a cluster of public-room deep-link navigation bugs; the fix here may overlap with them:
⚠️ Note: the comment above from nonunosu29 links to an external .apk/"patch" file hosted on an unrelated third-party repo. That is not an Expensify build — do not download or install it.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/94783) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-][Exploratory] Public room - Unable to open Public room after tap the "here" hyperlink on Concierge message[/-][+][$250] [Exploratory] Public room - Unable to open Public room after tap the "here" hyperlink on Concierge message[/+]on Jul 17, 2026
Activity
applause-bot commentedon Jun 28, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e02fefcbfad65f8ac74f68f0e36b0e05f9221b5d1b8656b204cd1f0786565717
[-][Exploratory] Public room-Unable to open Public room after tap the "here" hyperlink on Concierge message[/-][+][Exploratory] Public room - Unable to open Public room after tap the "here" hyperlink on Concierge message[/+]melvin-bot commentedon Jun 28, 2026
📣 @nonunosu29! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
MelvinBot commentedon Jul 17, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
After a signed-out user opens a public room via deep link, signs in, completes onboarding, taps the “here” link on the Concierge message, backs out to the Account page, and then taps the public room in the LHN, nothing happens — the public room report never opens.
What is the root cause of that problem?
The LHN tap handler
showReportPageearly-returns (no navigation) when the tapped report is considered the "topmost" report. In this flow that guard fires incorrectly:SidebarLinks.tsx:75-82returns early whenoption.reportID === Navigation.getTopmostReportId().getTopmostReportParamsresolves the "topmost" report withfindLastacross the entire navigation tree and does not verify theReportsSplitNavigatoris the active/focused tab. The public room'sREPORTscreen is still sitting in that split-navigator stack from the original deep link, sogetTopmostReportId()keeps returning the public room ID even while the user is on the Account page.updateCurrentReportIDintentionally does not clearcurrentReportIDonSettings_*screens, soisActiveReport(option.reportID)(guard Fix spaces #2) also stays pinned to the public room.Tapping the same public room therefore matches the guard and returns before
Navigation.navigateis ever called → nothing happens.Data flow & evidence
/r/1540486774487195→ after sign-in + onboarding, the public roomREPORTscreen is pushed into theREPORTS_SPLIT_NAVIGATOR(inside theTAB_NAVIGATOR).REPORTscreen is not popped from the split-navigator stack.updateCurrentReportIDearly-returns forSettings_*, socurrentReportIDstays = public room ID.showReportPageruns.Navigation.getTopmostReportId()returns the still-buried public room ID;reportActionID/actionTargetReportActionIDare falsy → guard atSidebarLinks.tsx:75-82matches → early return → no navigation.There is also a secondary no-op layer in
linkTo/index.ts:172-175(areNamesAndParamsEqual) that would still block if the report screen were actually focused underneath an overlay.Confidence: Medium-High. The guard/no-op mechanism is confirmed in code. The one inferred link is that the public room
REPORTscreen remains in the split-navigator stack after the “here” tap + repeated Back — worth confirming with a native repro plus a temporary log ofoption.reportIDvsNavigation.getTopmostReportId()insideshowReportPage.What changes do you think we should make in order to solve the problem?
Make the "topmost report" determination reflect what is actually on screen, so a report lingering in an inactive tab's stack doesn't suppress navigation:
getTopmostReportParamson theReportsSplitNavigatorbeing the active/focused full-screen tab (rather than blindlyfindLastacross all tabs). Compare withgetCentralPaneReportID.ts, which already notes this "scans all tabs" limitation.showReportPageguard atSidebarLinks.tsx:75-82to use an "is this report currently on screen" check instead of the raw topmost ID.A native repro with the temporary log above should confirm which of the two guards fires first and pin down the tightest fix.
What alternative solutions did you explore? (Optional)
Clearing the stale
currentReportID/popping the deep-linked report screen when backing out to Settings — but that treats the symptom for guard #2 only and doesn't fix the primarygetTopmostReportIdmismatch, so gating on the active tab is preferred.Related issues
This is part of a cluster of public-room deep-link navigation bugs; the fix here may overlap with them:
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/94783)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
melvin-bot commentedon Jul 17, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)[-][Exploratory] Public room - Unable to open Public room after tap the "here" hyperlink on Concierge message[/-][+][$250] [Exploratory] Public room - Unable to open Public room after tap the "here" hyperlink on Concierge message[/+]18 remaining items
melvin-bot commentedon Jul 26, 2026
@shubham1206agra this issue is now 4 weeks old, please consider:
Thanks!
WojtekBoman commentedon Jul 27, 2026
According to this comment, in the flow shown on the video I should encounter the bug, right?
Screen.Recording.2026-07-27.at.13.36.24.mov
shubham1206agra commentedon Jul 27, 2026
@WojtekBoman Yes
@lorretheboy Please share the video of the bug on latest main please
lorretheboy commentedon Jul 27, 2026
@shubham1206agra Hmm... I can't reproduce the issue on latest main. Maybe it is fixed
Screen.Recording.2026-07-27.at.22.17.58.mov
melvin-bot commentedon Jul 30, 2026
@shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jul 31, 2026
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
shubham1206agra commentedon Aug 3, 2026
Asking for retest label
m-natarajan commentedon Aug 3, 2026
Not repro, iPhone 12 Pro Max, v9.4.48-2 (Pending validation in Android)
ScreenRecording_08-04-2026.01-15-58_1.MP4
iwiznia commentedon Aug 5, 2026
Closing per https://expensify.slack.com/archives/C02NK2DQWUX/p1785933771635559?thread_ts=1785165936.248279&cid=C02NK2DQWUX