Skip to content

[$250] [Exploratory] Public room - Unable to open Public room after tap the "here" hyperlink on Concierge message #94783

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.4.21-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/62259272/folder/13176964/41237765/1521896272?sort=-identifier
Email or phone of affected tester (no customers): lekima20+629306@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 16 pro/ 26.5
App Component: Other

Action Performed:

  1. Log out and force close the app
  2. Tap on link https://staging.new.expensify.com/r/1540486774487195 from Note of device
  3. Tap on Sign in button
  4. Type new gmail and complete onboarding flow
  5. Tap the "here" hyperlink on Concierge message
  6. Tap back button until to Account page
  7. Tap Inbox tab
  8. Tap on the public room

Expected Result:

Public room should open

Actual Result:

Nothing happens when tapping on the public room

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7192893_1782571066668.Ioyf0971_1_.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7192893

Upwork Automation - Do Not Edit

Activity

  1. applause-bot commented on Jun 28, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/e02fefcbfad65f8ac74f68f0e36b0e05f9221b5d1b8656b204cd1f0786565717

  2. changed the title [-][Exploratory] Public room-Unable to open Public room after tap the "here" hyperlink on Concierge message[/-] [+][Exploratory] Public room - Unable to open Public room after tap the "here" hyperlink on Concierge message[/+] on Jun 28, 2026
  3. melvin-bot commented on Jun 28, 2026

    @melvin-bot

    📣 @nonunosu29! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  4. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 17, 2026
  5. MelvinBot commented on Jul 17, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    After a signed-out user opens a public room via deep link, signs in, completes onboarding, taps the “here” link on the Concierge message, backs out to the Account page, and then taps the public room in the LHN, nothing happens — the public room report never opens.

    What is the root cause of that problem?

    The LHN tap handler showReportPage early-returns (no navigation) when the tapped report is considered the "topmost" report. In this flow that guard fires incorrectly:

    • The guard at SidebarLinks.tsx:75-82 returns early when option.reportID === Navigation.getTopmostReportId().
    • getTopmostReportParams resolves the "topmost" report with findLast across the entire navigation tree and does not verify the ReportsSplitNavigator is the active/focused tab. The public room's REPORT screen is still sitting in that split-navigator stack from the original deep link, so getTopmostReportId() keeps returning the public room ID even while the user is on the Account page.
    • Reinforcing this on native (narrow layout), updateCurrentReportID intentionally does not clear currentReportID on Settings_* screens, so isActiveReport(option.reportID) (guard Fix spaces #2) also stays pinned to the public room.

    Tapping the same public room therefore matches the guard and returns before Navigation.navigate is ever called → nothing happens.

    Data flow & evidence
    1. Deep link /r/1540486774487195 → after sign-in + onboarding, the public room REPORT screen is pushed into the REPORTS_SPLIT_NAVIGATOR (inside the TAB_NAVIGATOR).
    2. User taps Concierge “here”, then Back repeatedly to Account/Settings. The public room REPORT screen is not popped from the split-navigator stack.
    3. On Settings, updateCurrentReportID early-returns for Settings_*, so currentReportID stays = public room ID.
    4. User taps Inbox → taps the public room row → showReportPage runs.
    5. Navigation.getTopmostReportId() returns the still-buried public room ID; reportActionID/actionTargetReportActionID are falsy → guard at SidebarLinks.tsx:75-82 matches → early return → no navigation.

    There is also a secondary no-op layer in linkTo/index.ts:172-175 (areNamesAndParamsEqual) that would still block if the report screen were actually focused underneath an overlay.

    Confidence: Medium-High. The guard/no-op mechanism is confirmed in code. The one inferred link is that the public room REPORT screen remains in the split-navigator stack after the “here” tap + repeated Back — worth confirming with a native repro plus a temporary log of option.reportID vs Navigation.getTopmostReportId() inside showReportPage.

    What changes do you think we should make in order to solve the problem?

    Make the "topmost report" determination reflect what is actually on screen, so a report lingering in an inactive tab's stack doesn't suppress navigation:

    • Gate getTopmostReportParams on the ReportsSplitNavigator being the active/focused full-screen tab (rather than blindly findLast across all tabs). Compare with getCentralPaneReportID.ts, which already notes this "scans all tabs" limitation.
    • Alternatively/additionally, change the showReportPage guard at SidebarLinks.tsx:75-82 to use an "is this report currently on screen" check instead of the raw topmost ID.

    A native repro with the temporary log above should confirm which of the two guards fires first and pin down the tightest fix.

    What alternative solutions did you explore? (Optional)

    Clearing the stale currentReportID/popping the deep-linked report screen when backing out to Settings — but that treats the symptom for guard #2 only and doesn't fix the primary getTopmostReportId mismatch, so gating on the active tab is preferred.

    Related issues

    This is part of a cluster of public-room deep-link navigation bugs; the fix here may overlap with them:

    ⚠️ Note: the comment above from nonunosu29 links to an external .apk/"patch" file hosted on an unrelated third-party repo. That is not an Expensify build — do not download or install it.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94783) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 17, 2026
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 17, 2026
  8. melvin-bot commented on Jul 17, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  9. changed the title [-][Exploratory] Public room - Unable to open Public room after tap the "here" hyperlink on Concierge message[/-] [+][$250] [Exploratory] Public room - Unable to open Public room after tap the "here" hyperlink on Concierge message[/+] on Jul 17, 2026
  10. 18 remaining items

  11. melvin-bot commented on Jul 26, 2026

    @melvin-bot

    @shubham1206agra this issue is now 4 weeks old, please consider:

    • Finding a contributor to fix the bug
    • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
    • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

    Thanks!

  12. WojtekBoman commented on Jul 27, 2026

    @WojtekBoman
    Contributor

    Lemme get a navigation expert on this.

    @lorretheboy Can you repro this bug with these steps?

    1. Go to a room.
    2. Add https://staging.new.expensify.com/settings/profile/display-name as a comment
    3. Click on the link.
    4. Tap back button until to Account page
    5. Tap Inbox tab
    6. Tap on the same room as step 1.

    According to this comment, in the flow shown on the video I should encounter the bug, right?

    Screen.Recording.2026-07-27.at.13.36.24.mov
  13. shubham1206agra commented on Jul 27, 2026

    @shubham1206agra
    Contributor

    @WojtekBoman Yes

    @lorretheboy Please share the video of the bug on latest main please

  14. lorretheboy commented on Jul 27, 2026

    @lorretheboy
    Contributor

    @shubham1206agra Hmm... I can't reproduce the issue on latest main. Maybe it is fixed

    Screen.Recording.2026-07-27.at.22.17.58.mov
  15. melvin-bot commented on Jul 30, 2026

    @melvin-bot

    @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. melvin-bot commented on Jul 31, 2026

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  17. shubham1206agra commented on Aug 3, 2026

    @shubham1206agra
    Contributor

    Asking for retest label

  18. m-natarajan commented on Aug 3, 2026

    @m-natarajan

    Not repro, iPhone 12 Pro Max, v9.4.48-2 (Pending validation in Android)

    ScreenRecording_08-04-2026.01-15-58_1.MP4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsNot a priority

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions