You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-27] [$250] [Exploratory] iOS - Company cards - Cannot escape adding cards flow after upgrading workspace #94792
Version Number: 9.4.21-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176706/test-cases/41236839 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: iPhone 15 iOS 26.5 App Component: Workspace Settings
Action Performed:
Add a Plaid card feed in Workspace settings/ Company cards
Tap the bank name, then tap "+ Add cards"
Tap Upgrade on the "Unlimited Company cards" modal
Tap back button on the "You've upgraded your workspace" page
Tap back button on the "Where's your bank located"
Tap back button on the Upgrade page
Expected Result:
User is navigated back to the Select cards page after tapping back button on the Upgrade page
Actual Result:
After tapping back button on the "You've upgraded your workspace" page, user is navigated to the "Where's your bank located" page and vice versa. The same result if tap "Got it' thanks"
changed the title [-][Exploratory] Company cards-Cannot escape adding cards flow after upgrading workspace[/-][+][Exploratory] iOS - Company cards - Cannot escape adding cards flow after upgrading workspace[/+]on Jun 28, 2026
Please re-state the problem that we are trying to solve in this issue.
When a user upgrades their workspace mid-way through the company-card "Add cards" flow (feed limit reached), the back button gets stuck: tapping back on the "You've upgraded your workspace" confirmation lands on "Where's your bank located", and tapping back there returns to the confirmation — an infinite bounce with no way to escape the flow.
What is the root cause of that problem?
Two navigation actions contradict each other:
The add-card page enters the upgrade page with forceReplace: true — this replaces the add-card-feed route on the stack rather than pushing on top of it, so there is no longer an add-card entry beneath the upgrade page to pop back to. The backTo param passed here is WORKSPACE_COMPANY_CARDS (the Select cards page). See DynamicAddNewCardPage.tsx:63-70.
The upgrade page's goBack handler for the companyCards feature does not call goBack() and ignores backTo — it calls Navigation.navigate(...) to push a fresh add-card-feed route. See WorkspaceUpgradePage.tsx:171-173.
The freshly-pushed add-card-feed route has no current step, so it defaults to SelectCountryStep — the "Where's your bank located" screen. Its own back button calls Navigation.goBack(), which pops back to the still-present upgrade route (confirmation). Because that handler re-pushes add-card-feed again, the two screens ping-pong forever.
Tap back there → goBack() pops to upgrade (confirmation still shown).
Tap back → step 4 repeats. Infinite bounce.
What changes do you think we should make in order to solve the problem?
Make the companyCards branch of the goBack handler honor backTo and perform a real back navigation instead of pushing a new wizard route, matching the pattern already used by the other feature cases in this same switch.
Since entry used forceReplace, the upgrade route replaced add-card-feed, so Navigation.goBack(backTo) correctly returns to the WORKSPACE_COMPANY_CARDS (Select cards) page passed as backTo, rather than pushing a new blocked wizard route.
What alternative solutions did you explore?
Alternatively, drop forceReplace: true at DynamicAddNewCardPage.tsx:63-70 so the add-card-feed route stays beneath the upgrade page, and change the companyCards goBack branch to a plain Navigation.goBack(). This is riskier — forceReplace was likely intentional to avoid leaving a blocked wizard route in history — so the primary fix above is preferred.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/94792) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-][$250] [Exploratory] iOS - Company cards - Cannot escape adding cards flow after upgrading workspace[/-][+][Due for payment 2026-08-27] [$250] [Exploratory] iOS - Company cards - Cannot escape adding cards flow after upgrading workspace[/+]on Aug 27, 2026
@thelullabyy I've assumed, forever, that it was understood that Contributors would fix all regressions from the PRs they authored and reviewed. Have you not @thelullabyy ?
Hi @mallenexpensify, I fixed the regression that introduce by my PR which tried to fix this issue. And no payment needing for that regression but this issue payment still needs to be fulfilled since it is a fresh issue
@mountiny can you help here? I think it's just confirming this issue isn't directly related to the regression caused by @thelullabyy and is due full payment. Thx.
this issue payment still needs to be fulfilled since it is a fresh issue
Activity
applause-bot commentedon Jun 28, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/bb33daef8d02def98b5d31901a15274ae5d33ed523b33015c0f264ad25c8d635
[-][Exploratory] Company cards-Cannot escape adding cards flow after upgrading workspace[/-][+][Exploratory] iOS - Company cards - Cannot escape adding cards flow after upgrading workspace[/+]MelvinBot commentedon Jul 17, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user upgrades their workspace mid-way through the company-card "Add cards" flow (feed limit reached), the back button gets stuck: tapping back on the "You've upgraded your workspace" confirmation lands on "Where's your bank located", and tapping back there returns to the confirmation — an infinite bounce with no way to escape the flow.
What is the root cause of that problem?
Two navigation actions contradict each other:
The add-card page enters the upgrade page with
forceReplace: true— this replaces theadd-card-feedroute on the stack rather than pushing on top of it, so there is no longer an add-card entry beneath the upgrade page to pop back to. ThebackToparam passed here isWORKSPACE_COMPANY_CARDS(the Select cards page). SeeDynamicAddNewCardPage.tsx:63-70.The upgrade page's
goBackhandler for thecompanyCardsfeature does not callgoBack()and ignoresbackTo— it callsNavigation.navigate(...)to push a freshadd-card-feedroute. SeeWorkspaceUpgradePage.tsx:171-173.The freshly-pushed
add-card-feedroute has no current step, so it defaults toSelectCountryStep— the "Where's your bank located" screen. Its own back button callsNavigation.goBack(), which pops back to the still-presentupgraderoute (confirmation). Because that handler re-pushesadd-card-feedagain, the two screens ping-pong forever.Stack trace of the bounce
add-card-feed. Stack:[…, CompanyCards, add-card-feed]forceReplacetoupgrade. Stack:[…, CompanyCards, upgrade]upgraderoute).goBackcase pushes a newadd-card-feed. Stack:[…, CompanyCards, upgrade, add-card-feed]add-card-feedhascurrentStep === undefined→ rendersSelectCountryStep("Where's your bank located") —DynamicAddNewCardPage.tsx:145-147,SelectCountryStep.tsx:73-75.goBack()pops toupgrade(confirmation still shown).What changes do you think we should make in order to solve the problem?
Make the
companyCardsbranch of thegoBackhandler honorbackToand perform a real back navigation instead of pushing a new wizard route, matching the pattern already used by the other feature cases in this sameswitch.In
WorkspaceUpgradePage.tsx:171-173:Since entry used
forceReplace, the upgrade route replacedadd-card-feed, soNavigation.goBack(backTo)correctly returns to theWORKSPACE_COMPANY_CARDS(Select cards) page passed asbackTo, rather than pushing a new blocked wizard route.What alternative solutions did you explore?
Alternatively, drop
forceReplace: trueatDynamicAddNewCardPage.tsx:63-70so theadd-card-feedroute stays beneath the upgrade page, and change the companyCardsgoBackbranch to a plainNavigation.goBack(). This is riskier —forceReplacewas likely intentional to avoid leaving a blocked wizard route in history — so the primary fix above is preferred.Related issues
goBackhandler; worth cross-checking as the fixes may overlap.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/94792)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
melvin-bot commentedon Jul 17, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thelullabyy (
External)59 remaining items
[-][$250] [Exploratory] iOS - Company cards - Cannot escape adding cards flow after upgrading workspace[/-][+][Due for payment 2026-08-27] [$250] [Exploratory] iOS - Company cards - Cannot escape adding cards flow after upgrading workspace[/+]melvin-bot commentedon Aug 27, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)mallenexpensify commentedon Aug 27, 2026
@thelullabyy I've assumed, forever, that it was understood that Contributors would fix all regressions from the PRs they authored and reviewed. Have you not @thelullabyy ?
Partially asking cuz I brought it up internally and am considering updating CONTRIBUTING.md .
DylanDylann commentedon Aug 28, 2026
@mallenexpensify Wrong person again
mallenexpensify commentedon Aug 28, 2026
Apologies @DylanDylann , I think it's cuz you both have dark blue avatars.
@thelullabyy 👀 above plz
thelullabyy commentedon Aug 29, 2026
Hi @mallenexpensify, I fixed the regression that introduce by my PR which tried to fix this issue. And no payment needing for that regression but this issue payment still needs to be fulfilled since it is a fresh issue
mallenexpensify commentedon Aug 31, 2026
@mountiny can you help here? I think it's just confirming this issue isn't directly related to the regression caused by @thelullabyy and is due full payment. Thx.
mountiny commentedon Sep 1, 2026
I think full payment is ok here
mallenexpensify commentedon Sep 1, 2026
Payment Summary
Contributor+: @thelullabyy due $250 via NewDot
laurenreidexpensify commentedon Sep 7, 2026
$250 approved @thelullabyy New Expensify