Skip to content

[Due for payment 2026-08-27] [$250] [Exploratory] iOS - Company cards - Cannot escape adding cards flow after upgrading workspace #94792

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.21-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176706/test-cases/41236839
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 iOS 26.5
App Component: Workspace Settings

Action Performed:

  1. Add a Plaid card feed in Workspace settings/ Company cards
  2. Tap the bank name, then tap "+ Add cards"
  3. Tap Upgrade on the "Unlimited Company cards" modal
  4. Tap back button on the "You've upgraded your workspace" page
  5. Tap back button on the "Where's your bank located"
  6. Tap back button on the Upgrade page

Expected Result:

User is navigated back to the Select cards page after tapping back button on the Upgrade page

Actual Result:

After tapping back button on the "You've upgraded your workspace" page, user is navigated to the "Where's your bank located" page and vice versa. The same result if tap "Got it' thanks"

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7193155_1782600402483.no_back_navigation.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7193155

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. applause-bot commented on Jun 28, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/bb33daef8d02def98b5d31901a15274ae5d33ed523b33015c0f264ad25c8d635

  2. changed the title [-][Exploratory] Company cards-Cannot escape adding cards flow after upgrading workspace[/-] [+][Exploratory] iOS - Company cards - Cannot escape adding cards flow after upgrading workspace[/+] on Jun 28, 2026
  3. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 17, 2026
  4. MelvinBot commented on Jul 17, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When a user upgrades their workspace mid-way through the company-card "Add cards" flow (feed limit reached), the back button gets stuck: tapping back on the "You've upgraded your workspace" confirmation lands on "Where's your bank located", and tapping back there returns to the confirmation — an infinite bounce with no way to escape the flow.

    What is the root cause of that problem?

    Two navigation actions contradict each other:

    1. The add-card page enters the upgrade page with forceReplace: true — this replaces the add-card-feed route on the stack rather than pushing on top of it, so there is no longer an add-card entry beneath the upgrade page to pop back to. The backTo param passed here is WORKSPACE_COMPANY_CARDS (the Select cards page). See DynamicAddNewCardPage.tsx:63-70.

    2. The upgrade page's goBack handler for the companyCards feature does not call goBack() and ignores backTo — it calls Navigation.navigate(...) to push a fresh add-card-feed route. See WorkspaceUpgradePage.tsx:171-173.

    The freshly-pushed add-card-feed route has no current step, so it defaults to SelectCountryStep — the "Where's your bank located" screen. Its own back button calls Navigation.goBack(), which pops back to the still-present upgrade route (confirmation). Because that handler re-pushes add-card-feed again, the two screens ping-pong forever.

    Stack trace of the bounce
    1. "+ Add cards" pushes add-card-feed. Stack: […, CompanyCards, add-card-feed]
    2. Feed blocked → forceReplace to upgrade. Stack: […, CompanyCards, upgrade]
    3. Tap Upgrade → confirmation renders in place (same upgrade route).
    4. Tap back on confirmation → companyCards goBack case pushes a new add-card-feed. Stack: […, CompanyCards, upgrade, add-card-feed]
    5. New add-card-feed has currentStep === undefined → renders SelectCountryStep ("Where's your bank located") — DynamicAddNewCardPage.tsx:145-147, SelectCountryStep.tsx:73-75.
    6. Tap back there → goBack() pops to upgrade (confirmation still shown).
    7. Tap back → step 4 repeats. Infinite bounce.

    What changes do you think we should make in order to solve the problem?

    Make the companyCards branch of the goBack handler honor backTo and perform a real back navigation instead of pushing a new wizard route, matching the pattern already used by the other feature cases in this same switch.

    In WorkspaceUpgradePage.tsx:171-173:

    case CONST.UPGRADE_FEATURE_INTRO_MAPPING.companyCards.id:
        return route.params.backTo ? Navigation.goBack(route.params.backTo) : Navigation.goBack();

    Since entry used forceReplace, the upgrade route replaced add-card-feed, so Navigation.goBack(backTo) correctly returns to the WORKSPACE_COMPANY_CARDS (Select cards) page passed as backTo, rather than pushing a new blocked wizard route.

    What alternative solutions did you explore?

    Alternatively, drop forceReplace: true at DynamicAddNewCardPage.tsx:63-70 so the add-card-feed route stays beneath the upgrade page, and change the companyCards goBack branch to a plain Navigation.goBack(). This is riskier — forceReplace was likely intentional to avoid leaving a blocked wizard route in history — so the primary fix above is preferred.

    Related issues


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94792) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 17, 2026
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 17, 2026
  7. melvin-bot commented on Jul 17, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thelullabyy (External)

  8. 59 remaining items

  9. changed the title [-][$250] [Exploratory] iOS - Company cards - Cannot escape adding cards flow after upgrading workspace[/-] [+][Due for payment 2026-08-27] [$250] [Exploratory] iOS - Company cards - Cannot escape adding cards flow after upgrading workspace[/+] on Aug 27, 2026
  10. melvin-bot commented on Aug 27, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  11. mallenexpensify commented on Aug 27, 2026

    @mallenexpensify
    Contributor

    @thelullabyy I've assumed, forever, that it was understood that Contributors would fix all regressions from the PRs they authored and reviewed. Have you not @thelullabyy ?

    Partially asking cuz I brought it up internally and am considering updating CONTRIBUTING.md .

  12. DylanDylann commented on Aug 28, 2026

    @DylanDylann
    Contributor

    @mallenexpensify Wrong person again

  13. mallenexpensify commented on Aug 28, 2026

    @mallenexpensify
    Contributor

    Apologies @DylanDylann , I think it's cuz you both have dark blue avatars.

    @thelullabyy 👀 above plz

  14. thelullabyy commented on Aug 29, 2026

    @thelullabyy
    Contributor

    Hi @mallenexpensify, I fixed the regression that introduce by my PR which tried to fix this issue. And no payment needing for that regression but this issue payment still needs to be fulfilled since it is a fresh issue

  15. mallenexpensify commented on Aug 31, 2026

    @mallenexpensify
    Contributor

    @mountiny can you help here? I think it's just confirming this issue isn't directly related to the regression caused by @thelullabyy and is due full payment. Thx.

    this issue payment still needs to be fulfilled since it is a fresh issue

  16. mountiny commented on Sep 1, 2026

    @mountiny
    Contributor

    I think full payment is ok here

  17. mallenexpensify commented on Sep 1, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @thelullabyy due $250 via NewDot

  18. laurenreidexpensify commented on Sep 7, 2026

    @laurenreidexpensify
    Contributor

    $250 approved @thelullabyy New Expensify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions