Skip to content

[Due for payment 2026-08-31] [Metrics] Add Sentry spans for iOS Share Extension → expense submit flow #94802

Closed

Description

@melvin-bot

Background

The iOS Share Extension flow (take photo → Share → Expensify → tap workspace chat → expense submit) currently has no Sentry telemetry coverage. The delay between tapping a workspace chat and the expense submit screen appearing (observed to be ~3–4 seconds, long enough to feel broken) is a complete blind spot.

What's missing

The existing SPAN_OPEN_CREATE_EXPENSE / ManualOpenCreateExpense span is started only in startMoneyRequest() (src/libs/actions/IOU/MoneyRequest.ts), which is the in-app FAB / global-create path.

The Share Extension takes a completely separate navigation path:
ShareRootPage → SubmitTab → ShareTabParticipantsSelector → SHARE_SUBMIT_DETAILS

On tapping a workspace chat, ShareTabParticipantsSelector only calls clearMoneyRequest(...) and Navigation.navigate(...) — no startSpan. There are no startSpan calls anywhere under src/pages/Share and no Share-specific span constants in CONST.TELEMETRY.

What to instrument

Add a new Sentry span (or a tagged variant of an existing one) that covers:

  • Start: user taps a workspace chat / participant in ShareTabParticipantsSelector.onParticipantsAdded
  • End: the first step of the expense submit flow mounts and is visible (SHARE_SUBMIT_DETAILS screen renders)

This would capture the navigation + draft-init + first-render latency that is currently invisible.

Suggested span name

Something like ShareExtensionOpenSubmitFlow (consistent with the existing ManualOpenCreateExpense naming convention), added to CONST.TELEMETRY and documented in contributingGuides/OBSERVABILITY_METRICS.md.

References

Issue OwnerCurrent Issue Owner: @linhvovan29546

Activity

  1. added and removed
    InternalRequires API changes or must be handled by Expensify staff
    on Jun 29, 2026
  2. self-assigned this
    on Jun 29, 2026
  3. jmgraa commented on Jun 29, 2026

    @jmgraa
    Contributor

    Hi. I'm Jakub Magiera from Software Mansion. @staszekscp told me that I can take care of that issue.
    @mountiny Could you assign me to this issue?

  4. added
    ReviewingHas a PR in review
    and removed on Jul 1, 2026
  5. jmgraa commented on Jul 1, 2026

    @jmgraa
    Contributor

    @mountiny I have opened a pull request #94948. I was thinking, do you also want to have a dashboard on Sentry?

  6. mountiny commented on Jul 1, 2026

    @mountiny
    Contributor

    Yes, that would be helpful thank you

  7. jmgraa commented on Jul 2, 2026

    @jmgraa
    Contributor

    What are the target duration thresholds in seconds (Good / Needs Improvement / Poor) we want to configure for the new span in Sentry?

  8. mountiny commented on Jul 2, 2026

    @mountiny
    Contributor

    Lets do 1s for now

  9. 21 remaining items

  10. linhvovan29546 commented on Jul 14, 2026

    @linhvovan29546
    Contributor

    No checklist is needed for this issue.

  11. mallenexpensify commented on Jul 15, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @linhvovan29546 due $250 via NewDot

  12. twisterdotcom commented on Jul 30, 2026

    @twisterdotcom
    Contributor

    $250 approved for @linhvovan29546 in Report ID: R000Z5qIjw5y.

    Zapier Logs Run ID: 00040eee-b386-acc9-bd8a-32c400204484

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

  13. changed the title [-][Due for payment 2026-07-13] [Metrics] Add Sentry spans for iOS Share Extension → expense submit flow[/-] [+][Due for payment 2026-08-31] [Metrics] Add Sentry spans for iOS Share Extension → expense submit flow[/+] on Aug 24, 2026
  14. melvin-bot commented on Aug 24, 2026

    @melvin-bot
    Author

    @linhvovan29546 @mallenexpensify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-31. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions