You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-12] Rules - "None" remains on category list and is selectable after selecting a category. #95358
Version Number: 9.4.27-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#94696 Email or phone of affected tester (no customers):applausetester+ib0024@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Workspace Settings
Action Performed:
Prerequisite: Use an expensifail account.
Prerequisite 2: User is owner of a "Control" workspace with "Rules" enabled.
Open the staging.new.expensify.com website.
Navigate to "Workspaces" > Workspace > "Rules"
Click on "Require Fields" > "Create Require rule" > "Category"
Note that "None" is already selected.
Select a different category and reopen "Category" field.
Note that below the selected category, "None" is still visible and selectable.
Expected Result:
"None" shouldn´t be displayed on category list while creating a rule after selecting another category.
Actual Result:
After selecting a category while creating a "Require" rule, "None" is still displayed on category list and is selectable as a different category.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The category picker for creating a Require fields rule renders a permanent, always-selectable "None" option. It is shown before you pick anything (that's why "None" appears pre-selected in step 4) and it stays in the list after you select a real category (step 6).
This happens because RuleSelectionBase.tsx:72 hard-codes allowNoneOption on the underlying picker. In SearchSingleSelectionPicker.tsx:56-65, when allowNoneOption is true the "None" item is added to the first section unconditionally — it never depends on whether a real item is already selected, so it can never disappear.
For a Require fields rule the category is a required condition (the rule applies to "Category is X"), so "None" is never a valid choice here. The same shared component backs the Flag for review and Merchant type category pickers, which have the identical problem.
What changes do you think we should make in order to solve the problem?
Make allowNoneOption a prop on RuleSelectionBase instead of hard-coding it, then set allowNoneOption={false} for the category condition pickers where a category is required:
Keep the default true inside RuleSelectionBase so the existing expense-default pickers (Fields/AddCategoryPage, AddTagPage, AddTaxRatePage, MerchantRules/AddCategoryPage, etc.), where clearing to "None" is legitimate, are unaffected.
What alternative solutions did you explore? (Optional)
Hide the "None" item in SearchSingleSelectionPicker once a real item is selected. Rejected — it would still leave "None" pre-selected/selectable before a choice is made, and it changes shared picker behavior globally rather than scoping the fix to the pickers that actually require a category.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/95358) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Rules - "None" remains on category list and is selectable after selecting a category.[/-][+][Due for payment 2026-08-12] Rules - "None" remains on category list and is selectable after selecting a category.[/+]on Aug 5, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.50-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-12. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jul 6, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/61c2edb2da38befaf93b2b38a88f1576cc63f4b9740c3b558233a6184ce49c51
melvin-bot commentedon Jul 6, 2026
@luacmartins recently merged #94696, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Jul 6, 2026
Triggered auto assignment to @madmax330 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 6, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 6, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 6, 2026
Proposal
What is the root cause of that problem?
The category picker for creating a Require fields rule renders a permanent, always-selectable "None" option. It is shown before you pick anything (that's why "None" appears pre-selected in step 4) and it stays in the list after you select a real category (step 6).
This happens because
RuleSelectionBase.tsx:72hard-codesallowNoneOptionon the underlying picker. InSearchSingleSelectionPicker.tsx:56-65, whenallowNoneOptionis true the "None" item is added to the first section unconditionally — it never depends on whether a real item is already selected, so it can never disappear.For a Require fields rule the category is a required condition (the rule applies to "Category is X"), so "None" is never a valid choice here. The same shared component backs the Flag for review and Merchant type category pickers, which have the identical problem.
Evidence / call chain
RequireFieldsRuleCategoryPageBase.tsx→ rendersRuleSelectionBase.RuleSelectionBase→SearchSingleSelectionPickerwithallowNoneOptionalways set.noneItemis spread into the first section regardless of selection state, so it always shows and remains selectable.RuleSelectionBase.What changes do you think we should make in order to solve the problem?
Make
allowNoneOptiona prop onRuleSelectionBaseinstead of hard-coding it, then setallowNoneOption={false}for the category condition pickers where a category is required:RequireFieldsRules/RequireFieldsRuleCategoryPageBase.tsxFlagForReviewRules/FlagForReviewRuleCategoryPageBase.tsxMerchantTypeRules/MerchantTypeRuleCategoryPage.tsxKeep the default
trueinsideRuleSelectionBaseso the existing expense-default pickers (Fields/AddCategoryPage,AddTagPage,AddTaxRatePage,MerchantRules/AddCategoryPage, etc.), where clearing to "None" is legitimate, are unaffected.What alternative solutions did you explore? (Optional)
Hide the "None" item in
SearchSingleSelectionPickeronce a real item is selected. Rejected — it would still leave "None" pre-selected/selectable before a choice is made, and it changes shared picker behavior globally rather than scoping the fix to the pickers that actually require a category.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/95358)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
19 remaining items
Krishna2323 commentedon Jul 30, 2026
@Expensify/design @situchan PR is ready for review: #95444
melvin-bot commentedon Aug 4, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mitarachim commentedon Aug 4, 2026
Deploy Blocker #97840 was identified to be related to the PR #95444 that attempted to fix this issue.
melvin-bot commentedon Aug 4, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Rules - "None" remains on category list and is selectable after selecting a category.[/-][+][Due for payment 2026-08-12] Rules - "None" remains on category list and is selectable after selecting a category.[/+]melvin-bot commentedon Aug 5, 2026
@Krishna2323 / @situchan
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.50-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-12. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Krishna2323 commentedon Aug 7, 2026
@JS00001 @luacmartins this can be closed.