Skip to content

[Due for payment 2026-07-21] fix: drop canceled tab navigation spans and add Inbox span context attributes #95489

Closed

Description

@mountiny

Problem

The tab-navigation spans (ManualNavigateToInboxTab, ManualNavigateToReports*) contain events that don't measure a navigation. Abandoned navigations are canceled but still sent with status OK and wall-clock durations, so a span canceled after the laptop wakes up records the whole absence — up to 2-hour "navigations" in production. Under 1% of web events but 61% of recorded time (web avg 1250ms with them, ~420ms without). Wide vs narrow layouts (~3x cost difference) and warm re-focuses (~30ms) vs cold mounts (~150ms) were also indistinguishable in the data.

Solution

Added canceledTabNavigationFilter in beforeSend to drop canceled tab-navigation spans (only matches tab-navigation ops with the canceled attribute set by cancelSpan). Added new Inbox span attributes for honest slicing: wide_layout, skeleton_shown, and is_warm. Removed dead render-duration instrumentation from useSidebarOrderedReports.

PR

#95480

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Jul 14, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  2. changed the title [-]fix: drop canceled tab navigation spans and add Inbox span context attributes[/-] [+][Due for payment 2026-07-21] fix: drop canceled tab navigation spans and add Inbox span context attributes[/+] on Jul 14, 2026
  3. 8 remaining items

  4. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 20, 2026
  5. melvin-bot commented on Jul 20, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  6. melvin-bot commented on Jul 20, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  7. mallenexpensify commented on Jul 22, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @marufsharifi paid $250 via NewDot

    @marufsharifi can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022080072692762091050

  8. marufsharifi commented on Jul 23, 2026

    @marufsharifi
    Contributor

    @mallenexpensify, I've accepted the offer. thanks.

  9. mallenexpensify commented on Jul 23, 2026

    @mallenexpensify
    Contributor

    @marufsharifi paid, summary updated above. Thx.

  10. moved this from AWAITING DEPLOYMENT to Done in [#whatsnext] #qualityon Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions