Skip to content

[Due for payment 2026-07-17] Expense - Skeleton loader appears briefly after creating expense in the empty report #95698

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.32-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #95045
Email or phone of affected tester (no customers): sidbhisdhidhisdhis@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an empty report.
  4. Open the report.
  5. Create an expense inside the report.

Expected Result:

Skeleton loader will not appear after creating expense in the empty report.

Actual Result:

Skeleton loader appears briefly after creating expense in the empty report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7203758_1783599285975.5.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7203758

Activity

  1. applause-bot commented on Jul 9, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/0bd5efe862c6509ec350d7bd500bfc20742571236416f7233c0ce30bf22c7703

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 9, 2026
  3. melvin-bot commented on Jul 9, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #95045

  4. melvin-bot commented on Jul 9, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jul 9, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jul 9, 2026

    @MelvinBot
    Contributor

    Issue Analysis

    TL;DR: PR #95045 (the PR this deploy blocker was auto-assigned to) is very unlikely to be the cause. Its changes are purely FlashList scroll-positioning and it does not touch any of the code that controls the skeleton loader's visibility. The transient skeleton is gated by a data-readiness state that flips while the first expense is created.

    Why it's not #95045: The skeleton (ReportActionsSkeletonView) and the FlashList are mutually-exclusive siblings — ReportActionsSkeletonGuard renders the skeleton instead of the list. Which one shows is decided entirely by computeReportActionsSkeletonState, whose inputs are all data-readiness signals (isLoadingInitialReportActions, isMissingReportActions, isSingleExpenseReport, isOffline, …). None of them read initialScrollIndex or FlashList paint timing. #95045 only edits scroll files (useReportActionsScroll.ts, ReportActionsList.tsx, the flash-list patch, etc.) — none of the three skeleton-gating files. Even the new "delayed first paint" patch behavior happens inside the already-mounted list, so it can only yield a blank list frame, never re-show the skeleton.

    Most likely cause: A data-readiness flip in computeReportActionsSkeletonState at the moment the expense is created:

    Recommended next step: Since this is time-sensitive, I'd suggest not reverting #95045 based on this. Instead, look at which PR in this StagingDeployCash actually touched the report-actions loading / skeleton logic (ReportActionsListContext.tsx, useReportActionsListModel.ts, ReportActionsSkeletonGuard.tsx), and confirm on staging with a debugger whether the skeleton coincides with isSingleExpenseReport && !transactionThreadReport?.reportID. Production logs / a screen recording with those state values would confirm the exact trigger.

    Investigation details

    Confidence: High that #95045 is not the cause (based on its diff + the structural independence of skeleton vs. scroll code). Medium on the exact root cause, since I did not capture runtime state.

    Key references:

    Alternatives considered & ruled out:

    • Open linked message at top - 3 #95045's initialScrollIndex delaying first paint → the delay is internal to the mounted FlashList, which sits in the guard's children; it cannot bring the skeleton back. Would show a blank list, not a skeleton.
    • Report type flipping shouldFocusToTopOnMount on expense creation → shouldReportAlignToTop is type-based (money-request report), not a function of whether expenses exist, so it doesn't flip when the expense is added.
    • List remount when initialScrollIndex changes → the list is keyed by key={listID}, not initialScrollIndex, so no remount occurs.

    Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis (e.g. point me at the other PRs in this deploy and I can narrow down which one changed the skeleton logic).

  7. aimane-chnaif commented on Jul 9, 2026

    @aimane-chnaif
    Contributor

    I am not sure this was caused by #95045. This was not reproducible at the time of PR review.

  8. VickyStash commented on Jul 9, 2026

    @VickyStash
    Contributor

    QA mentions this as causing PR: #95287

  9. m-natarajan commented on Jul 9, 2026

    @m-natarajan

    Repro, Chrome / v9.4.32-1

    REC-20260709204847.mp4

    Not repro on iPhone 11/26.2 Build v9.4.32-1

    RPReplay_Final1783620815.MP4
  10. 7 remaining items

  11. changed the title [-]Expense - Skeleton loader appears briefly after creating expense in the empty report[/-] [+][Due for payment 2026-07-17] Expense - Skeleton loader appears briefly after creating expense in the empty report[/+] on Jul 10, 2026
  12. melvin-bot commented on Jul 10, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jul 10, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.32-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-17. 🎊

  14. melvin-bot commented on Jul 10, 2026

    @melvin-bot

    @mountiny The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  15. melvin-bot commented on Jul 14, 2026

    @melvin-bot

    @mountiny The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  16. lanitochka17 commented on Jul 28, 2026

    @lanitochka17

    Deploy Blocker #97250 was identified to be related to the PR #96785 that attempted to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions