You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-23] "Enjoying New Expensify" modal cannot be dismissed — dismisses then immediately reappears #96204
The "Enjoying New Expensify" modal cannot be dismissed. When a user closes it, it dismisses and then immediately reappears, making it impossible to get past it.
This was surfaced when investigating an issue with Supportal — the root cause is the modal blocking all interaction, not Supportal itself.
Reproducible on
Production
Staging
Impact
Users (including support staff) are unable to access account content due to the modal blocking the UI and reappearing after dismissal.
Notes
Believed to be a regression introduced in a recent pull request.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #94936 loosened the suppression guard for the "Enjoying New Expensify?" (proactiveAppReview) modal so it now only stays hidden for a positive response, delegating suppression of negative/skip responses to a 30-day lastPrompt check that does not reliably evaluate — so the modal re-shows immediately after dismissal. Reverting cleanly restores the previous "hide on any definitive response" behavior; the "reprompt after 30 days" feature can be re-landed with a correct date check.
Assigned: @hungvu193 (PR author), @MariaHCD (approving reviewer) Labels: No label changes. This is a Frontend bug (an App PR caused it), so DeployBlockerCash correctly remains — the App deploy is blocked.
📋 Detailed Analysis
Evidence
The modal text "Enjoying New Expensify?" comes from the proactiveAppReview translation key, rendered by ProactiveAppReviewModal and driven by ProactiveAppReviewModalManager / useProactiveAppReview.
The bug is staging-only, consistent with a PR that is on staging but not yet on production.
The PR's own QA steps (choose "Not Really" → verify the modal is dismissed and does not show again) are exactly the flow that is now broken.
Verification
Affected files confirmed touched by the PR: useProactiveAppReview.ts, ProactiveAppReviewModalManager.tsx, User.ts.
The key behavioral change is in the reprompt guard in useProactiveAppReview.ts.
Root Cause
Before the PR, the modal was suppressed for any definitive response:
// Only allow re-prompting if they skippedif(proactiveAppReview.response&&proactiveAppReview.response!=='skip'){returnfalse;}
After the PR, it is suppressed only for positive:
// Don't show again after user gave a positive responseif(proactiveAppReview.response&&proactiveAppReview.response==='positive'){returnfalse;}
This intentionally removes negative (and skip) from the "always hide" set, so those responses now rely entirely on the 30-day lastPrompt window to stay hidden:
On dismissal, respondToProactiveAppReview optimistically writes lastPrompt: DateUtils.getDBTime(), and getDBTime returns a UTC wall-clock string with the timezone designator stripped (e.g. "2026-07-15 18:30:00.000", the Z is removed). Parsing that space-separated, timezone-less string with new Date(...) is not reliable across JS engines (it is parsed as local time, or as Invalid Date → NaN). When it evaluates to NaN, daysSinceLastPrompt is NaN, and NaN < 1 is false, so the guard does not return false.
Net effect: after a user dismisses the modal, shouldShowModal stays true, the latch-open logic in ProactiveAppReviewModalManager re-opens it, and the modal reappears immediately — blocking all interaction (which is what surfaced during the Supportal investigation).
Suggested fix if rolling forward instead of reverting
Parse lastPrompt as UTC (append Z/T or use the existing DateUtils helpers) so the 30-day window is evaluated correctly, and
Rename/fix the daysSinceLastPrompt computation so the variable name matches the 30-day divisor it actually uses.
changed the title [-]"Enjoying New Expensify" modal cannot be dismissed — dismisses then immediately reappears[/-][+][Due for payment 2026-07-23] "Enjoying New Expensify" modal cannot be dismissed — dismisses then immediately reappears[/+]on Jul 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.34-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
melvin-bot commentedon Jul 15, 2026
Triggered auto assignment to @puneetlath (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 15, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 15, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 15, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #94936 - "Allow negative response to be reprompted after 30 days" by @hungvu193 (High confidence)
Related Issues: Part of https://github.com/Expensify/Expensify/issues/635692
Recommendation: REVERT
PR #94936 loosened the suppression guard for the "Enjoying New Expensify?" (
proactiveAppReview) modal so it now only stays hidden for apositiveresponse, delegating suppression ofnegative/skipresponses to a 30-daylastPromptcheck that does not reliably evaluate — so the modal re-shows immediately after dismissal. Reverting cleanly restores the previous "hide on any definitive response" behavior; the "reprompt after 30 days" feature can be re-landed with a correct date check.Assigned: @hungvu193 (PR author), @MariaHCD (approving reviewer)
Labels: No label changes. This is a Frontend bug (an App PR caused it), so
DeployBlockerCashcorrectly remains — the App deploy is blocked.📋 Detailed Analysis
Evidence
proactiveAppReviewtranslation key, rendered byProactiveAppReviewModaland driven byProactiveAppReviewModalManager/useProactiveAppReview.9.4.34-12staging release, Deploy Checklist: New Expensify 2026-07-14 #96044) modifies exactly these files:src/hooks/useProactiveAppReview.ts,src/components/ProactiveAppReviewModalManager.tsx, andsrc/libs/actions/User.ts.Verification
useProactiveAppReview.ts,ProactiveAppReviewModalManager.tsx,User.ts.useProactiveAppReview.ts.Root Cause
Before the PR, the modal was suppressed for any definitive response:
After the PR, it is suppressed only for
positive:This intentionally removes
negative(andskip) from the "always hide" set, so those responses now rely entirely on the 30-daylastPromptwindow to stay hidden:On dismissal,
respondToProactiveAppReviewoptimistically writeslastPrompt: DateUtils.getDBTime(), andgetDBTimereturns a UTC wall-clock string with the timezone designator stripped (e.g."2026-07-15 18:30:00.000", theZis removed). Parsing that space-separated, timezone-less string withnew Date(...)is not reliable across JS engines (it is parsed as local time, or asInvalid Date→NaN). When it evaluates toNaN,daysSinceLastPromptisNaN, andNaN < 1isfalse, so the guard does not returnfalse.Net effect: after a user dismisses the modal,
shouldShowModalstaystrue, the latch-open logic inProactiveAppReviewModalManagerre-opens it, and the modal reappears immediately — blocking all interaction (which is what surfaced during the Supportal investigation).Suggested fix if rolling forward instead of reverting
lastPromptas UTC (appendZ/Tor use the existing DateUtils helpers) so the 30-day window is evaluated correctly, anddaysSinceLastPromptcomputation so the variable name matches the 30-day divisor it actually uses.6 remaining items
roryabraham commentedon Jul 16, 2026
fix confirmed on staging
[-]"Enjoying New Expensify" modal cannot be dismissed — dismisses then immediately reappears[/-][+][Due for payment 2026-07-23] "Enjoying New Expensify" modal cannot be dismissed — dismisses then immediately reappears[/+]melvin-bot commentedon Jul 16, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.34-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-23. 🎊