You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-10] [$250] Rillet per-card account export opens not here page after changing card name and account export #96415
Version Number: 9.4.36-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#95562 Email or phone of affected tester (no customers):applausetester+sdodjsoddddds@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root Cause: The "Rillet per-card account export" menu item builds its destination URL from whatever the live active route happens to be, not from a deterministic base path. The onPress is Navigation.navigate(createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_COMPANY_CARD_EXPORT.path)). With no basePath argument, createDynamicRoute falls back to Navigation.getActiveRoute() and appends /edit/export. After you edit the card name (goes back with a re-seeded route) and pick an account (which pops back via goBack(useDynamicBackPath(...))), the active route left in the stack no longer resolves to a clean company-card-details path. On the second open, the resulting .../edit/export URL fails entryScreens validation in getStateFromPath and falls through to the NOT_FOUND screen — the "Not here" page.
This is a regression from PR #95562, which made edit/export a shared dynamic suffix by adding a second entry screen (RILLET_CARD_ACCOUNT_CARD_LIST) at ROUTES.ts:806-809. The route is now reachable from two base screens with different URL shapes, which exposes the pre-existing fragility of deriving the export URL from getActiveRoute() across an edit → select → reopen sequence.
Recommended Fix: Pass an explicit, deterministic basePath to createDynamicRoute instead of relying on the live active route — mirroring what the card-name edit page already does at WorkspaceCompanyCardEditCardNamePage.tsx:53. In the details page onPress, build the base from the known feed/cardID:
This removes the dependency on whatever getActiveRoute() returns after the select → goBack, so the export route always resolves to a valid entry screen.
First export open: getActiveRoute() + /edit/export; the short-form correction in OldRoutes.ts still maps it to DYNAMIC_COMPANY_CARD_DETAILS → passes entryScreens → selector renders.
Second export open: getActiveRoute() now yields a base path that (after +/edit/export and attempted correction) matches no entryScreens screen → getStateFromPath logs "None of the N dynamic suffix candidate(s) passed entryScreens validation" and falls through to NOT_FOUND.
Alternatives considered / ruled out:
Card becomes undefined after rename — unlikely; the "Not here" comes from route resolution (NOT_FOUND screen), not the details page's if (!card) return <NotFoundPage/>, and renaming doesn't drop the card from useCardsList.
New Rillet linking patterns colliding — the new patterns live under /accounting/rillet/, so they don't win the longest-match against the company-cards path.
Confidence: Medium. The routing mechanism, the NOT_FOUND source, and the exact PR change are confirmed with file:line. The precise malformed URL string produced on the second open was not confirmed with a live run (Jest was gated in this environment). To pin it down / confirm before merging a fix, search client logs for the string [getStateFromPath.ts][DynamicRoute] None of the from the staging web repro — it logs the exact failing path: and the tried patterns.
Alternative fix (lower-risk stopgap): once the log reveals the exact malformed path, add a correction rule in OldRoutes.ts (mirroring the existing line 82 rule) that normalizes it back to .../company-card-details/:feed/:cardID/edit/export. The explicit-basePath fix above is the more robust root-cause change.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/96415) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Open Workspaces tab and choose a workspace
Open Members page and click on the member with company card.
Click on the company card.
Click Card name > Save.
Click "Rillet per-card account export".
Select another option from selection list.
Click Rillet per-card account export" again.
Verify selection list opens again instead of Not found page.
Go back and press Card name again
Reload the App while Card name RHP open and verify RHP did not close
Go back and verify "Card details" page open
Do we agree 👍 or 👎
Activity
melvin-bot commentedon Jul 17, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #95562
melvin-bot commentedon Jul 17, 2026
💬 A slack conversation has been started in #expensify-open-source
applause-bot commentedon Jul 17, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/911df3dc10e8873c4c23643f145f3745db6a50ada5e8e0fbce0ff417cbb4c970
github-actions commentedon Jul 17, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 17, 2026
Issue Analysis
Root Cause: The "Rillet per-card account export" menu item builds its destination URL from whatever the live active route happens to be, not from a deterministic base path. The onPress is
Navigation.navigate(createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_COMPANY_CARD_EXPORT.path)). With nobasePathargument,createDynamicRoutefalls back toNavigation.getActiveRoute()and appends/edit/export. After you edit the card name (goes back with a re-seeded route) and pick an account (which pops back viagoBack(useDynamicBackPath(...))), the active route left in the stack no longer resolves to a clean company-card-details path. On the second open, the resulting.../edit/exportURL failsentryScreensvalidation ingetStateFromPathand falls through to the NOT_FOUND screen — the "Not here" page.This is a regression from PR #95562, which made
edit/exporta shared dynamic suffix by adding a second entry screen (RILLET_CARD_ACCOUNT_CARD_LIST) atROUTES.ts:806-809. The route is now reachable from two base screens with different URL shapes, which exposes the pre-existing fragility of deriving the export URL fromgetActiveRoute()across an edit → select → reopen sequence.Recommended Fix: Pass an explicit, deterministic
basePathtocreateDynamicRouteinstead of relying on the live active route — mirroring what the card-name edit page already does atWorkspaceCompanyCardEditCardNamePage.tsx:53. In the details page onPress, build the base from the known feed/cardID:This removes the dependency on whatever
getActiveRoute()returns after the select → goBack, so the export route always resolves to a valid entry screen.Investigation details, evidence & confidence
Trace (why open #2 fails but open #1 works):
WorkspaceCompanyCardEditCardNamePage.tsx:53-54doesgoBack(createDynamicRoute(...details...), {compareParams: false}), re-seeding the details route.getActiveRoute()+/edit/export; the short-form correction inOldRoutes.tsstill maps it toDYNAMIC_COMPANY_CARD_DETAILS→ passesentryScreens→ selector renders.DynamicWorkspaceCompanyCardAccountSelectCardPage.tsx:91doesgoBack(useDynamicBackPath('edit/export')); the details route left in state is derived from the selector's path.getActiveRoute()now yields a base path that (after+/edit/exportand attempted correction) matches noentryScreensscreen →getStateFromPathlogs"None of the N dynamic suffix candidate(s) passed entryScreens validation"and falls through to NOT_FOUND.Alternatives considered / ruled out:
if (!card) return <NotFoundPage/>, and renaming doesn't drop the card fromuseCardsList./accounting/rillet/, so they don't win the longest-match against the company-cards path.Confidence: Medium. The routing mechanism, the NOT_FOUND source, and the exact PR change are confirmed with file:line. The precise malformed URL string produced on the second open was not confirmed with a live run (Jest was gated in this environment). To pin it down / confirm before merging a fix, search client logs for the string
[getStateFromPath.ts][DynamicRoute] None of thefrom the staging web repro — it logs the exact failingpath:and the tried patterns.Alternative fix (lower-risk stopgap): once the log reveals the exact malformed path, add a correction rule in
OldRoutes.ts(mirroring the existing line 82 rule) that normalizes it back to.../company-card-details/:feed/:cardID/edit/export. The explicit-basePathfix above is the more robust root-cause change.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/96415)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
truph01 commentedon Jul 17, 2026
Please assign me
77 remaining items
melvin-bot commentedon Aug 9, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 9, 2026
Payment Summary
Resolving PRs:
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Aug 12, 2026
Payment Summary
Contributor: @samranahm paid $250 via Upwork
Contributor+: @truph01 due $250 via NewDot
@truph01 plz complete the BZ checklist and tag me in a post once you have. Thx
truph01 commentedon Aug 12, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR:
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Aug 17, 2026
@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?
garrettmknight commentedon Sep 7, 2026
$250 approved for @truph01