You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-19] Expense - Participant list appears and disappears after opening Create expense flow #96558
Version Number: 9.4.41-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#96228 Email or phone of affected tester (no customers):sdsjodijnsdojsosjio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Create a workspace and disable Submissions in Workflows settings.
Go to staging.new.expensify.com
Open FAB > Create expense.
Expected Result:
Participant list will not appear after opening Create expense flow.
Actual Result:
Participant list appears and disappears after opening Create expense flow when Submissions are disabled.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
When Submissions are disabled on the workspace, opening FAB → Create expense briefly flashes the participant (recipient) list before it auto-closes. The step should never appear — the expense should silently auto-assign to a default destination.
What is the root cause of that problem?
Deploy blocker introduced by #96228 ("remove isNewManualExpenseFlowEnabled beta flag"). That PR made the embedded-confirmation + auto-opening participant picker the default for everyone, and the auto-open decision races with the async resolution of the default participant.
IOURequestStepConfirmation decides whether to auto-open the picker purely from whether default participants are currently populated — it has no "still loading" state:
Default resolution depends on the Submissions setting: useDefaultParticipants.ts:70-71 — shouldAutoReport is autoReporting. With Submissions disabled it takes the selfDMReport branch, which comes from useSelfDMReport.ts:19 and settles a render or two later than the policy-expense-chat branch used when Submissions are enabled.
So on the first render(s) defaultParticipants is empty → shouldAutoOpenParticipantPicker is true → the list renders. A beat later the self-DM default resolves, the auto-assign effect fires, and the picker closes. That window is the visible "appears and disappears" flash. It only reproduces with Submissions disabled because the self-DM branch is the slow-to-resolve one; the enabled (policy chat) branch is already in Onyx, so there's no empty window.
What changes do you think we should make in order to solve the problem?
Don't treat "defaults not yet resolved" as "no defaults." Gate the auto-open so the picker only opens once we know default resolution is actually complete and still empty:
Add a loading/settled signal to useDefaultParticipants (e.g. surface whether the underlying Onyx sources — defaultExpensePolicy / selfDMReport — have loaded), and require it in shouldAutoOpenParticipantPicker at IOURequestStepConfirmation.tsx:299-307, so it stays false until defaults have settled.
Fastest path to unblock deploy
Since this is a deploy blocker, the safest immediate action is to revert #96228 (or re-gate the new flow behind the beta) and land the loading-guard fix as a follow-up.
Related issues
No open duplicates found.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/96558) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
🤖 Draft PR created (fix-forward, no revert): #96561
What it does:useDefaultParticipants now reports whether its Onyx sources are still hydrating (isLoading), and IOURequestStepConfirmation keeps the participant picker from auto-opening while that's true. The flash happened because shouldAutoOpenParticipantPicker treated a not-yet-resolved (empty) default as "no default" and opened the picker, then closed it a beat later once the self‑DM default resolved. isLoading is derived from the POLICY/REPORT collections (plus the billing NVPs) that all the lagging sub-hooks and getPolicyExpenseChat read from, so it stays true for exactly the hydration window that caused the flash.
⚠️ One caveat: I couldn't run the local AI checks (lint/typecheck/jest/react-compiler) in my environment, so I've left those to CI. Please QA the exact repro (Submissions disabled → FAB → Create expense → list must not appear) plus a regression pass on the normal flows before marking it ready for review.
changed the title [-]Expense - Participant list appears and disappears after opening Create expense flow[/-][+][Due for payment 2026-08-19] Expense - Participant list appears and disappears after opening Create expense flow[/+]on Aug 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.52-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-19. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jul 21, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/3ccc9173cbd8225071236bacab12395908acd30e5b7dca42f955e4495ed20982
melvin-bot commentedon Jul 21, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #96228
melvin-bot commentedon Jul 21, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 21, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 21, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When Submissions are disabled on the workspace, opening FAB → Create expense briefly flashes the participant (recipient) list before it auto-closes. The step should never appear — the expense should silently auto-assign to a default destination.
What is the root cause of that problem?
Deploy blocker introduced by #96228 ("remove
isNewManualExpenseFlowEnabledbeta flag"). That PR made the embedded-confirmation + auto-opening participant picker the default for everyone, and the auto-open decision races with the async resolution of the default participant.IOURequestStepConfirmationdecides whether to auto-open the picker purely from whether default participants are currently populated — it has no "still loading" state:Evidence (file:line)
defaultParticipantsis empty:IOURequestStepConfirmation.tsx:299-307drives visibility at:312-316.IOURequestStepConfirmation.tsx:414.useDefaultParticipants.ts:70-71—shouldAutoReportisautoReporting. With Submissions disabled it takes theselfDMReportbranch, which comes fromuseSelfDMReport.ts:19and settles a render or two later than the policy-expense-chat branch used when Submissions are enabled.So on the first render(s)
defaultParticipantsis empty →shouldAutoOpenParticipantPickeristrue→ the list renders. A beat later the self-DM default resolves, the auto-assign effect fires, and the picker closes. That window is the visible "appears and disappears" flash. It only reproduces with Submissions disabled because the self-DM branch is the slow-to-resolve one; the enabled (policy chat) branch is already in Onyx, so there's no empty window.What changes do you think we should make in order to solve the problem?
Don't treat "defaults not yet resolved" as "no defaults." Gate the auto-open so the picker only opens once we know default resolution is actually complete and still empty:
useDefaultParticipants(e.g. surface whether the underlying Onyx sources —defaultExpensePolicy/selfDMReport— have loaded), and require it inshouldAutoOpenParticipantPickeratIOURequestStepConfirmation.tsx:299-307, so it staysfalseuntil defaults have settled.Fastest path to unblock deploy
Since this is a deploy blocker, the safest immediate action is to revert #96228 (or re-gate the new flow behind the beta) and land the loading-guard fix as a follow-up.
Related issues
No open duplicates found.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/96558)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
thelullabyy commentedon Jul 21, 2026
@MelvinBot Please open PR to fix the issue (Do not revert)
MelvinBot commentedon Jul 21, 2026
🤖 Draft PR created (fix-forward, no revert): #96561
What it does:
useDefaultParticipantsnow reports whether its Onyx sources are still hydrating (isLoading), andIOURequestStepConfirmationkeeps the participant picker from auto-opening while that's true. The flash happened becauseshouldAutoOpenParticipantPickertreated a not-yet-resolved (empty) default as "no default" and opened the picker, then closed it a beat later once the self‑DM default resolved.isLoadingis derived from the POLICY/REPORT collections (plus the billing NVPs) that all the lagging sub-hooks andgetPolicyExpenseChatread from, so it stays true for exactly the hydration window that caused the flash.trjExpensify commentedon Jul 21, 2026
I can repro this if I'm set to
Manual. It's pretty minor in the grand scheme of things, but we do need to fix it. 👍2026-07-21_10-15-17.mp4
yuwenmemon commentedon Jul 21, 2026
The offending PR that caused this deploy blocker was reverted with #96661.
@Expensify/applause please retest this issue on the latest staging build now that the PR has been reverted, and confirm whether it still reproduces.
3 remaining items
m-natarajan commentedon Jul 21, 2026
issue not reproduce using build v9.4.41-4.
mac/chrome
Screen.Recording.2026-07-22.at.6.27.24.AM.mov
melvin-bot commentedon Aug 11, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mitarachim commentedon Aug 11, 2026
Deploy Blocker #98230 was identified to be related to the PR #97264 that attempted to fix this issue.
mitarachim commentedon Aug 11, 2026
Deploy Blocker #98240 was identified to be related to the PR #97264 that attempted to fix this issue.
melvin-bot commentedon Aug 11, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Aug 11, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lanitochka17 commentedon Aug 11, 2026
Deploy Blocker #98317 was identified to be related to the PR #97264 that attempted to fix this issue.
[-]Expense - Participant list appears and disappears after opening Create expense flow[/-][+][Due for payment 2026-08-19] Expense - Participant list appears and disappears after opening Create expense flow[/+]melvin-bot commentedon Aug 12, 2026
@puneetlath
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.52-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-19. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]