You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-19] Tag section is not displayed when create distance expense via FAB #96632
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Yes — confirmed, this is from #96228 (high confidence)
@trjExpensifyExpensify/App#96228 ("remove isNewManualExpenseFlowEnabled beta flag", merged 2026-07-20) is in this release — it's item 84 on the 2026-07-21 deploy checklist — which lines up with the bug being reproducible in staging but not production.
Root cause: That PR removed the NEW_MANUAL_EXPENSE_FLOW beta gate, making the new embedded-confirmation flow the default for all users. Previously useDefaultParticipants short-circuited to [] when the beta was off; the PR deleted that guard, so the distance-via-FAB flow now pre-seeds the draft transaction with the default workspace (Workspace A, tags disabled) before the confirmation renders. Tag visibility is derived from the resolved policy's report.policyID, so it resolves to Workspace A and shouldShowTags is false — even after the user selects Workspace B, the tag section stays hidden.
Recommended action: As a deploy blocker, the fastest resolution is to revert #96228 (or re-gate behind the beta). A targeted fix would ensure the confirmation re-resolves policyID/reportID to the workspace the user actually selects in the distance flow before computing tag visibility.
Tag visibility keyed on the resolved policy — useFooterDerivedFlags.ts:83: shouldShowTags = (isPolicyExpenseChat || isUnreported || isCreatingTrackExpense) && hasEnabledTags(policyTagLists). policyTagLists comes from the policy resolved via report.policyID in getIOURequestPolicyID (MoneyRequest.ts:582-586) → Workspace A → hasEnabledTags is false → Tags section hidden.
One nuance worth a device repro before landing a fix: it's not yet pinned whether selecting Workspace B fails to update report.policyID at all, or updates it one render late. But the exposure of the bug (staging-only, all users) is unambiguously #96228.
changed the title [-]Tag section is not displayed when create distance expense via FAB[/-][+][Due for payment 2026-08-19] Tag section is not displayed when create distance expense via FAB[/+]on Aug 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.52-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-19. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
melvin-bot commentedon Jul 21, 2026
Triggered auto assignment to @madmax330 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 21, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 21, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
trjExpensify commentedon Jul 21, 2026
@MelvinBot confirm this is from #96228 CC: @puneetlath @thelullabyy
MelvinBot commentedon Jul 21, 2026
Yes — confirmed, this is from #96228 (high confidence)
@trjExpensifyExpensify/App#96228 ("removeisNewManualExpenseFlowEnabledbeta flag", merged 2026-07-20) is in this release — it's item 84 on the 2026-07-21 deploy checklist — which lines up with the bug being reproducible in staging but not production.Root cause: That PR removed the
NEW_MANUAL_EXPENSE_FLOWbeta gate, making the new embedded-confirmation flow the default for all users. PreviouslyuseDefaultParticipantsshort-circuited to[]when the beta was off; the PR deleted that guard, so the distance-via-FAB flow now pre-seeds the draft transaction with the default workspace (Workspace A, tags disabled) before the confirmation renders. Tag visibility is derived from the resolved policy'sreport.policyID, so it resolves to Workspace A andshouldShowTagsisfalse— even after the user selects Workspace B, the tag section stays hidden.Recommended action: As a deploy blocker, the fastest resolution is to revert #96228 (or re-gate behind the beta). A targeted fix would ensure the confirmation re-resolves
policyID/reportIDto the workspace the user actually selects in the distance flow before computing tag visibility.Evidence (App SHA
50ce5c3)if (!isNewManualExpenseFlowEnabled) return [];short-circuit that feat: remove isNewManualExpenseFlowEnabled beta flag #96228 deleted fromsrc/hooks/useDefaultParticipants.ts. The hook now unconditionally returns the default-expense-policy (Workspace A) chat participants.src/hooks/useResetIOUType.ts:94-99seeds the freshly-rebuilt distance transaction and binds itsreportIDto Workspace A's expense chat. This is the pathDistanceRequestStartPage.tsx:80-89uses for the FAB distance flow.useFooterDerivedFlags.ts:83:shouldShowTags = (isPolicyExpenseChat || isUnreported || isCreatingTrackExpense) && hasEnabledTags(policyTagLists).policyTagListscomes from the policy resolved viareport.policyIDingetIOURequestPolicyID(MoneyRequest.ts:582-586) → Workspace A →hasEnabledTagsisfalse→ Tags section hidden.IOURequestStepConfirmation.tsxhandleParticipantsAddedexplicitly describe the new "seeded with the default workspace" design — behavior introduced by this PR.One nuance worth a device repro before landing a fix: it's not yet pinned whether selecting Workspace B fails to update
report.policyIDat all, or updates it one render late. But the exposure of the bug (staging-only, all users) is unambiguously #96228.CC:
puneetlaththelullabyyyuwenmemon commentedon Jul 21, 2026
The offending PR that caused this deploy blocker was reverted with #96661.
@Expensify/applause please retest this issue on the latest staging build now that the PR has been reverted, and confirm whether it still reproduces.
3 remaining items
m-natarajan commentedon Jul 21, 2026
issue not reproduce using build v9.4.41-4.
Mac/chrome
Screen.Recording.2026-07-22.at.6.55.57.AM.mov
melvin-bot commentedon Aug 11, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mitarachim commentedon Aug 11, 2026
Deploy Blocker #98230 was identified to be related to the PR #97264 that attempted to fix this issue.
mitarachim commentedon Aug 11, 2026
Deploy Blocker #98240 was identified to be related to the PR #97264 that attempted to fix this issue.
melvin-bot commentedon Aug 11, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Aug 11, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lanitochka17 commentedon Aug 11, 2026
Deploy Blocker #98317 was identified to be related to the PR #97264 that attempted to fix this issue.
[-]Tag section is not displayed when create distance expense via FAB[/-][+][Due for payment 2026-08-19] Tag section is not displayed when create distance expense via FAB[/+]melvin-bot commentedon Aug 12, 2026
@thelullabyy
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.52-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-19. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]