Skip to content

[Due for payment 2026-08-19] Tag section is not displayed when create distance expense via FAB #96632

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.41-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/65630127/folder/13176676/41237304/1587374940?sort=%2Bstatus_id
Email or phone of affected tester (no customers): gocemate+buzz1903@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: windows 10/chrome
App Component: Chat Report View

Action Performed:

Precondition:
User have default Workspace A with no tags option enabled
User have Workspace B with tags enabled

Steps:

  1. Go to FAB> Track manual/map distance> Select Workspace B
  2. Check options on Confirm details page

Expected Result:

Tags option should be displayed

Actual Result:

Tags option is missing

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7213418_1784633704756.Recording__1227.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @thelullabyy

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 21, 2026
  2. melvin-bot commented on Jul 21, 2026

    @melvin-bot

    Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jul 21, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Jul 21, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. trjExpensify commented on Jul 21, 2026

    @trjExpensify
    Contributor

    @MelvinBot confirm this is from #96228 CC: @puneetlath @thelullabyy

  6. MelvinBot commented on Jul 21, 2026

    @MelvinBot
    Contributor

    Yes — confirmed, this is from #96228 (high confidence)

    @trjExpensify Expensify/App#96228 ("remove isNewManualExpenseFlowEnabled beta flag", merged 2026-07-20) is in this release — it's item 84 on the 2026-07-21 deploy checklist — which lines up with the bug being reproducible in staging but not production.

    Root cause: That PR removed the NEW_MANUAL_EXPENSE_FLOW beta gate, making the new embedded-confirmation flow the default for all users. Previously useDefaultParticipants short-circuited to [] when the beta was off; the PR deleted that guard, so the distance-via-FAB flow now pre-seeds the draft transaction with the default workspace (Workspace A, tags disabled) before the confirmation renders. Tag visibility is derived from the resolved policy's report.policyID, so it resolves to Workspace A and shouldShowTags is false — even after the user selects Workspace B, the tag section stays hidden.

    Recommended action: As a deploy blocker, the fastest resolution is to revert #96228 (or re-gate behind the beta). A targeted fix would ensure the confirmation re-resolves policyID/reportID to the workspace the user actually selects in the distance flow before computing tag visibility.

    Evidence (App SHA 50ce5c3)

    One nuance worth a device repro before landing a fix: it's not yet pinned whether selecting Workspace B fails to update report.policyID at all, or updates it one render late. But the exposure of the bug (staging-only, all users) is unambiguously #96228.

    CC: puneetlath thelullabyy

  7. yuwenmemon commented on Jul 21, 2026

    @yuwenmemon
    Contributor

    The offending PR that caused this deploy blocker was reverted with #96661.

    @Expensify/applause please retest this issue on the latest staging build now that the PR has been reverted, and confirm whether it still reproduces.

  8. 3 remaining items

  9. m-natarajan commented on Jul 21, 2026

    @m-natarajan

    issue not reproduce using build v9.4.41-4.
    Mac/chrome

    Screen.Recording.2026-07-22.at.6.55.57.AM.mov
  10. melvin-bot commented on Aug 11, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. mitarachim commented on Aug 11, 2026

    @mitarachim

    Deploy Blocker #98230 was identified to be related to the PR #97264 that attempted to fix this issue.

  12. mitarachim commented on Aug 11, 2026

    @mitarachim

    Deploy Blocker #98240 was identified to be related to the PR #97264 that attempted to fix this issue.

  13. melvin-bot commented on Aug 11, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. melvin-bot commented on Aug 11, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  15. lanitochka17 commented on Aug 11, 2026

    @lanitochka17

    Deploy Blocker #98317 was identified to be related to the PR #97264 that attempted to fix this issue.

  16. changed the title [-]Tag section is not displayed when create distance expense via FAB[/-] [+][Due for payment 2026-08-19] Tag section is not displayed when create distance expense via FAB[/+] on Aug 12, 2026
  17. melvin-bot commented on Aug 12, 2026

    @melvin-bot

    @thelullabyy

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.52-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-19. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions