You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-07] Expense - After changing workspace, Category and Tag field are not cleared #96668
Version Number: 9.4.41-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#96228 Email or phone of affected tester (no customers):sdsjodijnsdojsosjio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Create workspace A and B.
Workspace A and B have at least one category and one tag that are mutually exclusive.
Go to staging.new.expensify.com
Open FAB > Create expense > Manual.
Select category and tag.
Click To field.
Select another workspace (workspace B).
Expected Result:
After changing workspace, Category and Tag field will be cleared.
Actual Result:
After changing workspace, Category and Tag field are not cleared.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root Cause: This is a regression from Expensify/App#96228 ("remove isNewManualExpenseFlowEnabled beta flag"), which made the embedded/inline expense-confirmation flow the default. In that flow, switching the workspace via the inline participant picker routes through handleParticipantsAdded, which only clears the category — and only when the new participant is a P2P recipient (IOURequestStepConfirmation.tsx:386-403):
When switching from workspace A to workspace B, both participants are policy expense chats, so isPolicyExpenseChatParticipant is true, the whole block is skipped, and neither Category nor Tag is reset. (Note it also never clears the Tag at all, even in the P2P branch.)
The legacy participants-step flow it replaced did reset both unconditionally on every selection — see useParticipantSubmission.ts:349-355, which always calls setMoneyRequestTag(...) and setMoneyRequestCategory(...) with the destination workspace's defaults. That reset was not carried over into handleParticipantsAdded.
Recommended Fix: In handleParticipantsAdded, when the selected participant is a policy expense chat and its policyID differs from the transaction's current policy, reset Category and Tag to the new workspace's defaults (mirroring useParticipantSubmission.goToNextStep). Also clear the Tag in the existing P2P branch (setMoneyRequestTag(activeTransactionID, '') alongside the existing setMoneyRequestCategory). setMoneyRequestTag will need to be imported from @userActions/IOU/MoneyRequest.
Investigation details & alternatives considered
Symptoms explained: Both Category and Tag persist across a workspace switch — matches the code exactly (Tag is never cleared anywhere in the new path; Category is cleared only for P2P).
Why staging-only / not production: The beta flag removal is on staging (v9.4.41-1) but the old flow (with the reset) was still live in production, which is why it reproduces in staging but not production.
Alternative considered — full revert of feat: remove isNewManualExpenseFlowEnabled beta flag #96228: Valid as the fast deploy-blocker unblock, but the PR is a broad beta-cleanup; a targeted patch to handleParticipantsAdded is smaller in scope and preserves the intended flow. Either path resolves the blocker.
All references above are in Expensify/App, so a code fix here is appropriate (no cross-repo dependency).
Related issues (from a quick scan): none look like duplicates of this specific workspace-switch reset bug.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/96668) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Expense - After changing workspace, Category and Tag field are not cleared[/-][+][Due for payment 2026-08-07] Expense - After changing workspace, Category and Tag field are not cleared[/+]on Jul 31, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jul 21, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/63f1d048dfd864abbe0ac5ae594273024c487201a67831f70ae74db157342b14
melvin-bot commentedon Jul 21, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #96228
melvin-bot commentedon Jul 21, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 21, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 21, 2026
Issue Analysis
Root Cause: This is a regression from Expensify/App#96228 ("remove
isNewManualExpenseFlowEnabledbeta flag"), which made the embedded/inline expense-confirmation flow the default. In that flow, switching the workspace via the inline participant picker routes throughhandleParticipantsAdded, which only clears the category — and only when the new participant is a P2P recipient (IOURequestStepConfirmation.tsx:386-403):When switching from workspace A to workspace B, both participants are policy expense chats, so
isPolicyExpenseChatParticipantistrue, the whole block is skipped, and neither Category nor Tag is reset. (Note it also never clears the Tag at all, even in the P2P branch.)The legacy participants-step flow it replaced did reset both unconditionally on every selection — see
useParticipantSubmission.ts:349-355, which always callssetMoneyRequestTag(...)andsetMoneyRequestCategory(...)with the destination workspace's defaults. That reset was not carried over intohandleParticipantsAdded.Recommended Fix: In
handleParticipantsAdded, when the selected participant is a policy expense chat and itspolicyIDdiffers from the transaction's current policy, reset Category and Tag to the new workspace's defaults (mirroringuseParticipantSubmission.goToNextStep). Also clear the Tag in the existing P2P branch (setMoneyRequestTag(activeTransactionID, '')alongside the existingsetMoneyRequestCategory).setMoneyRequestTagwill need to be imported from@userActions/IOU/MoneyRequest.Investigation details & alternatives considered
handleParticipantsAddedis smaller in scope and preserves the intended flow. Either path resolves the blocker.Expensify/App, so a code fix here is appropriate (no cross-repo dependency).Related issues (from a quick scan): none look like duplicates of this specific workspace-switch reset bug.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/96668)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
trjExpensify commentedon Jul 21, 2026
Confirmed that's how it works on prod. 👍
CC: @thelullabyy
yuwenmemon commentedon Jul 21, 2026
The offending PR that caused this deploy blocker was reverted with #96661.
@Expensify/applause please retest this issue on the latest staging build now that the PR has been reverted, and confirm whether it still reproduces.
puneetlath commentedon Jul 21, 2026
PR reverted.
[-]Expense - After changing workspace, Category and Tag field are not cleared[/-][+][Due for payment 2026-08-07] Expense - After changing workspace, Category and Tag field are not cleared[/+]melvin-bot commentedon Jul 31, 2026
@puneetlath
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]