You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-21] Rules - Receipt require tooltip appears for the second time after dismissal #96795
Version Number: 9.4.43-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#95312 Email or phone of affected tester (no customers):applausetester+ssndjois2jd1@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Log in with Expensifail account.
Enable Rules.
Go to staging.new.expensify.com
Go to workspace settings > Rules > Field requirements.
Click Create field requirement rule.
Select a category.
Select Require for Description, Receipt and Itemized receipt.
Click X on the tooltip.
Click Save rule.
Click Add rule > Field requirements.
Repeat Step 4 to 5.
Expected Result:
Receipt require tooltip will not appear for the second time after dismissal.
Actual Result:
Receipt require tooltip appears for the second time after dismissal.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root Cause: The coupling tooltip's "dismissed" flag is stored only in per-instance React useState, so it never survives leaving the rule page. In FieldRequirementSettingRow.tsx:57 the dismissal lives in dismissedCouplingTooltipKey local state and gates display at line 62. When you do Add rule → Field requirements again, a fresh RequireFieldsRulePageBase mounts new rows and that state resets to undefined, so re-triggering the same coupling shows the tooltip again. Nothing is written to Onyx/NVP, so there is no persistence.
This is an educational (one-time) tooltip — it reuses the product-training styling, Lightbulb icon and PRODUCT_TRAINING.TOOLTIP Sentry label (lines 79-86) — but was hand-rolled and skips the persistence layer the other product-training tooltips use.
Recommended Fix: Persist dismissal through the existing product-training NVP instead of local state:
Add a name to CONST.PRODUCT_TRAINING_TOOLTIP_NAMES (e.g. REQUIRE_FIELDS_RECEIPT_COUPLING).
The fuller/canonical alternative is to register the tooltip in ProductTrainingContext/TOOLTIPS.ts and drive it via useProductTrainingContext, matching every other educational tooltip in the app.
⚠️ Lifting the flag into RequireFieldsRulePageBase or React context would only fix reappearance within a single navigation session — it would still reset on reload. The expected behavior ("once dismissed, don't show again") requires the NVP.
Investigation details
Trigger:getRequireFieldsFieldCouplingTooltipKey returns a key when a field's control is coupling-disabled and the user directly toggled the paired field this session (couplingInteractionFields). Requiring Itemized receipt forces Receipt to Require and locks it → receiptDisabledWhenItemizedRequired. Because couplingInteractionFields is reset per page, the same key re-fires on every new rule.
Why it reappears (data flow):
New rule page mounts → couplingInteractionFields/touchedFields reset to empty.
User re-selects Require on Receipt/Itemized → tooltip key computed → shouldDisplayCouplingTooltip = true.
Click X → hideCouplingTooltip sets localdismissedCouplingTooltipKey only — no Onyx write.
Save → Add rule again → component remounts → dismissedCouplingTooltipKey === undefined → tooltip shows again.
Confidence: High — deterministic client-side state-lifecycle bug, provable from code; no logs needed.
Introduced by PR #95312 (feature is behind the rulesRevamp beta, so this is new-feature-only, consistent with "N/A in production").
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/96795) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Rules - Receipt require tooltip appears for the second time after dismissal[/-][+][Due for payment 2026-08-21] Rules - Receipt require tooltip appears for the second time after dismissal[/+]on Aug 14, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.53-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-21. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jul 22, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/bd81833c1059816cc4b0d65a61d44ed1770e9aa6d00c27098f92c088e859b78f
melvin-bot commentedon Jul 22, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #95312
melvin-bot commentedon Jul 22, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 22, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 22, 2026
Issue Analysis
Root Cause: The coupling tooltip's "dismissed" flag is stored only in per-instance React
useState, so it never survives leaving the rule page. InFieldRequirementSettingRow.tsx:57the dismissal lives indismissedCouplingTooltipKeylocal state and gates display at line 62. When you do Add rule → Field requirements again, a freshRequireFieldsRulePageBasemounts new rows and that state resets toundefined, so re-triggering the same coupling shows the tooltip again. Nothing is written to Onyx/NVP, so there is no persistence.This is an educational (one-time) tooltip — it reuses the product-training styling, Lightbulb icon and
PRODUCT_TRAINING.TOOLTIPSentry label (lines 79-86) — but was hand-rolled and skips the persistence layer the other product-training tooltips use.Recommended Fix: Persist dismissal through the existing product-training NVP instead of local state:
CONST.PRODUCT_TRAINING_TOOLTIP_NAMES(e.g.REQUIRE_FIELDS_RECEIPT_COUPLING).FieldRequirementSettingRow.tsx, drop theuseStateand instead readONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING(viaisProductTrainingElementDismissedinTooltipUtils.ts:5) to computeshouldDisplayCouplingTooltip, and havehideCouplingTooltipcalldismissProductTraining(...)so the dismissal is saved server-side and survives remounts/navigation/sessions.The fuller/canonical alternative is to register the tooltip in
ProductTrainingContext/TOOLTIPS.tsand drive it viauseProductTrainingContext, matching every other educational tooltip in the app.Investigation details
Trigger:
getRequireFieldsFieldCouplingTooltipKeyreturns a key when a field's control is coupling-disabled and the user directly toggled the paired field this session (couplingInteractionFields). Requiring Itemized receipt forces Receipt to Require and locks it →receiptDisabledWhenItemizedRequired. BecausecouplingInteractionFieldsis reset per page, the same key re-fires on every new rule.Why it reappears (data flow):
couplingInteractionFields/touchedFieldsreset to empty.shouldDisplayCouplingTooltip = true.hideCouplingTooltipsets localdismissedCouplingTooltipKeyonly — no Onyx write.dismissedCouplingTooltipKey === undefined→ tooltip shows again.Confidence: High — deterministic client-side state-lifecycle bug, provable from code; no logs needed.
Introduced by PR #95312 (feature is behind the
rulesRevampbeta, so this is new-feature-only, consistent with "N/A in production").Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/96795)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
situchan commentedon Jul 22, 2026
behind beta, not blocker.
This was reported here
cc: @Krishna2323
12 remaining items
Krishna2323 commentedon Aug 3, 2026
PR is ready for review: #97726
cc: @situchan
melvin-bot commentedon Aug 14, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jponikarchuk commentedon Aug 14, 2026
Deploy Blocker #98640 was identified to be related to the PR #97726 that attempted to fix this issue.
[-]Rules - Receipt require tooltip appears for the second time after dismissal[/-][+][Due for payment 2026-08-21] Rules - Receipt require tooltip appears for the second time after dismissal[/+]melvin-bot commentedon Aug 14, 2026
@Krishna2323 / @situchan
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.53-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-21. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Krishna2323 commentedon Aug 17, 2026
@JS00001 this can be closed.