Skip to content

[$250] Editing a comment containing both RTL and LTR characters breaks the (edited) text - Reported by @adeel0202 #9709

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any chat
  2. Type something containing RTL characters
  3. Send the comment
  4. Edit the comment and add LTR characters
  5. Press Save changes

Expected Result:

The (edited) text doesn't break

Actual Result:

The (edited) text breaks

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.79-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-06-13.at.9.17.49.PM.mov

Upwork URL: https://www.upwork.com/jobs/~01c6ba7a40ecceeb34
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1655138110274269

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Jul 5, 2022

    @melvin-bot

    Triggered auto assignment to @trjExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Jul 5, 2022
  3. melvin-bot commented on Jul 5, 2022

    @melvin-bot

    Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  4. trjExpensify commented on Jul 5, 2022

    @trjExpensify
    Contributor

    Passing on to engineering triage. Will remain assigned for CM if it can go external.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 6, 2022
  6. melvin-bot commented on Jul 6, 2022

    @melvin-bot

    Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

  7. sketchydroide commented on Jul 6, 2022

    @sketchydroide
    Contributor

    I think this can be external.

  8. 21 remaining items

  9. melvin-bot commented on Jul 11, 2022

    @melvin-bot

    📣 @Karim-30 You have been assigned to this job by @sketchydroide!
    Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  10. trjExpensify commented on Jul 11, 2022

    @trjExpensify
    Contributor

    @Karim-30 can you apply to the job on upwork when you get a chance?

  11. Karim-30 commented on Jul 11, 2022

    @Karim-30
    Contributor

    Applied

  12. Karim-30 commented on Jul 12, 2022

    @Karim-30
    Contributor

    PR is ready

  13. trjExpensify commented on Jul 25, 2022

    @trjExpensify
    Contributor

    PR is in review. @sketchydroide looks like it's awaiting your approval and we can merge this?

  14. rushatgabhane commented on Jul 28, 2022

    @rushatgabhane
    Member

    @trjExpensify just FYI, we had a regression #10123
    (so half pay for C+)

  15. rushatgabhane commented on Aug 9, 2022

    @rushatgabhane
    Member

    @trjExpensify we can close this out (commenting because the bot won't remind as the reviewing label has been applied)

  16. trjExpensify commented on Aug 10, 2022

    @trjExpensify
    Contributor

    Ah, why didn't the labels get added? 🤔 Processing payments now.

  17. trjExpensify commented on Aug 10, 2022

    @trjExpensify
    Contributor

    Cool, done!

  18. rushatgabhane commented on Aug 10, 2022

    @rushatgabhane
    Member

    why didn't the labels get added

    I think it's because we didn't remove the reviewing label after merging the PR.

    If I'm not wrong, the reviewing label disables Melvin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions