Skip to content

[Due for payment 2026-08-31] [Sentry: APP-J2J] Web onboarding interested-features crash — baseHeadline DOM missing in modifyFeaturesStep #97100

Closed

Description

@mountiny

Sentry

https://expensify.sentry.io/issues/APP-J2J
https://expensify.sentry.io/issues/APP-J1N

Impact (snapshot at filing)

  • Users (total since first seen): 20 (APP-J2J), 7 (APP-J1N)
  • Events: 22 (APP-J2J), 7 (APP-J1N)
  • Users (last 7d): 20 (APP-J2J), 7 (APP-J1N)
  • First seen: 2026-07-21
  • Last seen: ongoing (2026-07-26)
  • Platform: web (Mobile Safari)
  • App version(s): 9.4.43-1
  • Affected route(s): /onboarding/interested-features
  • Mechanism: auto.browser.global_handlers.onunhandledrejection

Stack trace (top frames)

modifyFeaturesStep
  baseHeadline.innerText = COPY.base_headline

Suspected cause

Onboarding interested-features step runs legacy/modify script before baseHeadline DOM node exists, causing TypeError when setting innerText.

Reproduction

Unknown — see Sentry events. Likely mobile Safari on /onboarding/interested-features.

Related

  • Sibling Sentry IDs: APP-J1N
  • Prior GH issues: none
Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Jul 27, 2026
  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 27, 2026
  3. melvin-bot commented on Jul 27, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ChavdaSachin (External)

  4. melvin-bot commented on Jul 27, 2026

    @melvin-bot
  5. MelvinBot commented on Jul 27, 2026

    @MelvinBot
    Contributor

    Proposal

    TL;DR: This crash is not coming from App code. The frames modifyFeaturesStep and baseHeadline.innerText = COPY.base_headline reference symbols that don't exist anywhere in this repo (or its node_modules). It's an injected third-party script (browser extension / autofill / translation tool) throwing inside the page, which Sentry's global onunhandledrejection handler captures indiscriminately. The recommended fix is to filter it out in Sentry, not to change onboarding code.

    What is the root cause of that problem?

    The reported stack is foreign to App:

    • modifyFeaturesStep — no match anywhere in the repo (excluding/including node_modules).
    • baseHeadline / COPY.base_headline — no match. App has no global COPY object.
    • .innerText = ... — App is React Native Web; it renders through React and never mutates the DOM via .innerText. There are zero .innerText assignments in src/.

    That combination (imperative .innerText DOM mutation + a global COPY object with snake_case keys + a bespoke modifyFeaturesStep routine) is characteristic of a script injected into the page from outside the bundle — a browser extension, autofill/password manager, or a translation/marketing snippet. The auto.browser.global_handlers.onunhandledrejection mechanism means Sentry's global handler swept up an unhandled promise rejection thrown by that script; Sentry attributes it to whatever route the tab was on (/onboarding/interested-features) even though App didn't throw it.

    The impact profile is consistent with injected-script noise, not a real regression: very low unique users (20 + 7), single platform (Mobile Safari), single version.

    What changes do you think we should make in order to solve the problem?

    App-side, the fix is to stop ingesting foreign errors rather than to touch onboarding:

    1. In src/setup/telemetry/setupSentry.ts:18-32 (which today only sets ignoreErrors: [CONST.ERROR.UPDATE_REQUIRED]), add Sentry's third-party error filter so events whose stack frames don't originate from Expensify bundles are dropped — either the thirdPartyErrorFilterIntegration (keyed via the bundler plugin applicationKey), or a beforeSend that discards events whose top in-app frame URL isn't an Expensify origin.
    2. Mark the two Sentry issues (APP-J2J, APP-J1N) as ignored, or add a Sentry inbound data filter for these frames.

    What alternative solutions did you explore? (Optional)

    • Verify the origin first (recommended before coding): the issue body only lists the top frames without their absolute file URLs. Open APP-J2J / APP-J1N and check the frame abs_path — it will almost certainly be a chrome-extension:// / moz-extension:// / safari-web-extension:// URL or a non-Expensify CDN, which confirms it's external and lets you scope the filter precisely.
    • Considered whether onboarding renders interested-features before a required node mounts — ruled out, because none of the crashing symbols exist in the onboarding code (src/pages/OnboardingInterestedFeatures/) or anywhere else in App.
    Investigation details & confidence

    Confidence: High that the crash is not in App code (exhaustive grep of repo + node_modules for all three symbols returns nothing, and App never uses .innerText). Medium on the precise external source, since the frame file URLs weren't included in the issue — confirm via the Sentry frames as noted above.

    Checked against App@557846e:

    • grep -rn "modifyFeaturesStep" → no matches (repo + node_modules)
    • grep -rn "baseHeadline\|base_headline\|COPY\.base" → no matches
    • grep -rn "\.innerText" src/ → no matches

    Quick scan for a pre-existing tracking issue found none.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/97100) to create a draft PR adding the third-party error filter in setupSentry.ts.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  6. mountiny commented on Jul 29, 2026

    @mountiny
    ContributorAuthor

    @ChavdaSachin can you review the Melvin bot proposal?

  7. 16 remaining items

  8. mountiny commented on Aug 18, 2026

    @mountiny
    ContributorAuthor

    @ChavdaSachin bump please

  9. ChavdaSachin commented on Aug 19, 2026

    @ChavdaSachin
    Contributor

    @mountiny I don't understand it fully.
    It's better to find an expert to fix it.

    Thank you.

    Sorry for the delays 🙏

  10. melvin-bot commented on Aug 24, 2026

    @melvin-bot

    @mountiny @staszekscp @ChavdaSachin this issue is now 4 weeks old, please consider:

    • Finding a contributor to fix the bug
    • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
    • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

    Thanks!

  11. staszekscp commented on Aug 31, 2026

    @staszekscp
    Contributor

    Hey! This one's resolved, no errors since August 19th 🎉

  12. changed the title [-][Sentry: APP-J2J] Web onboarding interested-features crash — baseHeadline DOM missing in modifyFeaturesStep[/-] [+][Due for payment 2026-08-31] [Sentry: APP-J2J] Web onboarding interested-features crash — baseHeadline DOM missing in modifyFeaturesStep[/+] on Aug 31, 2026
  13. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  14. ChavdaSachin commented on Aug 31, 2026

    @ChavdaSachin
    Contributor

    No payment needed here; ready to be closed.
    cc. @mallenexpensify

  15. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    Payment Summary

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions