Skip to content

[Due for payment 2026-08-05] Rillet- Not here page opens when export row is opened from card details page in workspace chat #97160

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.45-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #96923
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Workspace is connected to Rillet.
  • Assign a virtual card to yourself.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Click card link in card assigned system message.
  4. Click on the export row.

Expected Result:

Rillet per-card account export RHP will open.

Actual Result:

Not here page opens when export row is opened from card details page in workspace chat

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7219183_1785184795779.7.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7219183

Issue OwnerCurrent Issue Owner: @truph01

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 27, 2026
  2. applause-bot commented on Jul 27, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/85488e8ee3316543df33363d1b5d5582a12cb004e1439ba234f44f94818dbbed

  3. melvin-bot commented on Jul 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #96923

  4. melvin-bot commented on Jul 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jul 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jul 27, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Opening the Expensify Card details page from a workspace chat (the "card assigned" system message) and tapping the Accounting / export row opens the "Not here" (NotFoundPage) instead of the Rillet per-card export RHP. This is a regression from PR #96923, which added the export row to the Expensify Card details page.

    What is the root cause of that problem?

    The Expensify Card details page is a single component reachable from two different screens on two different navigators:

    The export row calls createDynamicRoute(WORKSPACE_COMPANY_CARD_EXPORT.getRoute(...)), which appends the export suffix onto the current active route. getStateFromPath then validates the base screen against the export route's entryScreens — but that list only contains the workspace-settings variant, not the chat variant:

    // src/ROUTES.ts (WORKSPACE_COMPANY_CARD_EXPORT)
    entryScreens: [DYNAMIC_COMPANY_CARD_DETAILS, WORKSPACE.DYNAMIC_EXPENSIFY_CARD_DETAILS, ACCOUNTING.RILLET_CARD_ACCOUNT_CARD_LIST]
    // missing: EXPENSIFY_CARD.DYNAMIC_EXPENSIFY_CARD_DETAILS

    When opened from chat the focused screen is Dynamic_Expensify_Card_Details, which fails the entryScreens check, so the dynamic route falls through to a NotFoundPage. From workspace settings the same row works because that variant is in entryScreens.

    Evidence & data flow

    Flow: chat card link → expensify-card-details/:cardID/:policyID (EXPENSIFY_CARD navigator) → tap export → createDynamicRoute builds .../expensify-card-details/.../edit/export/<feed>/<cardID> → getStateFromPath focused screen Dynamic_Expensify_Card_Details not in entryScreens → NotFoundPage.

    What changes do you think we should make in order to solve the problem?

    1. Add SCREENS.EXPENSIFY_CARD.DYNAMIC_EXPENSIFY_CARD_DETAILS to WORKSPACE_COMPANY_CARD_EXPORT.entryScreens in src/ROUTES.ts.
    2. Ensure the export screen (DYNAMIC_COMPANY_CARD_EXPORT) is reachable from the RHP EXPENSIFY_CARD navigator context in linkingConfig/config.ts (mirror how it is registered under the Workspace navigator), otherwise the RHP won't resolve even after step 1.

    Since this is a deploy blocker on a brand-new feature, reverting #96923 is also a clean option if a forward fix can't be validated quickly.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/97160) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. MelvinBot commented on Jul 27, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #96923 - "Add Accounting option to Expensify Card details + Update design" by @s77rt (High confidence)
    Related Issues: #95951 (feature issue this PR implemented)

    Recommendation: ROLL FORWARD

    The bug is a two-line navigation-config omission on a brand-new feature; a targeted forward fix is smaller and safer than reverting an 18-file PR that also ships the intended design update. Revert remains a clean fallback if the fix can't be validated before deploy.

    Assigned: @s77rt (PR author), @truph01 and @lakchote (approving reviewers) from the causing PR
    Labels: No label changes. DeployBlockerCash is correct (App deploy blocker, frontend fix required) and is kept.

    📋 Detailed Analysis

    Evidence

    • PR Add Accounting option to Expensify Card details + Update design #96923 (merge commit e576d1fc6c86db7f47ab78691c7753282e0f91ca, merged 2026-07-27, author @s77rt) is included in the current StagingDeployCash (Deploy Checklist: New Expensify 2026-07-27 #97134).
    • The PR added the Accounting/export row to the Expensify Card details page and modified the WORKSPACE_COMPANY_CARD_EXPORT dynamic route in src/ROUTES.ts (path edit/export/:cardID? → edit/export/:feed/:cardID). Its file list includes src/ROUTES.ts and src/pages/workspace/expensifyCard/DynamicWorkspaceExpensifyCardDetailsPage.tsx — exactly the affected code paths.
    • Reproducible on staging only; N/A in production because this is a new feature. Consistent with a regression introduced by this staging PR.

    Verification (against App HEAD 71c5c9f2801501608e7304cc5e19151104979a54)

    • Export row wiring: DynamicWorkspaceExpensifyCardDetailsPage.tsx:481-486 calls Navigation.navigate(createDynamicRoute(WORKSPACE_COMPANY_CARD_EXPORT.getRoute(...))), appending the export suffix onto the current active route.
    • Export route entryScreens: src/ROUTES.ts:816 lists only the WORKSPACE variants — WORKSPACE.DYNAMIC_COMPANY_CARD_DETAILS, WORKSPACE.DYNAMIC_EXPENSIFY_CARD_DETAILS, WORKSPACE.ACCOUNTING.RILLET_CARD_ACCOUNT_CARD_LIST — and does NOT include SCREENS.EXPENSIFY_CARD.DYNAMIC_EXPENSIFY_CARD_DETAILS (SCREENS.ts:419, screen name Dynamic_Expensify_Card_Details).
    • Chat deep link uses the RHP variant: ReportActionsUtils.ts:4559-4561 builds the card-assigned link via EXPENSIFY_CARD_DETAILS.getRoute(...), which lands on the EXPENSIFY_CARD RHP navigator screen Dynamic_Expensify_Card_Details.
    • entryScreens enforcement / NOT_FOUND fallthrough: getStateFromPath.ts:48-63 — when the focused screen isn't in entryScreens, the candidate fails validation and falls through (Not Found).
    • Secondary latent gap: the export screen (DYNAMIC_COMPANY_CARD_EXPORT) is registered only under the Workspace navigator (linkingConfig/config.ts:847); the EXPENSIFY_CARD RHP navigator (config.ts:1592-1595) registers card details/name/limit/limit-type but NOT the export screen. So the export RHP is not reachable from the chat navigator context even after the entryScreens fix.

    Root Cause

    The Expensify Card details page is one component reachable from two screens on two navigators: WORKSPACE.DYNAMIC_EXPENSIFY_CARD_DETAILS (from workspace settings) and EXPENSIFY_CARD.DYNAMIC_EXPENSIFY_CARD_DETAILS (from the chat card-assigned deep link, RHP navigator). The new export row's dynamic route was only wired for the workspace-settings variant. When the page is opened from chat, the focused screen (Dynamic_Expensify_Card_Details) is absent from WORKSPACE_COMPANY_CARD_EXPORT.entryScreens, so getStateFromPath fails validation and renders NotFoundPage ("Not here").

    Suggested forward fix

    1. Add SCREENS.EXPENSIFY_CARD.DYNAMIC_EXPENSIFY_CARD_DETAILS to WORKSPACE_COMPANY_CARD_EXPORT.entryScreens in src/ROUTES.ts.
    2. Register the export screen (DYNAMIC_COMPANY_CARD_EXPORT) under the EXPENSIFY_CARD RHP navigator in linkingConfig/config.ts (mirroring the Workspace navigator registration at config.ts:847), so the export RHP resolves from the chat navigator context.
  8. s77rt commented on Jul 27, 2026

    @s77rt
    Member

    Raised PR.

  9. IuliiaHerets commented on Jul 28, 2026

    @IuliiaHerets

    Chrome / v9.4.45-2
    No Export option in card details

    REC-20260728095151.mp4
  10. lakchote commented on Jul 28, 2026

    @lakchote
    Contributor

    Chrome / v9.4.45-2 No Export option in card details

    REC-20260728095151.mp4

    The export row only shows when the workspace is connected to Rillet with export to multiple accounts enabled, so this looks like a test account issue rather than the fix not working. The fix is in 9.4.45-2 and only changes what happens after you click the row, it can't hide it. Rillet is also behind a beta, so a fresh workspace on another account won't be able to connect it. Can you retest with the account from the original report (applausetester+ssndjois2jd1@applause.expensifail.com) where the workspace is already set up?

  11. s77rt commented on Jul 28, 2026

    @s77rt
    Member

    @IuliiaHerets Yeah sorry about that (just copied the steps from this issue). You need to enable the "Configure exporting to multiple accounts" option for that option to show up

    Image
  12. mitarachim commented on Jul 28, 2026

    @mitarachim

    Deploy Blocker #97200 was identified to be related to the PR #97164 that attempted to fix this issue.

  13. IuliiaHerets commented on Jul 28, 2026

    @IuliiaHerets

    @lakchote passed in this way

    REC-20260728104149.mp4
  14. changed the title [-]Rillet- Not here page opens when export row is opened from card details page in workspace chat[/-] [+][Due for payment 2026-08-05] Rillet- Not here page opens when export row is opened from card details page in workspace chat[/+] on Jul 29, 2026
  15. melvin-bot commented on Jul 29, 2026

    @melvin-bot

    @truph01

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.45-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-05. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions