Skip to content

[HOLD for payment 2022-08-01] [$250] Web - New Room - Drop down is opened again after use the Enter Key to create a new room #9741

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with expensifail account
  3. Click on Fub menu - New Room
  4. Type any room and use Enter Key
  5. Select any Workspace and use Enter Key
  6. Select any Visibility option and use Enter Key

Expected Result:

Drop down should not open again after use Enter Key

Actual Result:

Drop down is opened again after use the Enter Key to create a new room

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.79.17

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any expensifail account

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.729.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Jul 6, 2022

    @melvin-bot

    Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. MariaHCD commented on Jul 7, 2022

    @MariaHCD
    Contributor

    Unable to reproduce on staging or on local on a mac:

    Untitled_.Jul.7.2022.4_56.PM.mp4

    But I am able to reproduce the issue on a windows device.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 7, 2022
  4. melvin-bot commented on Jul 7, 2022

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  5. MitchExpensify commented on Jul 7, 2022

    @MitchExpensify
    Contributor
  6. 16 remaining items

  7. mananjadhav commented on Jul 15, 2022

    @mananjadhav
    Collaborator

    I tested this on Desktop. I am not able to reproduce this on Mac, but once on Windows. @eVoloshchak's proposal looks good.

    🎀 👀 🎀 C+ reviewed

    cc - @marcochavezf

  8. marcochavezf commented on Jul 18, 2022

    @marcochavezf
    Contributor

    Cool, thank you guys! Assigning @eVoloshchak 👍🏽

  9. melvin-bot commented on Jul 18, 2022

    @melvin-bot

    📣 @eVoloshchak You have been assigned to this job by @marcochavezf!
    Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  10. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 18, 2022
  11. eVoloshchak commented on Jul 18, 2022

    @eVoloshchak
    Contributor

    PR is up

  12. mvtglobally commented on Jul 26, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  13. MitchExpensify commented on Jul 26, 2022

    @MitchExpensify
    Contributor

    Reminder to pay on August 1st assuming no regressions

  14. changed the title [-][$250] Web - New Room - Drop down is opened again after use the Enter Key to create a new room[/-] [+][HOLD for payment 2022-08-01] [$250] Web - New Room - Drop down is opened again after use the Enter Key to create a new room[/+] on Jul 28, 2022
  15. mvtglobally commented on Aug 2, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (Second week)

  16. MitchExpensify commented on Aug 2, 2022

    @MitchExpensify
    Contributor

    Paid @eVoloshchak, just waiting on @mananjadhav to accept the offer to process C+ payment then we'll close this out

  17. mananjadhav commented on Aug 2, 2022

    @mananjadhav
    Collaborator

    just waiting on @mananjadhav to accept the offer

    Done @MitchExpensify

  18. MitchExpensify commented on Aug 3, 2022

    @MitchExpensify
    Contributor

    Paid and contracts ended, thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions