Skip to content

[Due for payment 2026-08-08] Payment issue for E/App PR#94669 #97616

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #94669
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/634354.
Contributor+ member who reviewed the PR - @ahmedGaber93.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Aug 1, 2026

    @melvin-bot
    Author

    @ahmedGaber93 The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. melvin-bot commented on Aug 4, 2026

    @melvin-bot
    Author

    @ahmedGaber93 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  3. ahmedGaber93 commented on Aug 6, 2026

    @ahmedGaber93

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/A. new feature
      Link to the comment on the Issue: N/A. new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/670289

    Regression Test Proposal

    Precondition:

    Test:

    1. Open Search and switch to the Expenses view with expenses spanning more than one currency.
    2. Select some expenses and verify the footer shows the total spend in the default currency.
    3. Change the footer total currency to a different currency.
    4. Verify the total briefly shows a loading skeleton, then updates to the converted amount in the selected currency.
    5. Select a subset of expenses and verify the footer displays the selected total in the selected currency.
    6. Select expenses beyond the first page of results and verify the total still converts correctly and the currency picker remains enabled.
    7. Switch to the Reports view, select one or more reports, change the currency, and verify the footer total is converted (showing the default-currency total until the conversion completes).
    8. Open a grouped search (for example, grouped by category), change the currency with nothing selected, and verify the grand total is converted. Then select one or more groups and verify the selected total is also converted.
    9. In the grouped search, select an entire group, then expand another group and select an individual transaction. Verify the footer total is converted and includes both the selected group and the individual transaction.
    10. Reset the currency picker to the default currency and verify the original total is restored.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-b855-ae32-76c5-1ad727e2e584
  4. ahmedGaber93 commented on Aug 6, 2026

    @ahmedGaber93

    While the first PR #90777 was reverted, and we have a regression in the second PR #97767, I think the issue compensation should remain $250 without applying the regression penalty due to the complexity of the task.

  5. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 7, 2026
  6. melvin-bot commented on Aug 7, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  7. melvin-bot commented on Aug 7, 2026

    @melvin-bot
    Author

    Payment Summary

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
  8. melvin-bot commented on Aug 10, 2026

    @melvin-bot
    Author

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  9. mallenexpensify commented on Aug 11, 2026

    @mallenexpensify

    @ahmedGaber93 If you think the work warrants an increase (inc. not reducing due to regressions/reverts), plz follow the steps in the C+ doc.

  10. m-natarajan commented on Aug 11, 2026

    @m-natarajan

    @ahmedGaber93 This is regarding the Regression test proposal
    Step 2 shows the total only after selecting the expenses. If this is expected can you please update the steps.

    Recording.3345.mp4
  11. ahmedGaber93 commented on Aug 12, 2026

    @ahmedGaber93

    If this is expected can you please update the steps.

    @m-natarajan Yes, updated.

  12. ahmedGaber93 commented on Aug 12, 2026

    @ahmedGaber93

    @mountiny, I’d like to discuss the issue compensation.

    While the first PR #90777 was reverted, and the second PR #97767 introduced a regression, I think the compensation should remain $250 without applying the regression penalty, given the complexity of the task.

  13. mountiny commented on Aug 12, 2026

    @mountiny

    I agree!

  14. ahmedGaber93 commented on Aug 12, 2026

    @ahmedGaber93

    @mallenexpensify it is ready for payment.

  15. mallenexpensify commented on Aug 12, 2026

    @mallenexpensify

    Payment Summary

    Contributor+: @ahmedGaber93 due $250 via NewDot

  16. flaviadefaria commented on Sep 2, 2026

    @flaviadefaria

    Approved: @ahmedGaber93 due $250 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions