You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Pay with BA - Verify identity page is not shown after confirming personal details #97716
Version Number: 9.4.48-2 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#95946 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: MacBook Air 26.5.2 Chrome, iPhone 15 iOS 26.5.2 App Component: Other
Action Performed:
Create and validate an account in ND
Create a workspace
Add an expense in the workspace chat, submit and approve it
Click Pay - Pay with business bank account - Connect manually
Enter personal account details, click Confirm on the Personal info confirmation screen
Expected Result:
"Verify identity" page is opened
Actual Result:
After clicking Confirm on the Personal info confirmation screen user is navigated to the Company info step, "Verify identity" page is not shown
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Pay with BA-Verify identity page is not shown after confirming personal details[/-][+]Pay with BA - Verify identity page is not shown after confirming personal details[/+]on Aug 3, 2026
Classification: Unclear (frontend vs backend not yet confirmed) — leaning backend/data-state Causing PR: Not confirmed. #95946 - "Migrate Add Personal Bank Account flow from useSubStep to useSubPage" by @rinej (auto-assigned) is ruled out with high confidence as the cause of this symptom (see below). Related Issues: N/A
Recommendation: NEEDS INVESTIGATION
The Verify identity step is skipped because the flow believes Onfido is already complete (achData.isOnfidoSetupComplete is truthy). That skip logic is byte-identical to production, so this is almost certainly a runtime data/state issue rather than a new bug in the flow file — a plain revert of #95946 will not fix it.
Assigned: No change. No causing PR reached medium confidence, so no new assignees were added. cc @rinej@arosiclair@dukenv0307 (already auto-assigned) — see the direction below. Labels: No change. DeployBlockerCash is kept (staging-only App deploy blocker; not reproducible on production, and a contributing App PR cannot be excluded).
📋 Detailed Analysis
Root Cause
The USD VBBA setup flow renders steps in this order (USDVerifiedBankAccountFlowPage.tsx): COUNTRY → BANK_ACCOUNT → REQUESTOR (personal info) → VERIFY_IDENTITY → COMPANY → …. Landing on Company info right after the personal-info Confirmation means VERIFY_IDENTITY was skipped. There are two places that skip it, both keyed off the same value, achData.isOnfidoSetupComplete:
For a brand-new account going through the manual flow, isOnfidoSetupComplete should be falsy, so Verify identity should render. The fact that it is being skipped means achData.isOnfidoSetupComplete is truthy at that point.
isOnfidoSetupComplete is not set optimistically by the client for this step — updatePersonalInformationForBankAccount uses getVBBADataForOnyx(...), which never writes that field (getVBBADataForOnyx L356). The only client write is updateReimbursementAccountDraft({isOnfidoSetupComplete: true}) inside VerifyIdentityafter Onfido succeeds, and that writes to the form draft, not to achData. So the value that drives the skip comes back in the API response for the Requestor/confirm step.
Most likely directions (to be confirmed):
(Medium) Backend regression: the UpdatePersonalInformationForBankAccount (confirm) response is returning isOnfidoSetupComplete: true for a fresh manual VBBA account when it shouldn't, causing both skip paths to fire.
(Low) A client-side stale-state issue (e.g. achData retaining isOnfidoSetupComplete from prior state), though the repro starts from a brand-new account with no prior bank account, which argues against this.
A robust client-side hardening (independent of the root cause) would be to gate the skip on more than the draft-derived flag — e.g. also require that Onfido was actually completed for the current account — but the primary fix should target whatever is making the flag truthy.
#95946 is auto-linked only because this bug was found while QA-testing its ad-hoc build (an ad-hoc build is main + the PR, so it also contains every other PR already on main). Its only change to the VBBA flow is the addition of getSubPageForNavigation (L104-L115), which only rewrites the subPage URL param when navigating to the BANK_ACCOUNT page so it renders the manual vs Plaid variant. It does not touch:
the page param (which alone determines which step renders),
the pages array ordering,
the shouldSkipVerifyIdentity logic, or
isOnfidoSetupComplete.
The transition in this bug is REQUESTOR → VERIFY_IDENTITY, for which getSubPageForNavigation returns the unchanged fallback. It cannot cause the flow to land on COMPANY.
Verification
The affected step-ordering + skip logic file is src/pages/ReimbursementAccount/USD/USDVerifiedBankAccountFlowPage.tsx.
I compared this file between the current staging tip and a pre-9.4.48 commit (5e32a4401): the pages array order and shouldSkipVerifyIdentity are byte-identical. Since this exact code ships in production (9.4.47) where the bug does not reproduce, the frontend skip logic is not itself a new regression.
Because the differentiating factor between staging and production appears to be runtime achData data rather than any changed frontend code I could identify, and no causing PR could be confirmed, this needs a targeted look by the VBBA owners (ideally confirming the UpdatePersonalInformationForBankAccount response payload for a fresh manual account on staging vs production).
Activity
applause-bot commentedon Aug 3, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/2f657d67059c0c5bf9bb67d259a90871f2e3150e6a9f6982d846705a73b9489d
melvin-bot commentedon Aug 3, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #95946
melvin-bot commentedon Aug 3, 2026
@arosiclair @dukenv0307 you have been assigned to this deploy blocker because you reviewed the offending PR: #95946
melvin-bot commentedon Aug 3, 2026
@rinej you have been assigned to this deploy blocker because you authored the offending PR: #95946
melvin-bot commentedon Aug 3, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 3, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]Pay with BA-Verify identity page is not shown after confirming personal details[/-][+]Pay with BA - Verify identity page is not shown after confirming personal details[/+]jponikarchuk commentedon Aug 3, 2026
The issue is not reproducible when
Use Staging Serveris disablerdMelvinBot commentedon Aug 3, 2026
🔍 Investigation Summary
Classification: Unclear (frontend vs backend not yet confirmed) — leaning backend/data-state
Causing PR: Not confirmed. #95946 - "Migrate Add Personal Bank Account flow from useSubStep to useSubPage" by @rinej (auto-assigned) is ruled out with high confidence as the cause of this symptom (see below).
Related Issues: N/A
Recommendation: NEEDS INVESTIGATION
The Verify identity step is skipped because the flow believes Onfido is already complete (
achData.isOnfidoSetupCompleteis truthy). That skip logic is byte-identical to production, so this is almost certainly a runtime data/state issue rather than a new bug in the flow file — a plain revert of #95946 will not fix it.Assigned: No change. No causing PR reached medium confidence, so no new assignees were added. cc @rinej @arosiclair @dukenv0307 (already auto-assigned) — see the direction below.
Labels: No change.
DeployBlockerCashis kept (staging-only App deploy blocker; not reproducible on production, and a contributing App PR cannot be excluded).📋 Detailed Analysis
Root Cause
The USD VBBA setup flow renders steps in this order (
USDVerifiedBankAccountFlowPage.tsx):COUNTRY → BANK_ACCOUNT → REQUESTOR (personal info) → VERIFY_IDENTITY → COMPANY → …. Landing on Company info right after the personal-info Confirmation meansVERIFY_IDENTITYwas skipped. There are two places that skip it, both keyed off the same value,achData.isOnfidoSetupComplete:onSubmit:shouldSkipVerifyIdentity(L99)onSubmitadvance/skip (L117-L131)VerifyIdentityskips on mount whenisOnfidoSetupComplete(L42, L46-L51)For a brand-new account going through the manual flow,
isOnfidoSetupCompleteshould be falsy, so Verify identity should render. The fact that it is being skipped meansachData.isOnfidoSetupCompleteis truthy at that point.isOnfidoSetupCompleteis not set optimistically by the client for this step —updatePersonalInformationForBankAccountusesgetVBBADataForOnyx(...), which never writes that field (getVBBADataForOnyxL356). The only client write isupdateReimbursementAccountDraft({isOnfidoSetupComplete: true})insideVerifyIdentityafter Onfido succeeds, and that writes to the form draft, not toachData. So the value that drives the skip comes back in the API response for the Requestor/confirm step.Most likely directions (to be confirmed):
UpdatePersonalInformationForBankAccount(confirm) response is returningisOnfidoSetupComplete: truefor a fresh manual VBBA account when it shouldn't, causing both skip paths to fire.achDataretainingisOnfidoSetupCompletefrom prior state), though the repro starts from a brand-new account with no prior bank account, which argues against this.A robust client-side hardening (independent of the root cause) would be to gate the skip on more than the draft-derived flag — e.g. also require that Onfido was actually completed for the current account — but the primary fix should target whatever is making the flag truthy.
Why PR #95946 is ruled out (high confidence)
#95946 is auto-linked only because this bug was found while QA-testing its ad-hoc build (an ad-hoc build is
main+ the PR, so it also contains every other PR already onmain). Its only change to the VBBA flow is the addition ofgetSubPageForNavigation(L104-L115), which only rewrites thesubPageURL param when navigating to theBANK_ACCOUNTpage so it renders the manual vs Plaid variant. It does not touch:pageparam (which alone determines which step renders),pagesarray ordering,shouldSkipVerifyIdentitylogic, orisOnfidoSetupComplete.The transition in this bug is
REQUESTOR → VERIFY_IDENTITY, for whichgetSubPageForNavigationreturns the unchanged fallback. It cannot cause the flow to land onCOMPANY.Verification
src/pages/ReimbursementAccount/USD/USDVerifiedBankAccountFlowPage.tsx.5e32a4401): thepagesarray order andshouldSkipVerifyIdentityare byte-identical. Since this exact code ships in production (9.4.47) where the bug does not reproduce, the frontend skip logic is not itself a new regression.achDatapath: EnterSignerInfo flow refactor #96321 (NonUSD EnterSignerInfo), Fix losing in-progress bank account when backing out of change flow #96739 (change-bank-account backup/restore — only triggers when an existingbankAccountIDis present), 83857 migrate search bank new task v3 #97314 (route migration).Because the differentiating factor between staging and production appears to be runtime
achDatadata rather than any changed frontend code I could identify, and no causing PR could be confirmed, this needs a targeted look by the VBBA owners (ideally confirming theUpdatePersonalInformationForBankAccountresponse payload for a fresh manual account on staging vs production).arosiclair commentedon Aug 3, 2026
@jponikarchuk it's expected to skip the Onfido verification step when using the test Alberta Bobbeth credentials