Skip to content

[Due for payment 2026-11-20] [$175] [Intl] Map: Switch Mapbox map language to the user's preferred app locale #97752

Open

Description

@melvin-bot

Problem

When a user changes the app language, the Mapbox map does not appear to update its language along with it. Map labels (place names, roads, etc.) stay in the default language instead of following the locale the user selected in the app.

Expected behavior

The Mapbox map should render its labels in the user's preferred locale — i.e. when the app language changes, the map language should change to match.

Notes

  • Surfaced while working on translated screenshots.
  • Mapbox supports setting the map's language; we should wire our selected app locale into the Mapbox map component so the two stay in sync.

Reported in Slack.

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. changed the title [-]Map: Switch Mapbox map language to the user's preferred app locale[/-] [+][Intl] Map: Switch Mapbox map language to the user's preferred app locale[/+] on Aug 12, 2026
  2. roryabraham commented on Aug 13, 2026

    @roryabraham
    Contributor

    No update

  3. roryabraham commented on Aug 24, 2026

    @roryabraham
    Contributor

    No update. Going to make this external

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 24, 2026
  5. melvin-bot commented on Aug 24, 2026

    @melvin-bot
    Author

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @linhvovan29546 (External)

  6. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 24, 2026
  7. 77 remaining items

  8. changed the title [-][$175] [Intl] Map: Switch Mapbox map language to the user's preferred app locale[/-] [+][Due for payment 2026-11-20] [$175] [Intl] Map: Switch Mapbox map language to the user's preferred app locale[/+] on Nov 13, 2026
  9. melvin-bot commented on Nov 13, 2026

    @melvin-bot
    Author

    @linhvovan29546

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.37-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-20. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  10. linhvovan29546 commented on Nov 13, 2026

    @linhvovan29546
    Contributor

    BugZero Checklist

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A - Result of the original design, the Mapbox map never had any language handling, so no PR introduced the bug.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    1. Open App > Settings > Preferences > Language and select Japanese
    2. Tap the green FAB (+) and select Track expense
    3. Open the Distance tab
    4. Add a start and a stop waypoint
    5. Verify the map loads, shows both markers, and draws the route
    6. Zoom out until country and city names show
    7. Go to Settings > Preferences > Language and select Spanish
    8. Repeat steps 2 to 6
    9. Verify that the map labels (for example country and city names) are shown in Spanish

    Do we agree 👍 or 👎.

  11. linhvovan29546 commented on Nov 17, 2026

    @linhvovan29546
    Contributor

    Price increase request

    Mandatory

    Proposed amount: $500 (I was assigned to this issue before 2026-09-19)

    Why the work exceeded the issue:. Native testing showed that nl/pl/el can't be supported through the @rnmapbox/maps API the app uses, because Mapbox's old localizeLabels API rejects those locales. The fix had to go upstream. I opened rnmapbox/maps#4327 (merged 2026-10-11) and worked with the maintainer, who split out Mapbox.setLanguage as #4331. That work was in a third-party repo and went beyond a normal review of the App PRs.

    Regressions caused by this PR: None. The map never had language handling, and #106718 was confirmed as not a regression.

    Optional

    Scope expansion: Worldview on web, the Mapbox Studio style change, and the upstream rnmapbox contribution.

    Test coverage: Manual verification of all 11 locales on iOS and Android.

    Multiple PRs: #99304 and #106598 , plus upstream rnmapbox/maps#4327.

  12. roryabraham commented on Nov 17, 2026

    @roryabraham
    Contributor

    @linhvovan29546 👍🏼 to $500 for the reasons you stated

  13. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  14. expensify-chore-bot commented on Nov 19, 2026

    @expensify-chore-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions