Skip to content

[Due for payment 2026-08-12] Product Window - Product marketing window reappears briefly when returning from copilot. #97834

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.50-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #96141
Email or phone of affected tester (no customers): ibellicotest+2766@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11 / Chrome
App Component: User Settings

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Sign in with an account that is admin of a workspace.
  3. Verify the product-marketing window appears at the bottom-right.
  4. Dismiss it.
  5. Navigate to "Account" > "Agents" > Create a new agent.
  6. Click on switch on top of "Account" page and switch to agent´s account.
  7. Return to own account.
  8. Note that product marketing window reappears briefly.

Expected Result:

Product marketing window shouldn´t reappear after being dismissed.

Actual Result:

Product marketing window reappears briefly everyitime that user returns from copilot account.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7225970_1785881131364.Product.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7225970

Issue OwnerCurrent Issue Owner: @huult

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 4, 2026
  2. applause-bot commented on Aug 4, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/1da560758b70e11f1a9f9a0e3516431ffb00f130017ea19e5aa29d257ab909fa

  3. melvin-bot commented on Aug 4, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #96141

  4. melvin-bot commented on Aug 4, 2026

    @melvin-bot

    @JS00001 @huult you have been assigned to this deploy blocker because you reviewed the offending PR: #96141

  5. melvin-bot commented on Aug 4, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Aug 4, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. MelvinBot commented on Aug 4, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #96141 - "Add persistent bottom-right product marketing window" by @KJ21-ENG (High confidence)
    Related Issues: #95791 (feature request implemented by the PR)

    Recommendation: ROLL FORWARD

    This is a narrow, transient cosmetic flash on the copilot-return flow of a brand-new feature that does not exist in production; a targeted guard fix is far simpler and lower-risk than reverting a large, heavily-reviewed feature PR that touches ~45 files. (Given the severity — a brief flash on an edge-case flow — DEMOTE would also be reasonable if the team prefers not to hold the deploy.)

    Assigned: @KJ21-ENG (PR author), @huult and @JS00001 (approving reviewers) from #96141
    Labels: No changes. Kept DeployBlockerCash (App deploy blocker for a frontend bug); no DeployBlocker label was present.

    📋 Detailed Analysis

    Evidence

    • PR Add persistent bottom-right product marketing window #96141 introduced the entire ProductMarketingWindow feature, including the manager that decides visibility (src/components/ProductMarketingWindow/ProductMarketingWindowManager.tsx), the utils (src/libs/ProductMarketingWindowUtils.ts), the nvp_lastDismissedMarketingWindow NVP key, and the mount in RootNavigatorExtraContent. Confirmed via gh pr view 96141 --json files.
    • Dismissal is persisted at account level in the nvp_lastDismissedMarketingWindow NVP via SetNameValuePair (per the PR body and persistDismissal).
    • The bug is reproducible in staging only; the feature does not exist in production (new feature), so this is inherently a staging-only regression of PR Add persistent bottom-right product marketing window #96141.

    Verification

    Root Cause

    When the copilot/delegate session ends and the user returns to their own account, restoreDelegateSession calls clearOnyxForDelegateTransition, which wipes account-scoped Onyx (including ACCOUNT and nvp_lastDismissedMarketingWindow), seeds IS_LOADING_APP=true, and runs openApp to re-fetch the account payload.

    The window's guard hides the window while isLoadingApp is true or the tracked Onyx values are still loading (manager#L70-L74). The flash occurs because there is a brief interval during re-hydration where:

    1. isActingAsDelegate has already flipped to false (the ACCOUNT delegate flag was cleared),
    2. the admin policies have re-hydrated and IS_LOADING_APP has been cleared to false (getOnyxDataForOpenOrReconnect finallyData#L357-L370), but
    3. the nvp_lastDismissedMarketingWindow value has not yet been re-applied.

    In that window getProductMarketingAnnouncementVariant sees lastDismissedMarketingWindow === undefined, treats the July 2026 announcement as not dismissed, and renders the window — until the NVP lands and hides it again. The underlying design smell is that absence of the dismissal NVP is interpreted as "show," so any transient moment where the account payload is only partially re-hydrated produces a false positive. On a cold start this is masked because IS_LOADING_APP defaults to true until the full payload arrives; the delegate transition re-hydrates account data incrementally after the loading gate is cleared, exposing the gap.

    Suggested fix direction (for the assignees)

    Do not treat an absent NVP as "not dismissed" while the account payload is still settling. Concretely, gate rendering on the account NVP data being positively present after re-hydration — e.g. require ACCOUNT (which is cleared and repopulated by the same openApp that carries the NVP) to be present before rendering, rather than relying on IS_LOADING_APP alone. This keeps the window hidden until the dismissal NVP has re-landed, eliminating the flash without changing dismissal semantics.

  8. huult commented on Aug 5, 2026

    @huult
    Contributor

    @KJ21-ENG Could you check this bug?

  9. KJ21-ENG commented on Aug 5, 2026

    @KJ21-ENG
    Contributor

    On it

  10. JS00001 commented on Aug 5, 2026

    @JS00001
    Contributor

    Lets fix this one

  11. melvin-bot commented on Aug 5, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. KJ21-ENG commented on Aug 5, 2026

    @KJ21-ENG
    Contributor

    @JS00001 Handle it here.

  13. added and removed
    ReviewingHas a PR in review
    on Aug 5, 2026
  14. changed the title [-]Product Window - Product marketing window reappears briefly when returning from copilot.[/-] [+][Due for payment 2026-08-12] Product Window - Product marketing window reappears briefly when returning from copilot.[/+] on Aug 5, 2026
  15. melvin-bot commented on Aug 5, 2026

    @melvin-bot

    @huult

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.50-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-12. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions