You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-12] Product Window - Product marketing window reappears briefly when returning from copilot. #97834
Version Number: 9.4.50-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#96141 Email or phone of affected tester (no customers):ibellicotest+2766@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Windows 11 / Chrome App Component: User Settings
Action Performed:
Open the staging.new.expensify.com website.
Sign in with an account that is admin of a workspace.
Verify the product-marketing window appears at the bottom-right.
Dismiss it.
Navigate to "Account" > "Agents" > Create a new agent.
Click on switch on top of "Account" page and switch to agent´s account.
Return to own account.
Note that product marketing window reappears briefly.
Expected Result:
Product marketing window shouldn´t reappear after being dismissed.
Actual Result:
Product marketing window reappears briefly everyitime that user returns from copilot account.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #96141 - "Add persistent bottom-right product marketing window" by @KJ21-ENG (High confidence) Related Issues: #95791 (feature request implemented by the PR)
Recommendation: ROLL FORWARD
This is a narrow, transient cosmetic flash on the copilot-return flow of a brand-new feature that does not exist in production; a targeted guard fix is far simpler and lower-risk than reverting a large, heavily-reviewed feature PR that touches ~45 files. (Given the severity — a brief flash on an edge-case flow — DEMOTE would also be reasonable if the team prefers not to hold the deploy.)
Assigned: @KJ21-ENG (PR author), @huult and @JS00001 (approving reviewers) from #96141 Labels: No changes. Kept DeployBlockerCash (App deploy blocker for a frontend bug); no DeployBlocker label was present.
📋 Detailed Analysis
Evidence
PR Add persistent bottom-right product marketing window #96141 introduced the entire ProductMarketingWindow feature, including the manager that decides visibility (src/components/ProductMarketingWindow/ProductMarketingWindowManager.tsx), the utils (src/libs/ProductMarketingWindowUtils.ts), the nvp_lastDismissedMarketingWindow NVP key, and the mount in RootNavigatorExtraContent. Confirmed via gh pr view 96141 --json files.
Dismissal is persisted at account level in the nvp_lastDismissedMarketingWindow NVP via SetNameValuePair (per the PR body and persistDismissal).
Dismissed/shown computation: ProductMarketingWindowUtils.ts#L69-L86 — isProductMarketingAnnouncementDismissed returns true only when announcement.updateKey === lastDismissedMarketingWindow, so an absent NVP is treated as "not dismissed" → show.
Confirmed neither NVP_LAST_DISMISSED_MARKETING_WINDOW nor ACCOUNT is in KEYS_TO_PRESERVE_DELEGATE_ACCESS#L33-L52, so both are wiped on the transition and re-fetched by openApp.
Root Cause
When the copilot/delegate session ends and the user returns to their own account, restoreDelegateSession calls clearOnyxForDelegateTransition, which wipes account-scoped Onyx (including ACCOUNT and nvp_lastDismissedMarketingWindow), seeds IS_LOADING_APP=true, and runs openApp to re-fetch the account payload.
The window's guard hides the window while isLoadingApp is true or the tracked Onyx values are still loading (manager#L70-L74). The flash occurs because there is a brief interval during re-hydration where:
isActingAsDelegate has already flipped to false (the ACCOUNT delegate flag was cleared),
the nvp_lastDismissedMarketingWindow value has not yet been re-applied.
In that window getProductMarketingAnnouncementVariant sees lastDismissedMarketingWindow === undefined, treats the July 2026 announcement as not dismissed, and renders the window — until the NVP lands and hides it again. The underlying design smell is that absence of the dismissal NVP is interpreted as "show," so any transient moment where the account payload is only partially re-hydrated produces a false positive. On a cold start this is masked because IS_LOADING_APP defaults to true until the full payload arrives; the delegate transition re-hydrates account data incrementally after the loading gate is cleared, exposing the gap.
Suggested fix direction (for the assignees)
Do not treat an absent NVP as "not dismissed" while the account payload is still settling. Concretely, gate rendering on the account NVP data being positively present after re-hydration — e.g. require ACCOUNT (which is cleared and repopulated by the same openApp that carries the NVP) to be present before rendering, rather than relying on IS_LOADING_APP alone. This keeps the window hidden until the dismissal NVP has re-landed, eliminating the flash without changing dismissal semantics.
changed the title [-]Product Window - Product marketing window reappears briefly when returning from copilot.[/-][+][Due for payment 2026-08-12] Product Window - Product marketing window reappears briefly when returning from copilot.[/+]on Aug 5, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.50-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-12. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Aug 4, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/1da560758b70e11f1a9f9a0e3516431ffb00f130017ea19e5aa29d257ab909fa
melvin-bot commentedon Aug 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #96141
melvin-bot commentedon Aug 4, 2026
@JS00001 @huult you have been assigned to this deploy blocker because you reviewed the offending PR: #96141
melvin-bot commentedon Aug 4, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 4, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Aug 4, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #96141 - "Add persistent bottom-right product marketing window" by @KJ21-ENG (High confidence)
Related Issues: #95791 (feature request implemented by the PR)
Recommendation: ROLL FORWARD
This is a narrow, transient cosmetic flash on the copilot-return flow of a brand-new feature that does not exist in production; a targeted guard fix is far simpler and lower-risk than reverting a large, heavily-reviewed feature PR that touches ~45 files. (Given the severity — a brief flash on an edge-case flow — DEMOTE would also be reasonable if the team prefers not to hold the deploy.)
Assigned: @KJ21-ENG (PR author), @huult and @JS00001 (approving reviewers) from #96141
Labels: No changes. Kept
DeployBlockerCash(App deploy blocker for a frontend bug); noDeployBlockerlabel was present.📋 Detailed Analysis
Evidence
ProductMarketingWindowfeature, including the manager that decides visibility (src/components/ProductMarketingWindow/ProductMarketingWindowManager.tsx), the utils (src/libs/ProductMarketingWindowUtils.ts), thenvp_lastDismissedMarketingWindowNVP key, and the mount inRootNavigatorExtraContent. Confirmed viagh pr view 96141 --json files.nvp_lastDismissedMarketingWindowNVP viaSetNameValuePair(per the PR body andpersistDismissal).Verification
ProductMarketingWindowManager.tsx#L58-L74— reads the dismissal NVP and computes the show/hide guard.ProductMarketingWindowUtils.ts#L69-L86—isProductMarketingAnnouncementDismissedreturnstrueonly whenannouncement.updateKey === lastDismissedMarketingWindow, so an absent NVP is treated as "not dismissed" → show.Delegate.tsrestoreDelegateSession#L816-L847 →clearOnyxForDelegateTransition#L62-L66 →openApp().NVP_LAST_DISMISSED_MARKETING_WINDOWnorACCOUNTis inKEYS_TO_PRESERVE_DELEGATE_ACCESS#L33-L52, so both are wiped on the transition and re-fetched byopenApp.Root Cause
When the copilot/delegate session ends and the user returns to their own account,
restoreDelegateSessioncallsclearOnyxForDelegateTransition, which wipes account-scoped Onyx (includingACCOUNTandnvp_lastDismissedMarketingWindow), seedsIS_LOADING_APP=true, and runsopenAppto re-fetch the account payload.The window's guard hides the window while
isLoadingAppis true or the tracked Onyx values are still loading (manager#L70-L74). The flash occurs because there is a brief interval during re-hydration where:isActingAsDelegatehas already flipped tofalse(theACCOUNTdelegate flag was cleared),IS_LOADING_APPhas been cleared tofalse(getOnyxDataForOpenOrReconnectfinallyData#L357-L370), butnvp_lastDismissedMarketingWindowvalue has not yet been re-applied.In that window
getProductMarketingAnnouncementVariantseeslastDismissedMarketingWindow === undefined, treats the July 2026 announcement as not dismissed, and renders the window — until the NVP lands and hides it again. The underlying design smell is that absence of the dismissal NVP is interpreted as "show," so any transient moment where the account payload is only partially re-hydrated produces a false positive. On a cold start this is masked becauseIS_LOADING_APPdefaults totrueuntil the full payload arrives; the delegate transition re-hydrates account data incrementally after the loading gate is cleared, exposing the gap.Suggested fix direction (for the assignees)
Do not treat an absent NVP as "not dismissed" while the account payload is still settling. Concretely, gate rendering on the account NVP data being positively present after re-hydration — e.g. require
ACCOUNT(which is cleared and repopulated by the sameopenAppthat carries the NVP) to be present before rendering, rather than relying onIS_LOADING_APPalone. This keeps the window hidden until the dismissal NVP has re-landed, eliminating the flash without changing dismissal semantics.huult commentedon Aug 5, 2026
@KJ21-ENG Could you check this bug?
KJ21-ENG commentedon Aug 5, 2026
On it
JS00001 commentedon Aug 5, 2026
Lets fix this one
melvin-bot commentedon Aug 5, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
KJ21-ENG commentedon Aug 5, 2026
@JS00001 Handle it here.
[-]Product Window - Product marketing window reappears briefly when returning from copilot.[/-][+][Due for payment 2026-08-12] Product Window - Product marketing window reappears briefly when returning from copilot.[/+]melvin-bot commentedon Aug 5, 2026
@huult
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.50-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-12. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]