You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Context menu and search router appear on top of product-marketing window #97837
Version Number: 9.4.50-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#96141 Email or phone of affected tester (no customers):sdsiodjnosdjiodsj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Create a new account.
Create a workspace.
Go to workspace chat.
Send a message.
Right click on the message near product-marketing window.
Open search.
Expected Result:
Product-marketing window should always be on top of all pop-ups.
Actual Result:
Context menu and search router appear on top of product-marketing window.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #96141 - "Add persistent bottom-right product marketing window" by @KJ21-ENG (High confidence) Related Issues: #95791 (feature request implemented by the causing PR)
Recommendation: ROLL FORWARD
The product-marketing window is a brand-new, self-contained feature (not in production), and the existing "covering modal" mechanism it already ships makes this a small, targeted fix that is safer and less disruptive than reverting ~48 files (component, translations, tests). A clean revert of #96141 is a reasonable fallback if a fix cannot land quickly.
Assigned: @KJ21-ENG (PR author), @JS00001 and @huult (approving reviewers) from the causing PR Labels: No changes. This is a frontend bug, so DeployBlockerCash (App deploy blocker) is correctly retained. No DeployBlocker label was present.
📋 Detailed Analysis
Evidence
The bug is entirely about the "product-marketing window," a UI element that did not exist before PR Add persistent bottom-right product marketing window #96141. The PR's title and description are literally "Add persistent bottom-right product marketing window," and it introduces src/components/ProductMarketingWindow/*. The issue is N/A - new feature, doesn't exist in prod, matching a staging-only regression from this release.
The reported symptom (context menu and the search router rendering on top of the window) is a z-index / stacking-order interaction between the new persistent window and existing popovers, i.e. exactly the layering concern the PR tried to handle ("Ordinary popovers and route-backed right-docked navigation do not unnecessarily hide it").
Verification
Affected code, all introduced/modified by #96141 (permalinks at commit 4331690fa52747430c10878ed51139476c0c4758):
On a wide layout (the reported MacOS/Chrome case) the search router itself is a POPOVER: SearchRouterModal/index.tsx#L39. The right-click context menu is likewise a POPOVER.
Root Cause
The persistent window and the popovers it competes with share the same stacking value, modalBaseZIndex (9999). Because the window is a POPOVER-exempt overlay, it is not hidden when a popover opens; and because its zIndex merely equals (does not exceed) the popover z-index, stacking falls back to DOM insertion order. The window is mounted persistently and first, so any popover opened afterwards (right-click context menu, and the search router, both MODAL_TYPE.POPOVER on wide screens) is inserted later in document.body and paints on top of it. The style comment claims the window sits "above route-backed side panels," but it never rises above the base modal layer used by actively-opened popovers, producing the reported overlap.
Suggested fix (roll forward)
Decide the intended layering and make it explicit rather than relying on equal z-index + DOM order. Either:
Treat the context-menu popover and the search router as covering (reuse the existing shouldTreatModalAsCovering / setModalCovering path) so the window hides while they are open, or
Anchor the window strictly below the base modal layer (a z-index below modalBaseZIndex) so opened popovers/search always paint above it deterministically.
Option 1 matches the PR's stated "covering modals suppress it" design; option 2 is the minimal change if the window should simply always sit behind interactive popovers.
Activity
applause-bot commentedon Aug 4, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/f8559edc22b09ab737df8d197842c52eaacf6d8e1ea954914f731a54da9f0aa5
melvin-bot commentedon Aug 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #96141
melvin-bot commentedon Aug 4, 2026
@JS00001 @huult you have been assigned to this deploy blocker because you reviewed the offending PR: #96141
melvin-bot commentedon Aug 4, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 4, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Aug 4, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #96141 - "Add persistent bottom-right product marketing window" by @KJ21-ENG (High confidence)
Related Issues: #95791 (feature request implemented by the causing PR)
Recommendation: ROLL FORWARD
The product-marketing window is a brand-new, self-contained feature (not in production), and the existing "covering modal" mechanism it already ships makes this a small, targeted fix that is safer and less disruptive than reverting ~48 files (component, translations, tests). A clean revert of #96141 is a reasonable fallback if a fix cannot land quickly.
Assigned: @KJ21-ENG (PR author), @JS00001 and @huult (approving reviewers) from the causing PR
Labels: No changes. This is a frontend bug, so
DeployBlockerCash(App deploy blocker) is correctly retained. NoDeployBlockerlabel was present.📋 Detailed Analysis
Evidence
src/components/ProductMarketingWindow/*. The issue isN/A - new feature, doesn't exist in prod, matching a staging-only regression from this release.Verification
Affected code, all introduced/modified by #96141 (permalinks at commit
4331690fa52747430c10878ed51139476c0c4758):document.body:ProductMarketingWindowPortal.tsxzIndex: variables.modalBaseZIndex:src/styles/index.ts#L1187-L1192modalBaseZIndex:ModalStyleUtils.ts#L80POPOVER(andBOTTOM_DOCKED):BaseModal.tsx#L102which drivessetModalCovering→RAM_ONLY_IS_PRODUCT_MARKETING_WINDOW_COVERED, consumed byProductMarketingWindowManager.tsx.POPOVER:SearchRouterModal/index.tsx#L39. The right-click context menu is likewise aPOPOVER.Root Cause
The persistent window and the popovers it competes with share the same stacking value,
modalBaseZIndex(9999). Because the window is aPOPOVER-exempt overlay, it is not hidden when a popover opens; and because itszIndexmerely equals (does not exceed) the popover z-index, stacking falls back to DOM insertion order. The window is mounted persistently and first, so any popover opened afterwards (right-click context menu, and the search router, bothMODAL_TYPE.POPOVERon wide screens) is inserted later indocument.bodyand paints on top of it. The style comment claims the window sits "above route-backed side panels," but it never rises above the base modal layer used by actively-opened popovers, producing the reported overlap.Suggested fix (roll forward)
Decide the intended layering and make it explicit rather than relying on equal z-index + DOM order. Either:
shouldTreatModalAsCovering/setModalCoveringpath) so the window hides while they are open, ormodalBaseZIndex) so opened popovers/search always paint above it deterministically.Option 1 matches the PR's stated "covering modals suppress it" design; option 2 is the minimal change if the window should simply always sit behind interactive popovers.
KJ21-ENG commentedon Aug 4, 2026
This is not a regression. It is the intended hierarchy.
modalBaseZIndex = 9999.popoverZIndex = 10000.MODAL_TYPE.POPOVER.Correct me if I am wrong and missing something over here.
cc: @JS00001 @huult
huult commentedon Aug 5, 2026
#96141 (comment)
#96141 (comment)
@JS00001 I noticed this during PR testing, and we asked Design to confirm the expected behavior. They confirmed it, so this ticket is not a bug.
JS00001 commentedon Aug 5, 2026
Yeah this seems fine to me