You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-29] Feature Request / UX Improvement: Remove unnecessary "Send attachment" screen when adding attachments from the "+" menu on iOS #98049
Version Number: 9.4.51.1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@brianlee-expensify Slack conversation (hyperlinked to channel name): #Expensify Bugs
Action Performed:
Open the iOS app.
Create or open an expense.
On the individual expense page, tap the "+" button to the left of the composer.
Tap Add attachment > Take photo.
Take a photo and tap Use Photo.
Observe the flow.
Expected Result:
After tapping Use Photo, the attachment should be added immediately, matching the behavior when adding an attachment from the Add attachment button on the receipt image.
The "Send attachment" screen should not be shown.
Actual Result:
After tapping Use Photo, the user is taken to an additional "Send attachment" screen before the attachment is added.
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
@brianlee-expensify is anything needed from Design here? I guess you are suggesting that we just kill this screen here, right?
And that we would just post it as soon as you said "use photo" from the screen before? I think we just need to see how that works on other platforms (Android, mWeb, etc) to make sure they all can advance, but I think it should be good. cc @Expensify/design for viz
@MelvinBot what are the proposed changes you'd make to the code to remove the "Send attachment" step when adding attachments from the "+" menu on the iOS app?
Skip the REPORT_ADD_ATTACHMENT modal for the composer "+" → Add attachment flow and send the file the moment file validation succeeds — the exact same mechanism the on‑receipt Add attachment button already uses.
One-line change in useAttachmentPicker.ts:41: replace the setCurrentAttachment(...) + Navigation.navigate(REPORT_ADD_ATTACHMENT) block with a direct call to the already-defined addAttachment(files):
addAttachment (useAttachmentPicker.ts:28) already stashes the file and calls clearComposer(), which triggers validateAndSubmitDraft → addAttachmentWithComment(...) (useComposerSubmit.ts:89). So the send path is unchanged — we just stop routing through the confirmation screen first. Any typed caption is still attached.
Why this is the right seam + evidence
Current flow: "+" menu → Add attachment (AttachmentPickerWithMenuItems.tsx:458) → pickAttachments → useFilesValidation → onFilesValidated, which stores the file in the attachment context with onConfirm: addAttachment and navigates to the REPORT_ADD_ATTACHMENT route. That route renders AttachmentModalBaseContent, and the Send button appears only becauseonConfirm is truthy — see AttachmentModalBaseContent/index.tsx:380 ({!!onConfirm && ... <Button ... text={translate('common.send')} .../>}). The "Send attachment" header comes from the reportActionCompose.sendAttachment key (en.ts:824).
The receipt button (the behavior we're matching):MoneyRequestReceiptView.tsx:707 runs the picked files through the same useFilesValidation, but its validated callback calls the send action directly — no context stash, no navigation, no onConfirm. That's the whole difference, so mirroring it in onFilesValidated is the minimal, consistent fix.
Points for the team to decide before implementing
Scope.onFilesValidated is shared by the "+" menu and paste (ComposerInput.tsx) and drag‑and‑drop (ComposerDropZone.tsx). Changing it unconditionally removes the confirmation for those entry points and on all platforms (web/Android too), not just iOS "+". Shawn already flagged wanting to confirm the flow on other platforms — if that consistency is desired, the one-liner is enough; if the confirmation should stay for paste/drag‑drop or non‑iOS, thread a flag from the caller instead.
Preview/rotate is lost. The modal currently lets users preview and (for PDFs) rotate before sending. Sending immediately drops that step — acceptable since the receipt flow has the same limitation, but worth a conscious call.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/98049#issuecomment-5259300415) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Activity
melvin-bot commentedon Aug 7, 2026
Triggered auto assignment to Design team member for new feature review - @shawnborton (
NewFeature)shawnborton commentedon Aug 8, 2026
@brianlee-expensify is anything needed from Design here? I guess you are suggesting that we just kill this screen here, right?
And that we would just post it as soon as you said "use photo" from the screen before? I think we just need to see how that works on other platforms (Android, mWeb, etc) to make sure they all can advance, but I think it should be good. cc @Expensify/design for viz
dannymcclain commentedon Aug 10, 2026
Makes sense to me. That final modal confirmation send screen does feel pretty redundant.
brianlee-expensify commentedon Aug 10, 2026
@shawnborton correct! the request here is to remove the "Send attachment" screen because it feels unnecessary
shawnborton commentedon Aug 11, 2026
That works for me. @brianlee-expensify can you take care of things from here?
brianlee-expensify commentedon Aug 11, 2026
@MelvinBot what are the proposed changes you'd make to the code to remove the "Send attachment" step when adding attachments from the "+" menu on the iOS app?
MelvinBot commentedon Aug 11, 2026
Proposed change
Skip the
REPORT_ADD_ATTACHMENTmodal for the composer "+" → Add attachment flow and send the file the moment file validation succeeds — the exact same mechanism the on‑receipt Add attachment button already uses.One-line change in
useAttachmentPicker.ts:41: replace thesetCurrentAttachment(...)+Navigation.navigate(REPORT_ADD_ATTACHMENT)block with a direct call to the already-definedaddAttachment(files):addAttachment(useAttachmentPicker.ts:28) already stashes the file and callsclearComposer(), which triggersvalidateAndSubmitDraft→addAttachmentWithComment(...)(useComposerSubmit.ts:89). So the send path is unchanged — we just stop routing through the confirmation screen first. Any typed caption is still attached.Why this is the right seam + evidence
Current flow: "+" menu → Add attachment (
AttachmentPickerWithMenuItems.tsx:458) →pickAttachments→useFilesValidation→onFilesValidated, which stores the file in the attachment context withonConfirm: addAttachmentand navigates to theREPORT_ADD_ATTACHMENTroute. That route rendersAttachmentModalBaseContent, and the Send button appears only becauseonConfirmis truthy — seeAttachmentModalBaseContent/index.tsx:380({!!onConfirm && ... <Button ... text={translate('common.send')} .../>}). The "Send attachment" header comes from thereportActionCompose.sendAttachmentkey (en.ts:824).The receipt button (the behavior we're matching):
MoneyRequestReceiptView.tsx:707runs the picked files through the sameuseFilesValidation, but its validated callback calls the send action directly — no context stash, no navigation, noonConfirm. That's the whole difference, so mirroring it inonFilesValidatedis the minimal, consistent fix.Points for the team to decide before implementing
onFilesValidatedis shared by the "+" menu and paste (ComposerInput.tsx) and drag‑and‑drop (ComposerDropZone.tsx). Changing it unconditionally removes the confirmation for those entry points and on all platforms (web/Android too), not just iOS "+". Shawn already flagged wanting to confirm the flow on other platforms — if that consistency is desired, the one-liner is enough; if the confirmation should stay for paste/drag‑drop or non‑iOS, thread a flag from the caller instead.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/98049#issuecomment-5259300415)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
brianlee-expensify commentedon Aug 11, 2026
posting to external-backend-contributors for review and PR
hungvu193 commentedon Aug 12, 2026
on it 👀
23 remaining items
daledah commentedon Aug 25, 2026
These 2 DBs are not related to our PR
This is expected
So our PR doesn't have any regressions
melvin-bot commentedon Aug 28, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 28, 2026
Payment Summary
Resolving PRs:
Skip preview modal for native platform when adding attachment #98528
Contributor: @hungvu193 does not require payment (Contractor)
Reviewer: @daledah owed $250 via NewDot
BugZero Checklist (@mallenexpensify)
melvin-bot commentedon Aug 31, 2026
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mallenexpensify commentedon Sep 1, 2026
Payment Summary
Contributor+: @daledah due $250 via NewDot
quinthar commentedon Sep 2, 2026
Approved @daledah for $250