Skip to content

[Due for payment 2026-08-29] Feature Request / UX Improvement: Remove unnecessary "Send attachment" screen when adding attachments from the "+" menu on iOS #98049

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.51.1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @brianlee-expensify
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

  1. Open the iOS app.
  2. Create or open an expense.
  3. On the individual expense page, tap the "+" button to the left of the composer.
  4. Tap Add attachment > Take photo.
  5. Take a photo and tap Use Photo.
  6. Observe the flow.

Expected Result:

After tapping Use Photo, the attachment should be added immediately, matching the behavior when adding an attachment from the Add attachment button on the receipt image.
The "Send attachment" screen should not be shown.

Actual Result:

After tapping Use Photo, the user is taken to an additional "Send attachment" screen before the attachment is added.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

ScreenRecording_08-06-2026.10-27-10_1.MP4
WhatsApp.Video.2026-08-07.at.11.39.33.AM.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Aug 7, 2026

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  2. shawnborton commented on Aug 8, 2026

    @shawnborton
    Contributor

    @brianlee-expensify is anything needed from Design here? I guess you are suggesting that we just kill this screen here, right?

    Image

    And that we would just post it as soon as you said "use photo" from the screen before? I think we just need to see how that works on other platforms (Android, mWeb, etc) to make sure they all can advance, but I think it should be good. cc @Expensify/design for viz

  3. dannymcclain commented on Aug 10, 2026

    @dannymcclain
    Contributor

    Makes sense to me. That final modal confirmation send screen does feel pretty redundant.

  4. brianlee-expensify commented on Aug 10, 2026

    @brianlee-expensify
    Contributor

    @shawnborton correct! the request here is to remove the "Send attachment" screen because it feels unnecessary

  5. shawnborton commented on Aug 11, 2026

    @shawnborton
    Contributor

    That works for me. @brianlee-expensify can you take care of things from here?

  6. brianlee-expensify commented on Aug 11, 2026

    @brianlee-expensify
    Contributor

    @MelvinBot what are the proposed changes you'd make to the code to remove the "Send attachment" step when adding attachments from the "+" menu on the iOS app?

  7. MelvinBot commented on Aug 11, 2026

    @MelvinBot
    Contributor

    Proposed change

    Skip the REPORT_ADD_ATTACHMENT modal for the composer "+" → Add attachment flow and send the file the moment file validation succeeds — the exact same mechanism the on‑receipt Add attachment button already uses.

    One-line change in useAttachmentPicker.ts:41: replace the setCurrentAttachment(...) + Navigation.navigate(REPORT_ADD_ATTACHMENT) block with a direct call to the already-defined addAttachment(files):

    const onFilesValidated = (files: FileObject[]) => {
        if (files.length === 0) {
            return;
        }
        addAttachment(files); // sets attachmentFileRef + clearComposer() → immediate send
    };

    addAttachment (useAttachmentPicker.ts:28) already stashes the file and calls clearComposer(), which triggers validateAndSubmitDraft → addAttachmentWithComment(...) (useComposerSubmit.ts:89). So the send path is unchanged — we just stop routing through the confirmation screen first. Any typed caption is still attached.

    Why this is the right seam + evidence

    Current flow: "+" menu → Add attachment (AttachmentPickerWithMenuItems.tsx:458) → pickAttachments → useFilesValidation → onFilesValidated, which stores the file in the attachment context with onConfirm: addAttachment and navigates to the REPORT_ADD_ATTACHMENT route. That route renders AttachmentModalBaseContent, and the Send button appears only because onConfirm is truthy — see AttachmentModalBaseContent/index.tsx:380 ({!!onConfirm && ... <Button ... text={translate('common.send')} .../>}). The "Send attachment" header comes from the reportActionCompose.sendAttachment key (en.ts:824).

    The receipt button (the behavior we're matching): MoneyRequestReceiptView.tsx:707 runs the picked files through the same useFilesValidation, but its validated callback calls the send action directly — no context stash, no navigation, no onConfirm. That's the whole difference, so mirroring it in onFilesValidated is the minimal, consistent fix.

    Points for the team to decide before implementing

    1. Scope. onFilesValidated is shared by the "+" menu and paste (ComposerInput.tsx) and drag‑and‑drop (ComposerDropZone.tsx). Changing it unconditionally removes the confirmation for those entry points and on all platforms (web/Android too), not just iOS "+". Shawn already flagged wanting to confirm the flow on other platforms — if that consistency is desired, the one-liner is enough; if the confirmation should stay for paste/drag‑drop or non‑iOS, thread a flag from the caller instead.
    2. Preview/rotate is lost. The modal currently lets users preview and (for PDFs) rotate before sending. Sending immediately drops that step — acceptable since the receipt flow has the same limitation, but worth a conscious call.

    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/98049#issuecomment-5259300415) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  8. brianlee-expensify commented on Aug 11, 2026

    @brianlee-expensify
    Contributor

    posting to external-backend-contributors for review and PR

  9. self-assigned this
    on Aug 11, 2026
  10. hungvu193 commented on Aug 12, 2026

    @hungvu193
    Contributor

    on it 👀

  11. 23 remaining items

  12. daledah commented on Aug 25, 2026

    @daledah
    Contributor

    #99135
    #99136

    These 2 DBs are not related to our PR

    #99141

    This is expected

    So our PR doesn't have any regressions

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 28, 2026
  14. melvin-bot commented on Aug 28, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  15. melvin-bot commented on Aug 28, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  16. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. mallenexpensify commented on Sep 1, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @daledah due $250 via NewDot

  18. quinthar commented on Sep 2, 2026

    @quinthar
    Contributor

    Approved @daledah for $250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions