You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-01] Search query values containing commas or quotes are not handled comprehensively #98374
Search query values are handled by two independent mechanisms, and each has a distinct defect. PR 97083 worked around both for the autocomplete-selection path only.
1. The query grammar has no escape syntax. A quoted value is parsed by simpleQuotedString (src/libs/SearchParser/baseRules.peggy), whose inner match excludes quote characters entirely — so a workspace:/in: value containing a quote (e.g. Acme "US",Inc) cannot be represented at all. Name filters (from:, to:, payer:, …) use nestedQuotedString, which tolerates embedded quotes via a closing-quote lookahead heuristic, not escaping. The PR works around this by stripping quotes from values (stripSearchValueQuotes), which is lossy.
2. Typed values are never resolved to IDs. Name→ID substitution (getQueryWithSubstitutions) only applies to entries in the substitution map, which is populated exclusively by autocomplete selection. A hand-typed workspace:"Acme, Inc" parses fine but submits the literal name as the policyID, returning "Nothing to show". This is a resolution gap, not a parsing gap — fixing the grammar alone does not fix it.
Related constraint: the comma is both a legal value character and the multi-value delimiter (columns:a,b), so comma-quoting had to be opt-in (sanitizeSearchValue(str, shouldQuoteComma)) — quoting is not uniform across the language.
Solution
Add escape syntax to the shared grammar (baseRules.peggy, consumed by both searchParser and autocompleteParser in lockstep) so any value round-trips under any filter key; must not break persisted queries (saved searches, q= URLs)
Resolve hand-typed workspace/room names to IDs at submit time when absent from the substitution map (needs a decision on duplicate names and case sensitivity)
Delete the getParsableSearchValue/stripSearchValueQuotes workarounds
@parasharrajat This is regarding the Regression test proposal
Can you clarify step 2, Workspace filter is not showing that workspace as selected. Step 4 is a pass. Is this expected?
Activity
Julesssss commentedon Aug 11, 2026
Hi @mukhrr would you be interested in working on a follow up to #97083?
mukhrr commentedon Aug 11, 2026
Sure! Thanks
mukhrr commentedon Aug 13, 2026
@Julesssss PR is ready. Let's get C+ (hopefully @parasharrajat) assigned to review. thanks
Julesssss commentedon Aug 15, 2026
Hey @parasharrajat just checking if you're interested in this C+ review, or else I can auto-assign
parasharrajat commentedon Aug 15, 2026
Sounds good.
11 remaining items
melvin-bot commentedon Aug 31, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 31, 2026
Payment Summary
Resolving PRs:
Escape search query values and resolve typed workspace names #98522
Reviewer: @parasharrajat owed $250 via NewDot
Reviewer: @mukhrr owed $250 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Sep 3, 2026
Payment Summary
Contributor: @mukhrr due $250 via NewDot
Contributor+: @parasharrajat due $250 via NewDot
m-natarajan commentedon Sep 8, 2026
@parasharrajat This is regarding the
Regression test proposalCan you clarify step 2, Workspace filter is not showing that workspace as selected. Step 4 is a pass. Is this expected?
Recording.3487.mp4
parasharrajat commentedon Sep 8, 2026
In this vid, you have not provided correct workspace name. You missed to add the closing
"flaviadefaria commentedon Sep 11, 2026
Approved: @mukhrr owed $250 via NewDot