Skip to content

[Due for payment 2026-08-21] Scan - Blank placeholder is shown briefly after uploading receipt #98561

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.53-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #97313
Email or phone of affected tester (no customers): sdsiodjnosdjiodsj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open FAB > Scan expense.
  3. Upload a receipt.

Expected Result:

No blank placeholder will be shown after uploading receipt.

Actual Result:

Blank placeholder is shown briefly after uploading receipt.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7232405_1786605391271.14.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7232405

Issue OwnerCurrent Issue Owner: @bernhardoj

Activity

  1. applause-bot commented on Aug 13, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/2c11e6e24aaf49b483c1d27e0fde2bba912ff53dd9e0b6e62bc85c9a5a8b5999

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 13, 2026
  3. melvin-bot commented on Aug 13, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #97313

  4. melvin-bot commented on Aug 13, 2026

    @melvin-bot

    @mountiny @thesahindia @joekaufmanexpensify you have been assigned to this deploy blocker because you reviewed the offending PR: #97313

  5. melvin-bot commented on Aug 13, 2026

    @melvin-bot

    @bernhardoj you have been assigned to this deploy blocker because you authored the offending PR: #97313

  6. melvin-bot commented on Aug 13, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Aug 13, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Aug 13, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #97313 - "Defer image loading and use original receipt image" by @bernhardoj (High confidence)
    Related Issues: #96999 (the issue #97313 was fixing)

    Recommendation: ROLL FORWARD

    The blank flash is caused by the intentional image-deferral gate added in #97313, which is a performance improvement that also fixes #96999 — a straight revert would reintroduce that issue and lose the improvement. A targeted fix to the deferral gate is simpler and safer than a full revert. (This is a brief cosmetic flash, not a functional break, so if a fix can't land quickly it is a reasonable DEMOTE candidate.)

    Assigned: @bernhardoj (PR author), @joekaufmanexpensify, @thesahindia, @mountiny (approving reviewers) from #97313
    Labels: No change. DeployBlockerCash kept (App deploy blocked, App PR caused it). No DeployBlocker label was present, so nothing to remove.

    📋 Detailed Analysis

    Evidence

    • The symptom ("blank placeholder shown briefly after uploading receipt") is a receipt-image rendering flash. PR Defer image loading and use original receipt image #97313 is entirely about receipt image rendering: it introduces a new DeferredImageWithLoading wrapper and reroutes ReceiptImage and ImageWithSizeCalculation (used by ReportActionItemImage) through it.
    • Defer image loading and use original receipt image #97313 is item 51 on the current StagingDeployCash checklist (Deploy Checklist: New Expensify 2026-08-12 #98463) and is still unchecked, so it is on staging but not yet in production — exactly matching "Reproducible in staging: Yes / production: No".
    • The Scan upload flow renders the receipt through ReportActionItemImage / ReceiptImage (e.g. src/components/MoneyRequestConfirmationListFooter/ConfirmationReceiptThumbnail.tsx and src/pages/iou/request/step/IOURequestStepScan/...), both of which now pass through DeferredImageWithLoading.

    Verification

    Root Cause

    DeferredImageWithLoading gates the actual image render on shouldRenderImage = useRunAfterTransitions(didScreenTransitionEnd). While that gate is closed it returns a blank, full-size <View> placeholder (lines 35–42) instead of the image. In the Scan flow the freshly-uploaded local receipt is displayed on a screen whose transition/useRunAfterTransitions gate is momentarily still closed, so the empty <View> is painted for one or more frames before the image mounts — the visible blank-placeholder flash.

    The component's own docstring assumes an "already settled" screen has didScreenTransitionEnd === true and mounts the image "on the very next render with no perceptible delay"; in the Scan upload path that assumption doesn't hold (the confirmation/preview surface is still transitioning or useRunAfterTransitions is still holding it back), producing the flash. A targeted fix should render the previous loading state (thumbnail + loading indicator via ImageWithLoading) instead of a fully blank View while deferring, or skip deferral for freshly-uploaded local receipts, rather than reverting the whole deferral optimization.

  9. mountiny commented on Aug 13, 2026

    @mountiny
    Contributor

    @bernhardoj can you check this as well?

  10. bernhardoj commented on Aug 13, 2026

    @bernhardoj
    Contributor

    Same root cause as #98559

  11. m-natarajan commented on Aug 13, 2026

    @m-natarajan

    Passed, Chrome / v9.4.53-4, Xiaomi Redmi Note 10 / Android 12

    Screenrecorder-2026-08-13-18-20-43-809.mp4
    REC-20260813181440.mp4
  12. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Aug 13, 2026
  13. changed the title [-]Scan - Blank placeholder is shown briefly after uploading receipt[/-] [+][Due for payment 2026-08-21] Scan - Blank placeholder is shown briefly after uploading receipt[/+] on Aug 14, 2026
  14. melvin-bot commented on Aug 14, 2026

    @melvin-bot

    @bernhardoj / @thesahindia

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.53-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-21. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions