You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Search request appears in DevTools after receiving message #98596
Version Number: 9.4.53-3 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#98305 Email or phone of affected tester (no customers):emady.syed1234+400@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Windows 11 / Chrome App Component: Other
Action Performed:
Precondition:
Sign in to two accounts, Account 1 and Account 2, on two devices or browsers.
On Device 1, open DevTools > Network and filter the requests to Search.
Account 1: open Spend > Expenses.
Account 1: clear the network log in DevTools.
Account 2: open the DM with Account 1 and send a message.
Expected Result:
No Search request appears in DevTools.
Actual Result:
Search request appears in DevTools after receiving message
This is a known regression from a revert, not a new bug — and the fix is already in flight. No new proposal is needed; this should be closed as tracked by the reland below.
Root cause: On a non-chat Search (e.g. Spend › Expenses), the refetch effect in useSearchHighlightAndScroll.ts:107 fires whenever any new report action appears anywhere in the account:
hasReportActionsIDsChange is not gated by isChat, so an incoming DM message (a new report action) re-fires the Expenses Search request — exactly the reported symptom.
Why it's reproducing right now: This was already fixed by #98305 (which gates the report-action trigger behind isChat), merged 2026-08-12. That fix caused four deploy blockers (#98494, #98502, #98543, #98544) and was reverted on staging by #98548 on 2026-08-13 ~07:26 UTC. This QA run executed PR #98305's own test steps at ~14:46 UTC that day — after the revert — so the pre-fix behavior is back on 9.4.53-3.
Recommended action: No new fix here. The reland is already open as #98558 ("reland Search re-fire fix with the deploy blocker regressions closed"), which reapplies #98305 with the four blockers fixed. Suggest closing this as a duplicate of #98048 / tracked by #98558, and verifying these exact steps once the reland deploys. I'd also hold off on adding External since the fix is being handled internally.
The mechanism: an incoming message creates a new reportActions_* entry. reportActionsIDs (useSearchHighlightAndScroll.ts:88-90) then differs from the previous set, making hasReportActionsIDsChange true. Because the trigger condition ORs it in unconditionally (line 107), a non-chat search refetches. The comment directly above the effect (:83) already states the intended behavior — "trigger a search when a new report action is added while on chat, or when a new transaction is added for the other search types" — which the current code does not match.
Fix that was reverted:fix: stop Search re-firing an identical query on unrelated Onyx updates #98305 changed the trigger to gate the report-action branch behind isChat, and also fixed a dead skip-guard (comparing prefixed Onyx collection keys transactions_<id> against bare transactionID values). Merge commit 04a8308.
@mountiny@BartekObudzinski this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
applause-bot commentedon Aug 13, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/a76708f133e8cfb747c61aeaa19dfd07525b8c0b63b08c66d4e4b77b03b94211
MelvinBot commentedon Aug 13, 2026
Issue Analysis
This is a known regression from a revert, not a new bug — and the fix is already in flight. No new proposal is needed; this should be closed as tracked by the reland below.
Root cause: On a non-chat Search (e.g. Spend › Expenses), the refetch effect in
useSearchHighlightAndScroll.ts:107fires whenever any new report action appears anywhere in the account:hasReportActionsIDsChangeis not gated byisChat, so an incoming DM message (a new report action) re-fires the ExpensesSearchrequest — exactly the reported symptom.Why it's reproducing right now: This was already fixed by #98305 (which gates the report-action trigger behind
isChat), merged 2026-08-12. That fix caused four deploy blockers (#98494, #98502, #98543, #98544) and was reverted on staging by #98548 on 2026-08-13 ~07:26 UTC. This QA run executed PR #98305's own test steps at ~14:46 UTC that day — after the revert — so the pre-fix behavior is back on 9.4.53-3.Recommended action: No new fix here. The reland is already open as #98558 ("reland Search re-fire fix with the deploy blocker regressions closed"), which reapplies #98305 with the four blockers fixed. Suggest closing this as a duplicate of #98048 / tracked by #98558, and verifying these exact steps once the reland deploys. I'd also hold off on adding
Externalsince the fix is being handled internally.Investigation details & evidence
reportActions_*entry.reportActionsIDs(useSearchHighlightAndScroll.ts:88-90) then differs from the previous set, makinghasReportActionsIDsChangetrue. Because the trigger condition ORs it in unconditionally (line 107), a non-chat search refetches. The comment directly above the effect (:83) already states the intended behavior — "trigger a search when a new report action is added while on chat, or when a new transaction is added for the other search types" — which the current code does not match.isChat, and also fixed a dead skip-guard (comparing prefixed Onyx collection keystransactions_<id>against baretransactionIDvalues). Merge commit04a8308.[CP Staging] Revert "fix: stop Search re-firing…", merged 2026-08-13T07:26 UTC (commit79be2d8). The currentmainfile is byte-identical to the pre-fix: stop Search re-firing an identical query on unrelated Onyx updates #98305 version, confirming the fix is not present in the deployed build.mainstill carries the exact ungated condition fix: stop Search re-firing an identical query on unrelated Onyx updates #98305 targeted, and the revert timing precisely straddles the QA execution time.Confidence: High — code and PR history agree end-to-end; the revert timeline explains why staging/production reproduce.
melvin-bot commentedon Aug 17, 2026
@BartekObudzinski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Aug 19, 2026
@BartekObudzinski Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Aug 21, 2026
@BartekObudzinski 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Aug 25, 2026
@BartekObudzinski 10 days overdue. Is anyone even seeing these? Hello?
melvin-bot commentedon Aug 27, 2026
@mountiny @BartekObudzinski this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Aug 27, 2026
@BartekObudzinski 12 days overdue. Walking. Toward. The. Light...
BartekObudzinski commentedon Aug 28, 2026
The fix has been merged #98558
mountiny commentedon Aug 30, 2026
payment handled in #98048