Skip to content

Search request appears in DevTools after receiving message #98596

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.53-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #98305
Email or phone of affected tester (no customers): emady.syed1234+400@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 / Chrome
App Component: Other

Action Performed:

Precondition:
Sign in to two accounts, Account 1 and Account 2, on two devices or browsers.
On Device 1, open DevTools > Network and filter the requests to Search.

  1. Account 1: open Spend > Expenses.
  2. Account 1: clear the network log in DevTools.
  3. Account 2: open the DM with Account 1 and send a message.

Expected Result:

No Search request appears in DevTools.

Actual Result:

Search request appears in DevTools after receiving message

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7232564_1786618212073.buggy.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7232564

Issue OwnerCurrent Issue Owner: @BartekObudzinski

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 13, 2026
  2. applause-bot commented on Aug 13, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/a76708f133e8cfb747c61aeaa19dfd07525b8c0b63b08c66d4e4b77b03b94211

  3. MelvinBot commented on Aug 13, 2026

    @MelvinBot
    Contributor

    Issue Analysis

    This is a known regression from a revert, not a new bug — and the fix is already in flight. No new proposal is needed; this should be closed as tracked by the reland below.

    Root cause: On a non-chat Search (e.g. Spend › Expenses), the refetch effect in useSearchHighlightAndScroll.ts:107 fires whenever any new report action appears anywhere in the account:

    if ((!isChat && hasTransactionsIDsChange) || hasReportActionsIDsChange || hasPendingSearchRef.current) {

    hasReportActionsIDsChange is not gated by isChat, so an incoming DM message (a new report action) re-fires the Expenses Search request — exactly the reported symptom.

    Why it's reproducing right now: This was already fixed by #98305 (which gates the report-action trigger behind isChat), merged 2026-08-12. That fix caused four deploy blockers (#98494, #98502, #98543, #98544) and was reverted on staging by #98548 on 2026-08-13 ~07:26 UTC. This QA run executed PR #98305's own test steps at ~14:46 UTC that day — after the revert — so the pre-fix behavior is back on 9.4.53-3.

    Recommended action: No new fix here. The reland is already open as #98558 ("reland Search re-fire fix with the deploy blocker regressions closed"), which reapplies #98305 with the four blockers fixed. Suggest closing this as a duplicate of #98048 / tracked by #98558, and verifying these exact steps once the reland deploys. I'd also hold off on adding External since the fix is being handled internally.

    Investigation details & evidence

    Confidence: High — code and PR history agree end-to-end; the revert timeline explains why staging/production reproduce.

  4. melvin-bot commented on Aug 17, 2026

    @melvin-bot

    @BartekObudzinski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. melvin-bot commented on Aug 19, 2026

    @melvin-bot

    @BartekObudzinski Eep! 4 days overdue now. Issues have feelings too...

  6. melvin-bot commented on Aug 21, 2026

    @melvin-bot

    @BartekObudzinski 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  7. melvin-bot commented on Aug 25, 2026

    @melvin-bot

    @BartekObudzinski 10 days overdue. Is anyone even seeing these? Hello?

  8. melvin-bot commented on Aug 27, 2026

    @melvin-bot

    @mountiny @BartekObudzinski this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  9. melvin-bot commented on Aug 27, 2026

    @melvin-bot

    @BartekObudzinski 12 days overdue. Walking. Toward. The. Light...

  10. BartekObudzinski commented on Aug 28, 2026

    @BartekObudzinski
    Contributor

    The fix has been merged #98558

  11. mountiny commented on Aug 30, 2026

    @mountiny
    Contributor

    payment handled in #98048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions