You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-01] Rules - Vendor name changes after disconnecting accounting #98602
Version Number: 9.4.53-4 Reproducible in staging?: Yes Reproducible in production?: Unable to validate in Prod - Provide reasoning. If this was caught during regression testing, add the test name, ID and link from BrowserStack:#97811 Email or phone of affected tester (no customers):applausetester+ssndjois2jd1@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Enable Accounting and Rules.
Connect workspace to Sage Intacct.
Run Onyx.merge('betas', ['vendorMatching']); in console.
Go to staging.new.expensify.com
Go to workspace settings > Rules.
Click Add merchant rule.
Click Merchant.
Enter merchant and save it.
Click Vendor.
Select a vendor.
Create the rule.
Go to Accounting and disconnect Sage Intacct.
Go to Rules.
Scroll down to the created rule.
Expected Result:
Vendor name will not change after disconnecting accounting.
Actual Result:
Vendor name changes after disconnecting accounting.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug (App) Causing PR: #97811 - "Add vendorID action field to merchant coding rules (vendor matching R5, Phase B)" by @MelvinBot, approved by @abzokhattab and @mollfpr (High confidence) Related Issues: none
Recommendation: DEMOTE (fix, don't revert — see below)
This is not a backend issue — the vendor name is resolved entirely client-side at render time from the policy's connection data, so when Sage Intacct is disconnected the App can no longer resolve the name and falls back to the raw external vendor ID. It is fully gated behind the vendorMatching beta (which requires a manual Onyx.merge('betas', ['vendorMatching']) console command), is not reachable by any production or normal staging user, and is not reproducible in production — so it does not warrant blocking the deploy. Keep the feature; address with a small roll-forward fix rather than reverting the whole PR.
Assigned: @abzokhattab and @mollfpr (approving reviewers of the causing PR) are already assigned. The PR author is an automation account (@MelvinBot), so not assigned. Labels: No changes. This is a Frontend bug, so DeployBlockerCash is kept (per the decision tree, an App PR caused it). No DeployBlocker (Web) label is present.
The PR introduces the vendorID action field, src/libs/MerchantTypeRulesUtils.ts, AddVendorPage.tsx, and the render-time name resolution. Its own description states the design explicitly: "Only the external vendor ID is stored; the display name is resolved at render time from the policy's active vendor list." Test step 11 even documents the fallback to "vendor unavailable"/raw ID when the vendor list isn't present.
Reproduces on staging only; not reproducible in production. The feature requires the vendorMatching beta enabled via a console command, so no real user can reach it.
Verification
Affected file: src/libs/MerchantTypeRulesUtils.ts — the vendor branch in getMerchantCodingRulesTableData:
The coding rule persists only the external vendorID. The display name is recomputed on every render in getMerchantCodingRulesTableData via a three-tier lookup:
getMatchingVendorByID(policy, rule.vendorID) — the active vendor-matching integration's list.
If that misses but the list is loaded → show "vendor/supplier unavailable".
Otherwise findVendorByID(policy, rule.vendorID)?.name ?? rule.vendorID — permissive search across QBO/Intacct connection data, falling back to the raw vendor ID.
When Sage Intacct is disconnected, its connection (and vendor list) is removed from policy.connections in Onyx. getActiveVendorMatchingVendors then returns undefined (no active source), so tier 1 misses and isMatchingVendorListLoaded is false, dropping to tier 3. findVendorByID also finds nothing (the Intacct connection data is gone), so it falls back to rule.vendorID. The result: a rule that displayed the vendor's name now displays the raw external ID — the reported "vendor name changes after disconnecting accounting."
This is purely App render logic. The backend correctly stores only the ID and correctly drops the connection's vendor data on disconnect; there is no backend defect. A fix belongs in App — e.g. cache the resolved vendor name on the rule at save time (so it survives disconnection), or render a stable "unavailable" state instead of the raw ID when no source is connected.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment: new feature: we are updating the vendor name after disconnect
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A — not critical, behind the vendorMatching beta.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
A workspace with Accounting and Rules enabled, connected to Sage Intacct (or another vendor-matching integration).
The vendorMatching beta enabled via Onyx.merge('betas', ['vendorMatching']).
A merchant rule created with a vendor selected from the integration.
Test:
Verify the merchant rule summary shows the vendor's name (e.g. "Update vendor to "Acme Corp"").
Disconnect the accounting integration from Workspace settings > Accounting.
Navigate to Workspace settings > Rules.
Verify the merchant rule summary shows "Update vendor to "Vendor unavailable"" — not a raw external vendor ID.
Reconnect the integration and verify the vendor's name renders again correctly.
Activity
applause-bot commentedon Aug 13, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/d68765185cde2a037f4d74ff3edd7364a955e4fdf0ec92b260c9b1baab817729
melvin-bot commentedon Aug 13, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #97811
melvin-bot commentedon Aug 13, 2026
@mollfpr @abzokhattab you have been assigned to this deploy blocker because you reviewed the offending PR: #97811
melvin-bot commentedon Aug 13, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
abzokhattab commentedon Aug 13, 2026
is that a backend issue @Beamanator
MelvinBot commentedon Aug 13, 2026
🔍 Investigation Summary
Classification: Frontend bug (App)
Causing PR: #97811 - "Add vendorID action field to merchant coding rules (vendor matching R5, Phase B)" by @MelvinBot, approved by @abzokhattab and @mollfpr (High confidence)
Related Issues: none
Recommendation: DEMOTE (fix, don't revert — see below)
This is not a backend issue — the vendor name is resolved entirely client-side at render time from the policy's connection data, so when Sage Intacct is disconnected the App can no longer resolve the name and falls back to the raw external vendor ID. It is fully gated behind the
vendorMatchingbeta (which requires a manualOnyx.merge('betas', ['vendorMatching'])console command), is not reachable by any production or normal staging user, and is not reproducible in production — so it does not warrant blocking the deploy. Keep the feature; address with a small roll-forward fix rather than reverting the whole PR.Assigned: @abzokhattab and @mollfpr (approving reviewers of the causing PR) are already assigned. The PR author is an automation account (@MelvinBot), so not assigned.
Labels: No changes. This is a Frontend bug, so
DeployBlockerCashis kept (per the decision tree, an App PR caused it). NoDeployBlocker(Web) label is present.📋 Detailed Analysis
Evidence
vendorIDaction field,src/libs/MerchantTypeRulesUtils.ts,AddVendorPage.tsx, and the render-time name resolution. Its own description states the design explicitly: "Only the external vendor ID is stored; the display name is resolved at render time from the policy's active vendor list." Test step 11 even documents the fallback to "vendor unavailable"/raw ID when the vendor list isn't present.vendorMatchingbeta enabled via a console command, so no real user can reach it.Verification
src/libs/MerchantTypeRulesUtils.ts— the vendor branch ingetMerchantCodingRulesTableData:App/src/libs/MerchantTypeRulesUtils.ts
Lines 159 to 177 in 837ca8c
src/libs/PolicyUtils.ts:getActiveVendorMatchingVendorsApp/src/libs/PolicyUtils.ts
Lines 2489 to 2516 in 837ca8c
isMatchingVendorListLoadedApp/src/libs/PolicyUtils.ts
Lines 2534 to 2536 in 837ca8c
getMatchingVendorByIDApp/src/libs/PolicyUtils.ts
Lines 2543 to 2548 in 837ca8c
findVendorByIDApp/src/libs/PolicyUtils.ts
Lines 2561 to 2577 in 837ca8c
src/libs/MerchantTypeRulesUtils.ts,src/types/onyx/Policy.ts(addsvendorID),src/pages/workspace/rules/MerchantRules/AddVendorPage.tsx, andsrc/pages/workspace/rules/MerchantRulesSection.tsx— all in the affected code path.Root Cause
The coding rule persists only the external
vendorID. The display name is recomputed on every render ingetMerchantCodingRulesTableDatavia a three-tier lookup:getMatchingVendorByID(policy, rule.vendorID)— the active vendor-matching integration's list.findVendorByID(policy, rule.vendorID)?.name ?? rule.vendorID— permissive search across QBO/Intacct connection data, falling back to the raw vendor ID.When Sage Intacct is disconnected, its connection (and vendor list) is removed from
policy.connectionsin Onyx.getActiveVendorMatchingVendorsthen returnsundefined(no active source), so tier 1 misses andisMatchingVendorListLoadedisfalse, dropping to tier 3.findVendorByIDalso finds nothing (the Intacct connection data is gone), so it falls back torule.vendorID. The result: a rule that displayed the vendor's name now displays the raw external ID — the reported "vendor name changes after disconnecting accounting."This is purely App render logic. The backend correctly stores only the ID and correctly drops the connection's vendor data on disconnect; there is no backend defect. A fix belongs in App — e.g. cache the resolved vendor name on the rule at save time (so it survives disconnection), or render a stable "unavailable" state instead of the raw ID when no source is connected.
34 remaining items
Beamanator commentedon Aug 31, 2026
has been in prod for a week!
melvin-bot commentedon Aug 31, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 31, 2026
Payment Summary
Resolving PRs:
Fix: render 'Vendor unavailable' instead of raw vendor ID in merchant rules after disconnecting accounting #98619
Reviewer: @abzokhattab owed $250 via NewDot
BugZero Checklist (@mallenexpensify)
abzokhattab commentedon Sep 3, 2026
BugZero Checklist
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment: new feature: we are updating the vendor name after disconnect
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A — not critical, behind the
vendorMatchingbeta.[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
vendorMatchingbeta enabled viaOnyx.merge('betas', ['vendorMatching']).Test:
Do we agree 👍 or 👎
mallenexpensify commentedon Sep 3, 2026
Payment Summary
Contributor+: @abzokhattab due $250 via NewDot
quinthar commentedon Sep 25, 2026
Approved $250 to @abzokhattab