Skip to content

[Due for payment 2026-08-21] Payment issue for E/App PR#97486 #98679

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #97486
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/665368.
Contributor+ member who reviewed the PR - @QichenZhu.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Aug 14, 2026

    @melvin-bot
    Author

    @QichenZhu The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. melvin-bot commented on Aug 17, 2026

    @melvin-bot
    Author

    @QichenZhu Whoops! This issue is 2 days overdue. Let's get this updated quick!

  3. melvin-bot commented on Aug 19, 2026

    @melvin-bot
    Author

    @QichenZhu Huh... This is 4 days overdue. Who can take care of this?

  4. QichenZhu commented on Aug 20, 2026

    @QichenZhu
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/A. New feature.
      Link to the comment on the Issue: N/A.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Note: the QA team said they didn't have the required account to perform the test: #97486 (comment).

    Precondition:

    • Has an account manager, a partner manager, and a guide assigned, each with a Calendly link set.

    Test:

    1. Open Account > Help and verify the account manager, partner manager, and guide rows each show a Book a call button that opens that person's Calendly link externally.
    2. Open a 1:1 DMs with the account manager and with the partner manager and verify each header shows the Book a call button.
    3. Open Concierge and verify the header shows the account manager's Book a call button.
    4. Unassign the account manager and sign out/in, and verify Concierge now shows the partner manager's button.
    5. Also unassign the partner manager and sign out/in, and verify Concierge now shows the guide's button.

    Do we agree 👍 or 👎

  5. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 20, 2026
  6. melvin-bot commented on Aug 20, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  7. melvin-bot commented on Aug 20, 2026

    @melvin-bot
    Author

    Payment Summary

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  8. mallenexpensify commented on Aug 21, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @QichenZhu due $250 via NewDot

  9. trjExpensify commented on Sep 1, 2026

    @trjExpensify
    Contributor

    approved $250 for @QichenZhu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions