Skip to content

[Due for payment 2026-08-25] iOS - Spend - App crashes when using Bulk Select on any page #98695

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.54-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176730/test-cases/41237112
Email or phone of affected tester (no customers): gatantm+681@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: iOS
App Component: Money Requests

Action Performed:

  1. Launch the app
  2. Tap on Spend (or open any Report or any WS settings with Bulk options)
  3. Tap and hold on any expense or report
  4. Tap Select

Expected Result:

Multi select is shown

Actual Result:

app crashes

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7233920_1786740522022!onyx-state_3.txt

Bug7233920_1786740287515.RPReplay_Final1786740058.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7233920

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 14, 2026
  2. melvin-bot commented on Aug 14, 2026

    @melvin-bot

    Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Aug 14, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Aug 14, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. MelvinBot commented on Aug 14, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: Not yet confirmed to medium+ confidence — candidates listed below (all Low confidence)
    Related Issues: none identified

    Recommendation: NEEDS INVESTIGATION

    This is clearly an App-side (frontend) regression — the "Something went wrong" screen is the JS ErrorBoundary fallback, it reproduces on staging but not production, and there is no backend/API involvement in the reproduction (long-press → tap Select → the selection-mode UI throws while rendering). So DeployBlockerCash must stay. I was not able to pin a single causing PR to medium+ confidence through static analysis alone, so I'm keeping the block and asking for a runtime stack trace / bisect rather than guessing at a revert.

    Assigned: none — confidence in a single PR is below the bar to assign contributors.
    Labels: No changes. DeployBlockerCash kept (frontend bug, staging-only regression). No DeployBlocker label is present, so nothing to remove.

    📋 Detailed Analysis

    What we know

    • Trigger: long-press an expense/report → tap Select (turns on mobile selection mode) → crash. The app is healthy up until Select is tapped, and the long-press menu itself renders fine (the tester can see and tap "Select").
    • Where the crash lands: turning on selection mode (turnOnMobileSelectionMode → RAM_ONLY_MOBILE_SELECTION_MODE) selects the pressed row and renders the bulk-action toolbar (ButtonWithDropdownMenu) plus per-row selection checkboxes. One of those newly-mounted pieces throws.
    • Reproduces on web too (so it's a platform-agnostic JS error), staging only. App Component is Money Requests, and the linked BrowserStack test sits in a Money Requests folder, so the concrete failing surface is Spend > Expenses; the "(or any Report / WS settings)" in the steps is the reporter generalizing.

    Ruled out (so the next engineer doesn't repeat this)

    Because the crash only happens once selection mode is active, I checked the components that mount at that moment and confirmed they were not changed in this deploy (last touched well before the 9.4.53→9.4.54 window):

    • ButtonWithDropdownMenu/index.tsx — the shared bulk-action button rendered on every selection surface — last changed 2026-07-15.
    • ButtonComposed core + primitives (Button.tsx, ButtonText.tsx, ButtonIcon.tsx, ButtonContext.ts) — last changed July.
    • SelectAllCheckbox.tsx — last changed 2026-07-03.
    • MenuItem decomposition ([No QA] MenuItem decomposition - simplest usages #97339) does introduce new contexts, but the missing-provider paths call warnMissingProvider() (warn, not throw), and the "Select" MenuItemAction renders fine, so it does not obviously throw here.
    • Row action buttons migrated in Migrate Button to ButtonComposed (batch 5) search+reports #97336 (ActionCell, etc.) render on initial page load, not only in selection mode — if they were broken, Spend would crash before any long-press, which is not the reported behavior.

    Candidate PRs (all Low confidence, prioritized for a bisect)

    These are the risky/relevant changes that shipped in this deploy and touch the selection / bulk-action path:

    1. [Payment due @huult] [NO QA] Add Amount debited and Amount reimbursed filters, columns and sorting #97708 — "Add Amount debited and Amount reimbursed filters, columns and sorting" by @ishpaul777 (merged 2026-08-13). Touches useSearchBulkActions.ts and SearchUIUtils.ts (getColumnsToShow, sorting maps) — the exact hook feeding the Spend bulk toolbar. Changes look additive, but this is the closest to the failing data path.
    2. Migrate Button to ButtonComposed (batch 5) search+reports #97336 — "Migrate Button to ButtonComposed (batch 5) search+reports" by @mikolajpochec (merged 2026-08-14, last merge before the cut; surfaces match). Likely not the trigger (its buttons render on page load) but worth excluding.
    3. [No QA] MenuItem decomposition - simplest usages #97339 — "[No QA] MenuItem decomposition - simplest usages" by @war-in (merged 2026-08-13). Universal MenuItem rewrite touching both long-press menus; matches the "any page" framing.

    Recommended next steps

  6. m-natarajan commented on Aug 15, 2026

    @m-natarajan

    Honor x6b / Android 16 and iPhone
    Not Repro
    9.4.54-1

    document_4900429084825224964.mp4
    ScreenRecording_08-15-2026.06-17-36_1.MP4
  7. m-natarajan commented on Aug 15, 2026

    @m-natarajan

    Issue fixed and closing as per this comment

  8. melvin-bot commented on Aug 18, 2026

    @melvin-bot

    @arosiclair

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-25. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  9. changed the title [-]iOS - Spend - App crashes when using Bulk Select on any page[/-] [+][Due for payment 2026-08-25] iOS - Spend - App crashes when using Bulk Select on any page[/+] on Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions