Skip to content

Scan - Amount shows 0.00 then reverts to empty field after editing merchant #98697

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.54-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #96772
Email or phone of affected tester (no customers): soidjnosdjoidsjosjoj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a scan expense with invalid receipt.
  4. Wait for scan to fail.
  5. Open the expense.
  6. Click Merchant.
  7. Enter merchant and save it.

Expected Result:

Amount will not show 0.00 after editing merchant.

Actual Result:

Amount shows 0.00 then reverts to empty field after editing merchant.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7233926_1786741108542.5.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7233926

Issue OwnerCurrent Issue Owner: @x-dev90

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 14, 2026
  2. applause-bot commented on Aug 14, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/244387a669ff91b1cb579b66dc34296a8dc5eff1ed87f528a028b7ad8406a4fc

  3. melvin-bot commented on Aug 14, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #96772

  4. melvin-bot commented on Aug 14, 2026

    @melvin-bot

    @arosiclair @Ollyws you have been assigned to this deploy blocker because you reviewed the offending PR: #96772

  5. github-actions commented on Aug 14, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Aug 14, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. MelvinBot commented on Aug 14, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #96772 - "fix: show scan error instead of populating $0 amount when scan fails" by @x-dev90 (High confidence)
    Related Issues: #94494 (the issue #96772 was fixing)

    Recommendation: ROLL FORWARD

    The offending PR is a brand-new, otherwise-desirable feature (failed-scan amount is not in production), and reverting it would reintroduce the original bug it fixed ($0.00 always showing for failed scans, #94494). The flicker has a small, targeted fix, so we should roll forward rather than revert.

    Assigned: @x-dev90 (PR author), @Ollyws and @arosiclair (approving reviewers) from the causing PR.
    Labels: No change. DeployBlockerCash is kept (App deploy is blocked, frontend bug). DeployBlocker was not present.

    📋 Detailed Analysis

    Evidence

    • PR fix: show scan error instead of populating $0 amount when scan fails #96772 introduced the exact behavior described: it hides the placeholder $0.00 for failed scans and shows the missing-amount error / empty amount instead. Before this PR the amount for a failed scan simply showed $0.00, so the empty amount (and the flicker back to it) only exists because of this PR.
    • The reproduction (edit merchant on a failed-scan expense → amount flashes $0.00 then reverts to empty) is a transient state that appears only during the optimistic merchant-edit update.
    • Reproducible on staging only; N/A for production because the feature does not exist there yet.

    Verification

    Root Cause

    isFailedScanAmountPlaceholder gates entirely on the receipt state being SCAN_FAILED:

    TransactionUtils/index.ts L560-L567

    When the user edits the merchant, getUpdatedTransaction sets shouldStopSmartscan = true and then optimistically flips the receipt state from SCAN_FAILED to OPEN:

    TransactionUtils/index.ts L905-L914

    Because the optimistic transaction now has receipt.state === OPEN (not SCAN_FAILED), isFailedScanAmountPlaceholder returns false, so the amount title in MoneyRequestView falls back to the formatted amount $0.00:

    MoneyRequestView.tsx L626-L631

    Once the server response lands, the transaction is restored to receipt.state === SCAN_FAILED (amount still 0, no user-entered modifiedAmount), the predicate becomes true again, and the amount reverts to empty — producing the observed "shows 0.00 then reverts to empty" flicker. The end state is correct; the transient $0.00 is the defect.

    Suggested targeted fix: make isFailedScanAmountPlaceholder (or its callers) resilient to the transient optimistic OPEN state during unrelated edits — e.g. treat a still-amountless scan request that failed as a placeholder even when the receipt state was optimistically flipped (consult the transaction backup / pending state), rather than requiring receipt.state === SCAN_FAILED at the exact render moment.

  8. Beamanator commented on Aug 16, 2026

    @Beamanator
    Contributor

    @x-dev90 can you please take a look here since you authored #96772?

  9. x-dev90 commented on Aug 17, 2026

    @x-dev90

    @Beamanator , @arosiclair Yes, this is from our PR. Please assign me — I have a draft PR ready. Thanks!

  10. melvin-bot commented on Aug 17, 2026

    @melvin-bot

    @Beamanator — to hire @x-dev90 on Upwork, add the External label so a job is created and the offer is sent automatically.

  11. m-natarajan commented on Aug 18, 2026

    @m-natarajan

    Amount field displayed as 0.00 after scanning, Win 11/Chrome, v9.4.54-4

    Recording.3383.mp4
  12. Beamanator commented on Aug 18, 2026

    @Beamanator
    Contributor

    ok looks like we're back to the old version, closing this out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions