You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-01] Android - Accounting software field is not visible when keyboard is opened in landscape mode #98832
Version Number: 9.4.55-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#96160 Email or phone of affected tester (no customers):sdsiodjnosdjiodsj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Other
Action Performed:
Launch Expensify app.
Create a new Gmail account.
Select Manage my team's expenses.
Select Employee number > Continue.
Tap Continue.
Rotate device to landscape.
Select Other.
Focus on accounting software field.
Expected Result:
Accounting software field will be visible when keyboard is opened in landscape mode.
Actual Result:
Accounting software field is not visible when keyboard is opened in landscape mode.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Causing PR:#96160 — "Onboarding: capture accounting system name for Other" (High confidence) Recommendation:Revert to unblock the deploy (a targeted roll-forward is fine too — see below).
PR #96160introduces the "accounting software" text input itself on the onboarding "Other" step, so the field can't have regressed before this PR — which is exactly why the blocker is reproducible in staging but not production. Timeline matches: merged 2026-08-17 22:03 UTC → blocker filed 2026-08-18 04:16 UTC on v9.4.55-0.
Root cause
In BaseOnboardingAccounting.tsx, three interacting changes leave the new input hidden behind the keyboard in landscape on native:
The new input is rendered at the bottom of the ScrollView with autoFocus, so selecting "Other" immediately raises the keyboard over the lower part of the screen where the field lives.
The only auto-scroll is a one-shotonContentSizeChange → scrollToEnd that self-disables after firing once. It is not focus/keyboard-aware, so nothing keeps the focused input above the keyboard once it opens.
shouldEnableMaxHeight={!isMobileSafari()} stays true on native, so the ScreenWrapper is height-capped and won't shrink/scroll to reveal the focused input when the keyboard appears.
In landscape the keyboard eats most of the vertical space, so the bottom-anchored field ends up behind it. Portrait has enough room for the field to stay visible — hence the landscape-specific symptom, on Android App and iOS App (both use the native on-screen keyboard triggered by autoFocus).
Roll-forward alternative (small, localized): make the focused input keyboard-aware — scroll it into view on focus (not just once on content-size change), and/or drop autoFocus so the keyboard doesn't cover it before scrolling, and/or ensure ScreenWrapper/ScrollView performs keyboard avoidance in landscape on native.
Verification details
Affected file: src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx (the exact "What's your company's accounting software?" → "Other" → accounting-software-field screen in the repro).
PR Onboarding: capture accounting system name for Other #96160 touches this file (63 additions / 5 deletions). The other production files it changes are backend-param plumbing (CreateWorkspaceParams, CompleteGuidedSetupParams, Policy.ts, Report/index.ts, useCompleteOnboarding.ts) and language strings — none affect layout/visibility, so the regression is isolated to this component.
Note: this is a native-only (Android/iOS App, landscape) layout issue, so it isn't reproducible on web — no web verification was run.
tylerkaraszewski and ahmedGaber93 are already assigned as the PR reviewers; the PR author KJ21-ENG should also be looped in to decide revert vs. roll-forward.
NAB i guess, I'm wondering, do we even need a fix for this? I think this should be an expected behavior. And if not, then what should we consider as expected behavior? Looking for feedback here.
changed the title [-]Android - Accounting software field is not visible when keyboard is opened in landscape mode[/-][+][Due for payment 2026-09-01] Android - Accounting software field is not visible when keyboard is opened in landscape mode[/+]on Aug 25, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.60-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-09-01. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
If there are posts on the PR or issue that reference a regression or deploy blocker, C+ posts on the issue and confirms regression (which will reduce pay by 50%) or provides reasoning why they shouldn’t be considered. If the C+ doesn’t update the issue, the contributor manager making the payment will assume any mention of a regression or deploy blockers reduces the issue amount.
Who's due how much here @truph01 ? Also.. plz complete the Contributor+ checklist and tag me in a post once you have. Thx
Activity
applause-bot commentedon Aug 18, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/d5ea5c16a2ca658189e9f50fbabf83a03e099adaf0f16e77c63c4131d1ce7f47
melvin-bot commentedon Aug 18, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #96160
melvin-bot commentedon Aug 18, 2026
@tylerkaraszewski @ahmedGaber93 you have been assigned to this deploy blocker because you reviewed the offending PR: #96160
github-actions commentedon Aug 18, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Aug 18, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Aug 18, 2026
🔍 Deploy Blocker Investigation
Causing PR: #96160 — "Onboarding: capture accounting system name for Other" (High confidence)
Recommendation: Revert to unblock the deploy (a targeted roll-forward is fine too — see below).
PR #96160 introduces the "accounting software" text input itself on the onboarding "Other" step, so the field can't have regressed before this PR — which is exactly why the blocker is reproducible in staging but not production. Timeline matches: merged 2026-08-17 22:03 UTC → blocker filed 2026-08-18 04:16 UTC on
v9.4.55-0.Root cause
In
BaseOnboardingAccounting.tsx, three interacting changes leave the new input hidden behind the keyboard in landscape on native:ScrollViewwithautoFocus, so selecting "Other" immediately raises the keyboard over the lower part of the screen where the field lives.onContentSizeChange→scrollToEndthat self-disables after firing once. It is not focus/keyboard-aware, so nothing keeps the focused input above the keyboard once it opens.shouldEnableMaxHeight={!isMobileSafari()}staystrueon native, so theScreenWrapperis height-capped and won't shrink/scroll to reveal the focused input when the keyboard appears.In landscape the keyboard eats most of the vertical space, so the bottom-anchored field ends up behind it. Portrait has enough room for the field to stay visible — hence the landscape-specific symptom, on Android App and iOS App (both use the native on-screen keyboard triggered by
autoFocus).Resolution
autoFocusso the keyboard doesn't cover it before scrolling, and/or ensureScreenWrapper/ScrollViewperforms keyboard avoidance in landscape on native.Verification details
src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx(the exact "What's your company's accounting software?" → "Other" → accounting-software-field screen in the repro).CreateWorkspaceParams,CompleteGuidedSetupParams,Policy.ts,Report/index.ts,useCompleteOnboarding.ts) and language strings — none affect layout/visibility, so the regression is isolated to this component.Note: this is a native-only (Android/iOS App, landscape) layout issue, so it isn't reproducible on web — no web verification was run.
tylerkaraszewskiandahmedGaber93are already assigned as the PR reviewers; the PR authorKJ21-ENGshould also be looped in to decide revert vs. roll-forward.KJ21-ENG commentedon Aug 18, 2026
NAB i guess, I'm wondering, do we even need a fix for this? I think this should be an expected behavior. And if not, then what should we consider as expected behavior? Looking for feedback here.
cc: @ahmedGaber93 @tylerkaraszewski
Simulator.Screen.Recording.-.iPhone.17.-.2026-08-18.at.13.05.29.compressed.mp4
ahmedGaber93 commentedon Aug 18, 2026
This looks expected. I think we should close this issue
28 remaining items
[-]Android - Accounting software field is not visible when keyboard is opened in landscape mode[/-][+][Due for payment 2026-09-01] Android - Accounting software field is not visible when keyboard is opened in landscape mode[/+]melvin-bot commentedon Aug 25, 2026
@ahmedGaber93 / @truph01
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.60-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-09-01. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
truph01 commentedon Aug 28, 2026
Not overdue
melvin-bot commentedon Aug 28, 2026
@ahmedGaber93 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Aug 31, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 31, 2026
Payment Summary
Resolving PRs:
Fix accounting software input not visible in landscape mode when keyboard is opened #99157
Contributor: @GCyganek does not require payment (Contractor)
Reviewer: @ahmedGaber93 owed $250 via NewDot
Reviewer: @truph01 owed $250 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Sep 3, 2026
@truph01 from the C+ doc
Who's due how much here @truph01 ? Also.. plz complete the Contributor+ checklist and tag me in a post once you have. Thx
truph01 commentedon Sep 4, 2026
@mallenexpensify I will be paid via #77280. So, we can close this one