Skip to content

[Due for payment 2026-09-01] Android - Accounting software field is not visible when keyboard is opened in landscape mode #98832

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.55-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #96160
Email or phone of affected tester (no customers): sdsiodjnosdjiodsj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Other

Action Performed:

  1. Launch Expensify app.
  2. Create a new Gmail account.
  3. Select Manage my team's expenses.
  4. Select Employee number > Continue.
  5. Tap Continue.
  6. Rotate device to landscape.
  7. Select Other.
  8. Focus on accounting software field.

Expected Result:

Accounting software field will be visible when keyboard is opened in landscape mode.

Actual Result:

Accounting software field is not visible when keyboard is opened in landscape mode.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7235967_1787018906877.Screen_Recording_20260818_100607_Expensify.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Rizky Gunawan
Bug ID: 7235967

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. applause-bot commented on Aug 18, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/d5ea5c16a2ca658189e9f50fbabf83a03e099adaf0f16e77c63c4131d1ce7f47

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 18, 2026
  3. melvin-bot commented on Aug 18, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #96160

  4. melvin-bot commented on Aug 18, 2026

    @melvin-bot

    @tylerkaraszewski @ahmedGaber93 you have been assigned to this deploy blocker because you reviewed the offending PR: #96160

  5. github-actions commented on Aug 18, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Aug 18, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. MelvinBot commented on Aug 18, 2026

    @MelvinBot
    Contributor

    🔍 Deploy Blocker Investigation

    Causing PR: #96160 — "Onboarding: capture accounting system name for Other" (High confidence)
    Recommendation: Revert to unblock the deploy (a targeted roll-forward is fine too — see below).

    PR #96160 introduces the "accounting software" text input itself on the onboarding "Other" step, so the field can't have regressed before this PR — which is exactly why the blocker is reproducible in staging but not production. Timeline matches: merged 2026-08-17 22:03 UTC → blocker filed 2026-08-18 04:16 UTC on v9.4.55-0.

    Root cause

    In BaseOnboardingAccounting.tsx, three interacting changes leave the new input hidden behind the keyboard in landscape on native:

    1. The new input is rendered at the bottom of the ScrollView with autoFocus, so selecting "Other" immediately raises the keyboard over the lower part of the screen where the field lives.
    2. The only auto-scroll is a one-shot onContentSizeChange → scrollToEnd that self-disables after firing once. It is not focus/keyboard-aware, so nothing keeps the focused input above the keyboard once it opens.
    3. shouldEnableMaxHeight={!isMobileSafari()} stays true on native, so the ScreenWrapper is height-capped and won't shrink/scroll to reveal the focused input when the keyboard appears.

    In landscape the keyboard eats most of the vertical space, so the bottom-anchored field ends up behind it. Portrait has enough room for the field to stay visible — hence the landscape-specific symptom, on Android App and iOS App (both use the native on-screen keyboard triggered by autoFocus).

    Resolution

    • Revert Onboarding: capture accounting system name for Other #96160 is the safe default: it's a self-contained PR and the sole cause, so it reverts cleanly. Don't let the deploy sit blocked.
    • Roll-forward alternative (small, localized): make the focused input keyboard-aware — scroll it into view on focus (not just once on content-size change), and/or drop autoFocus so the keyboard doesn't cover it before scrolling, and/or ensure ScreenWrapper/ScrollView performs keyboard avoidance in landscape on native.
    Verification details

    Note: this is a native-only (Android/iOS App, landscape) layout issue, so it isn't reproducible on web — no web verification was run.


    tylerkaraszewski and ahmedGaber93 are already assigned as the PR reviewers; the PR author KJ21-ENG should also be looped in to decide revert vs. roll-forward.

  8. KJ21-ENG commented on Aug 18, 2026

    @KJ21-ENG
    Contributor

    NAB i guess, I'm wondering, do we even need a fix for this? I think this should be an expected behavior. And if not, then what should we consider as expected behavior? Looking for feedback here.

    cc: @ahmedGaber93 @tylerkaraszewski

    Simulator.Screen.Recording.-.iPhone.17.-.2026-08-18.at.13.05.29.compressed.mp4
  9. ahmedGaber93 commented on Aug 18, 2026

    @ahmedGaber93
    Contributor

    This looks expected. I think we should close this issue

  10. 28 remaining items

  11. changed the title [-]Android - Accounting software field is not visible when keyboard is opened in landscape mode[/-] [+][Due for payment 2026-09-01] Android - Accounting software field is not visible when keyboard is opened in landscape mode[/+] on Aug 25, 2026
  12. melvin-bot commented on Aug 25, 2026

    @melvin-bot

    @ahmedGaber93 / @truph01

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.60-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-09-01. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  13. truph01 commented on Aug 28, 2026

    @truph01
    Contributor

    Not overdue

  14. melvin-bot commented on Aug 28, 2026

    @melvin-bot

    @ahmedGaber93 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  16. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  17. mallenexpensify commented on Sep 3, 2026

    @mallenexpensify
    Contributor

    @truph01 from the C+ doc

    If there are posts on the PR or issue that reference a regression or deploy blocker, C+ posts on the issue and confirms regression (which will reduce pay by 50%) or provides reasoning why they shouldn’t be considered. If the C+ doesn’t update the issue, the contributor manager making the payment will assume any mention of a regression or deploy blockers reduces the issue amount.

    Who's due how much here @truph01 ? Also.. plz complete the Contributor+ checklist and tag me in a post once you have. Thx

  18. truph01 commented on Sep 4, 2026

    @truph01
    Contributor

    @mallenexpensify I will be paid via #77280. So, we can close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions