You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-01] Chat - Edit composer is slightly higher than the main composer #99143
Version Number: 9.4.58-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#98781 Email or phone of affected tester (no customers):sdsiodjnosdjiodsj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Chat Report View
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create an empty report.
Open the report.
Send a message.
Press keyboard up button.
Expected Result:
Edit composer will have the same height as the main composer.
Actual Result:
Edit composer is slightly higher than the main composer.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root cause:#98781 ("Clean up composer footer and match action buttons to the emoji button", shawnborton) grew the shared composerSizeButton from 32×32 → 40×40 and removed the compensating spacing on the edit composer's cancel (X) button. The edit composer's cancel button adds marginVertical on top of the now-larger button, and the mb1 that used to reconcile the two composers at 32px was removed — so the edit composer's button column now sums taller than the main composer's. Confidence: High on the offending PR (it is the only style change in 9.4.58 touching composer button sizing, and it directly edits the edit-composer files); Medium on the exact pixel mechanism (see caveat).
Recommended fix: Roll forward with a targeted fix rather than reverting the whole PR (it delivers wanted design work). Make the edit composer's cancel button a plain 40×40 composerSizeButton matching the main composer's + button, instead of adding extra vertical margin:
Then verify both composers render the same height for a single-line message; if a small residual offset remains, restore a wrapper offset equivalent to the old mb1 tuned for the new 40px size.
Investigation details & evidence
Offending PR:#98781 — merged 2026-08-20, in the 9.4.58-0 staging build. Staging-only (not in production), consistent with a regression introduced this release. The Melvin flag is not a false positive from the "regression testing" field — this is a style-only PR and the only one in the release touching composer button sizing.
Edit-composer cancel button derives marginVertical from the button's marginHorizontal, so its vertical footprint is now 40 + 3 + 3 = 46px (was 32 + 6 = 38px): MessageEditCancelButton.tsx:33
The asymmetry: the main composer's leftmost + button uses composerSizeButton with only marginHorizontal (40px footprint), whereas the edit composer's cancel button adds marginVertical on top of the enlarged 40px button (46px). Both composers share minHeight: 48, so the exact rendered delta depends on runtime flex/line-height behavior.
Caveat — could not confirm in-browser: I attempted a web reproduction, but the test session rendered a blank page (0 DOM nodes, no network activity) and never reached Home — a test-infra failure, not a finding. The root cause direction and source are solid from static analysis; the fix above should be confirmed with a browser pass before merge.
Note: Since this is a follow-up, the price for this issue is $125.
Good timing @Eskalifer1 , just this morn I updated the C+ process doc to state followups, by default, will be the standard issue price (reasoning... we're standardizing on pricing and I'm creating a rubric.md file, trying to separate out what should be considered a 'follow-up' was vague and hard to quantify (for many issues, this one seems pretty straight forward, ¯_(ツ)_/¯ )
Activity
applause-bot commentedon Aug 21, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/8948c433bf8ca933f9df9fafc1501493e3144436e1789b472e92633d83e6106a
melvin-bot commentedon Aug 21, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #98781
melvin-bot commentedon Aug 21, 2026
@mollfpr @Eskalifer1 you have been assigned to this deploy blocker because you reviewed the offending PR: #98781
melvin-bot commentedon Aug 21, 2026
@shawnborton you have been assigned to this deploy blocker because you authored the offending PR: #98781
melvin-bot commentedon Aug 21, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 21, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Aug 21, 2026
Deploy Blocker Analysis
Root cause: #98781 ("Clean up composer footer and match action buttons to the emoji button",
shawnborton) grew the sharedcomposerSizeButtonfrom 32×32 → 40×40 and removed the compensating spacing on the edit composer's cancel (X) button. The edit composer's cancel button addsmarginVerticalon top of the now-larger button, and themb1that used to reconcile the two composers at 32px was removed — so the edit composer's button column now sums taller than the main composer's. Confidence: High on the offending PR (it is the only style change in 9.4.58 touching composer button sizing, and it directly edits the edit-composer files); Medium on the exact pixel mechanism (see caveat).Recommended fix: Roll forward with a targeted fix rather than reverting the whole PR (it delivers wanted design work). Make the edit composer's cancel button a plain 40×40
composerSizeButtonmatching the main composer's+button, instead of adding extra vertical margin:Then verify both composers render the same height for a single-line message; if a small residual offset remains, restore a wrapper offset equivalent to the old
mb1tuned for the new 40px size.Investigation details & evidence
Offending PR: #98781 — merged 2026-08-20, in the 9.4.58-0 staging build. Staging-only (not in production), consistent with a regression introduced this release. The Melvin flag is not a false positive from the "regression testing" field — this is a style-only PR and the only one in the release touching composer button sizing.
Mechanism:
alignItems: 'center'added:src/styles/index.ts:2558-2568marginVerticalfrom the button'smarginHorizontal, so its vertical footprint is now40 + 3 + 3 = 46px(was32 + 6 = 38px):MessageEditCancelButton.tsx:33styles.mb1removed from the cancel button wrapper:ReportActionItemMessageEdit.tsx:414The asymmetry: the main composer's leftmost
+button usescomposerSizeButtonwith onlymarginHorizontal(40px footprint), whereas the edit composer's cancel button addsmarginVerticalon top of the enlarged 40px button (46px). Both composers shareminHeight: 48, so the exact rendered delta depends on runtime flex/line-height behavior.Caveat — could not confirm in-browser: I attempted a web reproduction, but the test session rendered a blank page (0 DOM nodes, no network activity) and never reached Home — a test-infra failure, not a finding. The root cause direction and source are solid from static analysis; the fix above should be confirmed with a browser pass before merge.
view run
39 remaining items
melvin-bot commentedon Aug 28, 2026
@Eskalifer1 Whoops! This issue is 2 days overdue. Let's get this updated quick!
Eskalifer1 commentedon Aug 31, 2026
I don't think a checklist is needed here, since this is a follow-up to the main issue, but if one is needed, please let me know.
Note: Since this is a follow-up, the price for this issue is $125.
melvin-bot commentedon Aug 31, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 31, 2026
Payment Summary
Resolving PRs:
Fix edit composer height to match the main composer #99193
Assignee: @Eskalifer1 requires payment (Needs manual offer from BZ)
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Sep 1, 2026
Payment Summary
Contributor+: @Eskalifer1 paid $250 via Upwork
@Eskalifer1 can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022094820900690614572
Good timing @Eskalifer1 , just this morn I updated the C+ process doc to state followups, by default, will be the standard issue price (reasoning... we're standardizing on pricing and I'm creating a rubric.md file, trying to separate out what should be considered a 'follow-up' was vague and hard to quantify (for many issues, this one seems pretty straight forward, ¯_(ツ)_/¯ )
Eskalifer1 commentedon Sep 1, 2026
Hi @mallenexpensify, got it!
I have accepted offer, thank you!
I'm getting paid via Upwork so let's change this:
mallenexpensify commentedon Sep 3, 2026
@Eskalifer1 paid, summary updated above. Thx.