Skip to content

[Due for payment 2026-09-01] Chat - Edit composer is slightly higher than the main composer #99143

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.58-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #98781
Email or phone of affected tester (no customers): sdsiodjnosdjiodsj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Chat Report View

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an empty report.
  4. Open the report.
  5. Send a message.
  6. Press keyboard up button.

Expected Result:

Edit composer will have the same height as the main composer.

Actual Result:

Edit composer is slightly higher than the main composer.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7238846_1787278699461.10.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7238846

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 21, 2026
  2. applause-bot commented on Aug 21, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/8948c433bf8ca933f9df9fafc1501493e3144436e1789b472e92633d83e6106a

  3. melvin-bot commented on Aug 21, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #98781

  4. melvin-bot commented on Aug 21, 2026

    @melvin-bot

    @mollfpr @Eskalifer1 you have been assigned to this deploy blocker because you reviewed the offending PR: #98781

  5. melvin-bot commented on Aug 21, 2026

    @melvin-bot

    @shawnborton you have been assigned to this deploy blocker because you authored the offending PR: #98781

  6. melvin-bot commented on Aug 21, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Aug 21, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Aug 21, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Root cause: #98781 ("Clean up composer footer and match action buttons to the emoji button", shawnborton) grew the shared composerSizeButton from 32×32 → 40×40 and removed the compensating spacing on the edit composer's cancel (X) button. The edit composer's cancel button adds marginVertical on top of the now-larger button, and the mb1 that used to reconcile the two composers at 32px was removed — so the edit composer's button column now sums taller than the main composer's. Confidence: High on the offending PR (it is the only style change in 9.4.58 touching composer button sizing, and it directly edits the edit-composer files); Medium on the exact pixel mechanism (see caveat).

    Recommended fix: Roll forward with a targeted fix rather than reverting the whole PR (it delivers wanted design work). Make the edit composer's cancel button a plain 40×40 composerSizeButton matching the main composer's + button, instead of adding extra vertical margin:

    // src/pages/inbox/report/ReportActionCompose/MessageEditCancelButton.tsx:33
    const closeButtonStyles = [styles.composerSizeButton];

    Then verify both composers render the same height for a single-line message; if a small residual offset remains, restore a wrapper offset equivalent to the old mb1 tuned for the new 40px size.

    Investigation details & evidence

    Offending PR: #98781 — merged 2026-08-20, in the 9.4.58-0 staging build. Staging-only (not in production), consistent with a regression introduced this release. The Melvin flag is not a false positive from the "regression testing" field — this is a style-only PR and the only one in the release touching composer button sizing.

    Mechanism:

    The asymmetry: the main composer's leftmost + button uses composerSizeButton with only marginHorizontal (40px footprint), whereas the edit composer's cancel button adds marginVertical on top of the enlarged 40px button (46px). Both composers share minHeight: 48, so the exact rendered delta depends on runtime flex/line-height behavior.

    Caveat — could not confirm in-browser: I attempted a web reproduction, but the test session rendered a blank page (0 DOM nodes, no network activity) and never reached Home — a test-infra failure, not a finding. The root cause direction and source are solid from static analysis; the fix above should be confirmed with a browser pass before merge.


    view run

  9. 39 remaining items

  10. melvin-bot commented on Aug 28, 2026

    @melvin-bot

    @Eskalifer1 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  11. Eskalifer1 commented on Aug 31, 2026

    @Eskalifer1
    Contributor

    I don't think a checklist is needed here, since this is a follow-up to the main issue, but if one is needed, please let me know.

    Note: Since this is a follow-up, the price for this issue is $125.

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 31, 2026
  13. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  14. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  15. mallenexpensify commented on Sep 1, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @Eskalifer1 paid $250 via Upwork

    @Eskalifer1 can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022094820900690614572

    Note: Since this is a follow-up, the price for this issue is $125.

    Good timing @Eskalifer1 , just this morn I updated the C+ process doc to state followups, by default, will be the standard issue price (reasoning... we're standardizing on pricing and I'm creating a rubric.md file, trying to separate out what should be considered a 'follow-up' was vague and hard to quantify (for many issues, this one seems pretty straight forward, ¯_(ツ)_/¯ )

  16. Eskalifer1 commented on Sep 1, 2026

    @Eskalifer1
    Contributor

    Hi @mallenexpensify, got it!

    I have accepted offer, thank you!

    I'm getting paid via Upwork so let's change this:

    via NewDot

  17. mallenexpensify commented on Sep 3, 2026

    @mallenexpensify
    Contributor

    @Eskalifer1 paid, summary updated above. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions