You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-01] Expense -Back button on confirm page leads to report again while sending expense to someone #99145
Version Number: 9.4.58-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#97883 Email or phone of affected tester (no customers):ibellicotest+2766@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Money Requests
Action Performed:
Prerequisite: Account has Self DM.
Open the staging.new.expensify.com website.
Navigate to Self DM.
Create a manual expense.
Open the just created expense.
Click on "More" > "Send to someone"
Select any recipient.
On confirm page, click on back button on the top left corner.
Note that you are redirected to report instead of landing on recipient list again.
Expected Result:
Clicking on back button on confirm page during "Send to someone" process, should return to recipients list instead of navigating to report again.
Actual Result:
Clicking on back button on confirm page while sending expense to someone, leads to report again instead of navigating to recipients list.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #97883 - "Land Looking-Around users in Spend > Expenses and add "Send to someone" to a tracked expense's More menu" by @MelvinBot (High confidence) Related Issues: #97881 (the feature request this PR implemented)
Recommendation: ROLL FORWARD
The defect is a small back-navigation edge case in shared IOU navigation code that this PR newly exposed through the added "Send to someone" More-menu entry point; a targeted fix is safer than a full revert, which would also drop the valuable "Looking-Around users land in Spend > Expenses" fix (Bug 1) bundled in the same PR.
Assigned: @MelvinBot (PR author), @ikevin127, @luacmartins, @tgolen (approving reviewers) from the causing PR Labels: No changes. DeployBlockerCash is correctly retained (App-side fix required, and the issue is not reproducible in production — new feature). No DeployBlocker present to remove.
The new row calls createDraftTransactionAndNavigateToParticipantSelector({ actionName: CONST.IOU.ACTION.SUBMIT, ... }), opening the "Choose a recipient" picker. See the added handler at src/components/MoneyRequestHeaderSecondaryActions.tsx L624-655:
Affected files / code path (all in Expensify/App, confirmed on current HEAD 1465a42):
Entry point (added by the PR):src/components/MoneyRequestHeaderSecondaryActions.tsx L624-655 — creates a draft track→submit transaction and navigates to the participant selector.
Participant → confirmation nav:src/hooks/useParticipantSubmission.ts L407-428 — goToNextStep builds the confirmation route with backTo left undefined for non-SHARE actions, then Navigation.goBack(route, {compareParams: false})replaces the participants page in the RHP stack.
// We wrap navigation in setNavigationActionToMicrotaskQueue so that data loading in Onyx and navigation do not occur simultaneously, which resets the amount to 0.
// More information can be found here: https://github.com/Expensify/App/issues/73728
Confirmation back button:src/pages/iou/request/step/IOURequestStepConfirmation.tsx L732-783 — navigateBack only returns to the participants step when transaction?.isFromGlobalCreate is truthy; otherwise it falls through to navigateToStartMoneyRequestStep.
The draft created for "Send to someone" is a converted track expense, not a global-create expense, so transaction.isFromGlobalCreate is false. On the confirmation page, pressing back runs navigateBack:
backTo param is undefined (goToNextStep only sets it for the SHARE action) → skipped.
action is SUBMIT, not CATEGORIZE → skipped.
Not per-diem → skipped.
transaction?.isFromGlobalCreate is false → the branch that would Navigation.goBack(participantsRoute) is skipped.
Falls through to navigateToStartMoneyRequestStep(..., iouAction = SUBMIT), which for SUBMIT executes a bare Navigation.goBack().
Because goToNextStep had already replaced the participants page with the confirmation page in the RHP stack, that bare goBack() pops straight out of the RHP to the underlying report — instead of returning to the recipient list. Hence "back leads to the report again."
This same shared path also backs the Inbox track-expense whisper's "Submit it to someone" flow; PR #97883 simply made it reachable from the tracked-expense More menu.
Suggested targeted fix direction (for the assignees to confirm): have this converted-track SUBMIT flow return to the participant selector on back — e.g. pass an explicit backTo (the participants route) when building the confirmation route in useParticipantSubmission.goToNextStep, or handle the action === SUBMIT converted-track case in IOURequestStepConfirmation.navigateBack so it routes back to MONEY_REQUEST_STEP_PARTICIPANTS instead of dismissing. Any change should be validated against the Inbox whisper "Submit it to someone" flow to avoid regressing it.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.60-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-09-01. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
❌ No payment required here - this one was a follow-up issue which was addressed with a follow-up PR - payment will be handled in the main issue. This one can be closed.
Activity
applause-bot commentedon Aug 21, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/1b58fcb15f5f87ec12f7dbb0187d518cb3abf6aa9cc77d3f12046f08d918625c
melvin-bot commentedon Aug 21, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #97883
melvin-bot commentedon Aug 21, 2026
@tgolen @luacmartins @ikevin127 you have been assigned to this deploy blocker because you reviewed the offending PR: #97883
melvin-bot commentedon Aug 21, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 21, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Aug 21, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #97883 - "Land Looking-Around users in Spend > Expenses and add "Send to someone" to a tracked expense's More menu" by @MelvinBot (High confidence)
Related Issues: #97881 (the feature request this PR implemented)
Recommendation: ROLL FORWARD
The defect is a small back-navigation edge case in shared IOU navigation code that this PR newly exposed through the added "Send to someone" More-menu entry point; a targeted fix is safer than a full revert, which would also drop the valuable "Looking-Around users land in Spend > Expenses" fix (Bug 1) bundled in the same PR.
Assigned: @MelvinBot (PR author), @ikevin127, @luacmartins, @tgolen (approving reviewers) from the causing PR
Labels: No changes.
DeployBlockerCashis correctly retained (App-side fix required, and the issue is not reproducible in production — new feature). NoDeployBlockerpresent to remove.📋 Detailed Analysis
Evidence
createDraftTransactionAndNavigateToParticipantSelector({ actionName: CONST.IOU.ACTION.SUBMIT, ... }), opening the "Choose a recipient" picker. See the added handler atsrc/components/MoneyRequestHeaderSecondaryActions.tsxL624-655:App/src/components/MoneyRequestHeaderSecondaryActions.tsx
Lines 624 to 655 in 1465a42
navigateBack) ornavigateToStartMoneyRequestStep; those are pre-existing shared code. The regression is that the PR routed a converted-track SUBMIT draft into that shared code, which does not return to the recipient list for this case.Verification
Affected files / code path (all in
Expensify/App, confirmed on current HEAD1465a42):src/components/MoneyRequestHeaderSecondaryActions.tsxL624-655 — creates a draft track→submit transaction and navigates to the participant selector.src/hooks/useParticipantSubmission.tsL407-428 —goToNextStepbuilds the confirmation route withbackToleft undefined for non-SHARE actions, thenNavigation.goBack(route, {compareParams: false})replaces the participants page in the RHP stack.App/src/hooks/useParticipantSubmission.ts
Lines 407 to 428 in 1465a42
src/pages/iou/request/step/IOURequestStepConfirmation.tsxL732-783 —navigateBackonly returns to the participants step whentransaction?.isFromGlobalCreateis truthy; otherwise it falls through tonavigateToStartMoneyRequestStep.App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx
Lines 732 to 783 in 1465a42
src/libs/IOUUtils.tsL23-27 — foriouAction === SUBMIT,navigateToStartMoneyRequestStepjust callsNavigation.goBack().App/src/libs/IOUUtils.ts
Lines 23 to 27 in 1465a42
Root Cause
The draft created for "Send to someone" is a converted track expense, not a global-create expense, so
transaction.isFromGlobalCreateisfalse. On the confirmation page, pressing back runsnavigateBack:backToparam isundefined(goToNextStep only sets it for the SHARE action) → skipped.actionisSUBMIT, notCATEGORIZE→ skipped.transaction?.isFromGlobalCreateisfalse→ the branch that wouldNavigation.goBack(participantsRoute)is skipped.navigateToStartMoneyRequestStep(..., iouAction = SUBMIT), which forSUBMITexecutes a bareNavigation.goBack().Because
goToNextStephad already replaced the participants page with the confirmation page in the RHP stack, that baregoBack()pops straight out of the RHP to the underlying report — instead of returning to the recipient list. Hence "back leads to the report again."This same shared path also backs the Inbox track-expense whisper's "Submit it to someone" flow; PR #97883 simply made it reachable from the tracked-expense More menu.
Suggested targeted fix direction (for the assignees to confirm): have this converted-track SUBMIT flow return to the participant selector on back — e.g. pass an explicit
backTo(the participants route) when building the confirmation route inuseParticipantSubmission.goToNextStep, or handle theaction === SUBMITconverted-track case inIOURequestStepConfirmation.navigateBackso it routes back toMONEY_REQUEST_STEP_PARTICIPANTSinstead of dismissing. Any change should be validated against the Inbox whisper "Submit it to someone" flow to avoid regressing it.view run
17 remaining items
melvin-bot commentedon Aug 25, 2026
@ikevin127
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.60-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-09-01. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
ikevin127 commentedon Aug 25, 2026
melvin-bot commentedon Aug 31, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 31, 2026
Payment Summary
Resolving PRs:
Fix: return to recipient list on back during Send to someone flow #99148
Reviewer: @ikevin127 owed $250 via NewDot
BugZero Checklist (@mallenexpensify)
ikevin127 commentedon Sep 1, 2026
❌ No payment required here - this one was a follow-up issue which was addressed with a follow-up PR - payment will be handled in the main issue. This one can be closed.