You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-25] Improve the "stale search" empty state on Spend > Expenses (currently shows an error-like "Oops, something went wrong") #99352
Problem
When the Spend > Expenses search results are stale, users are shown an "Oops, something went wrong" empty state (reported on mobile, Pixel 6, v9.4.55-1). Nothing is actually broken — the search just needs to be refreshed — but the current copy and illustration communicate failure, which is confusing and alarming.
A recent PR improved the underlying behavior, but the empty state itself should be reworked so it guides the user to the fix instead of implying something failed.
Proposed solution
Redesign the empty state to be friendlier and action-oriented:
Illustration: something that conveys "stale," not "broken" — e.g. a rewind or clock illustration (Shawn to finalize; mockup shared in the Slack thread).
Copy: a single line pointing the user to the action, e.g. This page is out of date, refresh to see the latest.
@getusha this due payment? If so plz complete the Contributor+ checklist and tag me in a post once you have. Thx
also
Deploy Blocker #101520 was identified to be related to the PR #100176 that attempted to fix this issue.
this issue mentions a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/a Improvement
Link to the comment on the Issue: N/a Improvement
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Turn on "Simulate failing network requests"
Test:
Open Spend > Expenses
Verify the page shows the folder-and-arrows illustration, the heading "Refresh needed", the line "This page is out of date, refresh to see the latest", and a green "Refresh" button
Verify the illustration renders instead of a blank placeholder
Turn "Simulate failing network requests" back off and press "Refresh"
Verify the search reloads and the results appear
Repeat on a narrow window and verify the heading still reads correctly
Run a malformed search query and verify it still shows "Oops... Something went wrong" with no retry button
this issue mentions a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.
@getusha This is regarding the Regression test proposal
The refresh button is not in green and in grey. Is this expected?
For step 8, Nothing to show displayed instead of oops something wrong. Please confirm this one as well.
Activity
melvin-bot commentedon Aug 27, 2026
@shawnborton, @mountiny, @BartekObudzinski Whoops! This issue is 2 days overdue. Let's get this updated quick!
mountiny commentedon Aug 30, 2026
@BartekObudzinski will tackle it this week
BartekObudzinski commentedon Sep 1, 2026
Working on this, try to prepare a pr tomorrow!
melvin-bot commentedon Sep 4, 2026
@BartekObudzinski Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Sep 5, 2026
@BartekObudzinski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
24 remaining items
mallenexpensify commentedon Sep 26, 2026
@getusha this due payment? If so plz complete the Contributor+ checklist and tag me in a post once you have. Thx
also
this issue mentions a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.
melvin-bot commentedon Sep 29, 2026
@getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
getusha commentedon Sep 30, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/a Improvement
Link to the comment on the Issue: N/a Improvement
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/a
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
getusha commentedon Sep 30, 2026
Yep, it was a regression
mallenexpensify commentedon Oct 1, 2026
Payment Summary
Contributor+: @getusha due $125 via NewDot
m-natarajan commentedon Oct 1, 2026
@getusha This is regarding the
Regression test proposalThe refresh button is not in green and in grey. Is this expected?
For step 8, Nothing to show displayed instead of oops something wrong. Please confirm this one as well.
getusha commentedon Oct 2, 2026
@m-natarajan i think that's expected.
@shawnborton @BartekObudzinski do you feel differently?
shawnborton commentedon Oct 2, 2026
Yeah I think that's all expected behavior.
shawnborton commentedon Oct 2, 2026
Although actually, I'm not sure why the button is gray and not green... maybe we decided that in the PR or something?
trjExpensify commentedon Oct 7, 2026
approved $125 for @getusha