Skip to content

[Due for payment 2026-09-25] Improve the "stale search" empty state on Spend > Expenses (currently shows an error-like "Oops, something went wrong") #99352

Closed

Description

@melvin-bot

Problem
When the Spend > Expenses search results are stale, users are shown an "Oops, something went wrong" empty state (reported on mobile, Pixel 6, v9.4.55-1). Nothing is actually broken — the search just needs to be refreshed — but the current copy and illustration communicate failure, which is confusing and alarming.

A recent PR improved the underlying behavior, but the empty state itself should be reworked so it guides the user to the fix instead of implying something failed.

Proposed solution
Redesign the empty state to be friendlier and action-oriented:

  • Illustration: something that conveys "stale," not "broken" — e.g. a rewind or clock illustration (Shawn to finalize; mockup shared in the Slack thread).
  • Copy: a single line pointing the user to the action, e.g. This page is out of date, refresh to see the latest.

Design

Image

Illustration asset: simple-illustration__foldersync.svg.zip

Reported in Slack.

Issue OwnerCurrent Issue Owner: @getusha

Activity

  1. melvin-bot commented on Aug 27, 2026

    @melvin-bot
    Author

    @shawnborton, @mountiny, @BartekObudzinski Whoops! This issue is 2 days overdue. Let's get this updated quick!

  2. mountiny commented on Aug 30, 2026

    @mountiny
    Contributor

    @BartekObudzinski will tackle it this week

  3. BartekObudzinski commented on Sep 1, 2026

    @BartekObudzinski
    Contributor

    Working on this, try to prepare a pr tomorrow!

  4. melvin-bot commented on Sep 4, 2026

    @melvin-bot
    Author

    @BartekObudzinski Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. melvin-bot commented on Sep 5, 2026

    @melvin-bot
    Author

    @BartekObudzinski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. 24 remaining items

  7. mallenexpensify commented on Sep 26, 2026

    @mallenexpensify
    Contributor

    @getusha this due payment? If so plz complete the Contributor+ checklist and tag me in a post once you have. Thx

    also

    Deploy Blocker #101520 was identified to be related to the PR #100176 that attempted to fix this issue.

    this issue mentions a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.

  8. melvin-bot commented on Sep 29, 2026

    @melvin-bot
    Author

    @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  9. getusha commented on Sep 30, 2026

    @getusha
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/a Improvement
      Link to the comment on the Issue: N/a Improvement

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/a

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    • Turn on "Simulate failing network requests"

    Test:

    1. Open Spend > Expenses
    2. Verify the page shows the folder-and-arrows illustration, the heading "Refresh needed", the line "This page is out of date, refresh to see the latest", and a green "Refresh" button
    3. Verify the illustration renders instead of a blank placeholder
    4. Turn "Simulate failing network requests" back off and press "Refresh"
    5. Verify the search reloads and the results appear
    6. Repeat on a narrow window and verify the heading still reads correctly
    7. Run a malformed search query and verify it still shows "Oops... Something went wrong" with no retry button

    Do we agree 👍 or 👎

  10. getusha commented on Sep 30, 2026

    @getusha
    Contributor

    this issue mentions a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.

    Yep, it was a regression

  11. mallenexpensify commented on Oct 1, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @getusha due $125 via NewDot

  12. m-natarajan commented on Oct 1, 2026

    @m-natarajan

    @getusha This is regarding the Regression test proposal
    The refresh button is not in green and in grey. Is this expected?
    For step 8, Nothing to show displayed instead of oops something wrong. Please confirm this one as well.

    Image Image
  13. getusha commented on Oct 2, 2026

    @getusha
    Contributor

    @m-natarajan i think that's expected.
    @shawnborton @BartekObudzinski do you feel differently?

  14. shawnborton commented on Oct 2, 2026

    @shawnborton
    Contributor

    Yeah I think that's all expected behavior.

  15. shawnborton commented on Oct 2, 2026

    @shawnborton
    Contributor

    Although actually, I'm not sure why the button is gray and not green... maybe we decided that in the PR or something?

  16. trjExpensify commented on Oct 7, 2026

    @trjExpensify
    Contributor

    approved $125 for @getusha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions