Repository navigation
Description
Release Version: 1.1.85-8
Compare Changes: production...staging
This release contains changes from the following pull requests:
-
Remove whitespace: pre because of extra empty lines bug #9195
- QA
- Accessibility
-
Added a SO that walks through setting up android. #9428
- QA
- Accessibility
-
Stop using MY_PERSONAL_DETAILS and only use PERSONAL_DETAILS in Onyx #9560
- QA
- Accessibility
-
fix: secure text become visible keep keyboard unchanged #9593
- QA
- Accessibility
-
Refactor GetLocalCurrency #9607
- QA
- Accessibility
-
fix: timezone shown for our own email #9642
- QA
- Accessibility
-
Refactor getUserDetails in App #9697
- QA
- Accessibility
-
Standardize on auth providing # prefix in chat rooms #9758
- QA
- Accessibility
-
Refactor SetWalletLinkedAccount #9828
- QA
- Accessibility
-
[Refactor] Create new OpenIOUModal action instead of GetLocalCurrency #9840
- QA
- Accessibility
-
Add 'OpenIOUDetailsPage' API command #9878
- QA
- Accessibility
-
[No QA] Remove broken defaultProps #9890
- QA
- Accessibility
-
Removing a bit of redundant syntax #9910
- QA
- Accessibility
-
[No QA] Update CLA action to the correct url #9913
- QA
- Accessibility
-
[Snyk] Security upgrade moment from 2.29.1 to 2.29.4 #9916
- QA
- Accessibility
-
[NoQA] Update the path from docs to contributingGuidelines folder for some markdown files #9920
- QA
- Accessibility
-
[NoQA] fix links for Expensify Help site #9925
- QA
- Accessibility
-
[Snyk] Security upgrade webpack-dev-server from 3.11.0 to 3.11.3 #9935
- QA
- Accessibility
-
Android Keyboard Not Opening Sometime on Search Screen - Resolved#9827 #9936
- QA
- Accessibility
-
Refactor User_IsUsingExpensifyCard part 1 #9937
- QA
- Accessibility
-
Fix the styles of the form submit button on requestCallPage #9947
- QA
- Accessibility
-
[NoQA] Add a desktop/dist directory to ignorePatterns #9951
- QA
- Accessibility
-
Get current user personal details directly in
Report.js#9956- QA
- Accessibility
-
Remove the offline indicator from FormAlertWrapper and FormAlertWithSubmitButton #9959
- QA
- Accessibility
-
Return
datafromReauthenticationmiddleware whenshouldRetry: false#9961- QA
- Accessibility
-
Fix issue with dropdown opening when using 'Enter' to create a new room #9962
- QA
- Accessibility
-
fix: typo in personaldetails prop #9966
- QA
- Accessibility
-
Remove call to non-existent fetchData method #9994
- QA
- Accessibility
-
Remove MY_PERSONAL_DETAILS from timezone update logic #10002
- QA
- Accessibility
-
- QA
- Accessibility
-
[CP Stag] Fix lodashGet usage #10043
- QA
- Accessibility
-
Minor comment change to test CP #10062
- QA
- Accessibility
Internal QA:
Deploy Blockers:
- Web - Request Money - App crashed after return to online. #9992
- Messages are being lost and fail to send #10000
- IOU Request - Error "Invalid onyxMethod mergecollection in Onyx update." appeared in Console #10001
- [TEST] This is a test deploy blocker #10003
- iOS - IOU - Preview component - Crash after tapping on the' Pay' or 'View details' buttons #10016
- Android - Payments - Default payment is disappearing after closed and re-open the app. #10021
- Request Money - Report Status shows paid when clicked on view details after request #10024
- Desktop - Money request - Onyx JS errors after few requests to the new user and blank chat #10038
- Web: Report comment date & time always shows Today, at current time (not when comment was sent) #10042
- Unable to switch default payment #10049
- Log in/Log out - Console error are showing when log in and than log out #10052
- Web - Login/Logout - JS console errors are seen during login/logout #10056
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Jul 19, 2022
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.85-2 🚀
OSBotify commentedon Jul 19, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.85-3🚀Julesssss commentedon Jul 19, 2022
I added the deploy blocker label to this issue as a few of us noticed it this morning. It's difficult to reproduce though, so it may well have been from a previous version.
marcaaron commentedon Jul 19, 2022
it's in this version and introduced by a change in #9560. fix incoming!
OSBotify commentedon Jul 19, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.85-3 has been deployed to staging 🎉
OSBotify commentedon Jul 19, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.85-4🚀OSBotify commentedon Jul 19, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.85-4 has been deployed to staging 🎉
OSBotify commentedon Jul 19, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.85-5🚀OSBotify commentedon Jul 19, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.85-5 has been deployed to staging 🎉
roryabraham commentedon Jul 19, 2022
Checking off #9641 because it passed internal QA
mvtglobally commentedon Jul 20, 2022
Regression is completed
Open Blockers
#10016
#10021
#10024
#10038
PR #9607 is failing due to #9992. We retested its pass - checking off
PR #9642 is failing due to #10018. Not a blocker checking off
PR #9697 is failing due to #10010. Not a blocker checking off
PR #9828 is failing due to #10021.
PR #9840 is failing due to #10022 Not a blocker checking off
PR #9878 is failing due to #10001. We are retesting and will check off
Working on few New CPs will share updated list in a bit.
Additional issues logged
#10009
#10010
#10017
#10018
#10022
#10029
#10031
#10032
#10034
#10036
jasperhuangg commentedon Jul 20, 2022
Hi! I was assigned to #10034, and it appears to me that it isn't actually a bug I've given an explanation here and have closed it out.
16 remaining items
mountiny commentedon Jul 22, 2022
@chiragsalian I think the last open deploy blocker does not necessarily have to be a deploy blocker as it is a console error however, it seems to not influence the App functionality. Still investigating, it must be related to some updated API.
OSBotify commentedon Jul 22, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.85-8🚀chiragsalian commentedon Jul 22, 2022
@mvtglobally, sorry for the delayed reply. We won't be deploying today. Our next deploy should be on monday.
OSBotify commentedon Jul 22, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.85-8 has been deployed to staging 🎉
luacmartins commentedon Jul 25, 2022
@mvtglobally is QA done for #9956?
mvtglobally commentedon Jul 25, 2022
Checking. Will update in a few
luacmartins commentedon Jul 25, 2022
Everything else looks good. Just waiting on QA confirmation for #9956 and we should be good to deploy!
mvtglobally commentedon Jul 25, 2022
@luacmartins checking off #9956
luacmartins commentedon Jul 25, 2022
Cool! Checklist is clear and dashboards look good. Kicking off the deploy.
luacmartins commentedon Jul 25, 2022