Skip to content

[Due for payment 2026-10-23] The Receipt Partners invite page bottom padding is too large #99763

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.62-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @linhvovan29546
Slack conversation (hyperlinked to channel name): #Expensify bugs

Action Performed:

  1. Connect to Uber for business from Receipt partners
  2. Open the Receipt partners > Manage invites or
  3. Observe the Invite page once the connection established

Expected Result:

The bottom padding is consistent with other pages.

Actual Result:

The bottom padding is too large

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image
ScreenRecording_08-28-2026.10-09-42_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 28, 2026
  2. MelvinBot commented on Aug 28, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The Receipt Partners invite screens keep their ScreenWrapper in legacy safe-area mode while their child SelectionList also opts into bottom safe-area padding, so the safe-area inset gets applied twice at the bottom on native.

    ScreenWrapper only disables its own legacy bottom safe-area spacer when enableEdgeToEdgeBottomSafeAreaPadding is passed (ScreenWrapper/index.tsx:138). Neither Receipt Partners page passes it, so ScreenWrapper renders its own bottom inset and the SelectionList adds its own via addBottomSafeAreaPadding. On the Send invites page the effect is worst because the confirmButtonOptions footer (FixedFooter) applies the raw inset regardless of the parent context, stacking pb5 + inset + inset under the confirm button.

    This is native-only — web has no safe-area insets, which is exactly why the reporter didn't check Web/mWeb.

    Investigation details (high confidence)

    Affected files (both introduced in #99638, both missing the prop):

    Mechanism: ScreenWrapper sets includeSafeAreaPaddingBottom = isUsingEdgeToEdgeMode ? false : includeSafeAreaPaddingBottomProp (index.tsx:147). With the prop absent, isUsingEdgeToEdgeMode is false, so the legacy bottom spacer stays on. The FixedFooter used by confirmButtonOptions reads the raw inset via useSafeAreaPaddings(true), which intentionally ignores whether the parent already applied padding — so the two stack.

    Known-good reference: the standard workspace member DynamicWorkspaceInvitePage.tsx:252-256 uses the same SelectionList + confirmButtonOptions + addBottomSafeAreaPadding pattern but correctly passes enableEdgeToEdgeBottomSafeAreaPadding, so only one inset is applied. ~28 other selection pages follow this; the two Receipt Partners pages are the outliers.

    Alternatives considered: removing addBottomSafeAreaPadding from the SelectionList would also collapse to one inset, but it diverges from the repo-standard pattern and would drop safe-area padding on the scroll area — switching ScreenWrapper to edge-to-edge mode is the change every comparable page makes.

    What changes do you think we should make in order to solve the problem?

    Add enableEdgeToEdgeBottomSafeAreaPadding to the <ScreenWrapper> on both pages, matching DynamicWorkspaceInvitePage:

    • DynamicInviteReceiptPartnerPolicyPage.tsx — both the main return (line 214) and the "All set" branch (line 189).
    • DynamicEditInviteReceiptPartnerPolicyPage.tsx — line 298.

    This puts ScreenWrapper in edge-to-edge mode so the child SelectionList/FixedFooter becomes the single source of bottom safe-area padding.

    What alternative solutions did you explore? (Optional)

    Removing addBottomSafeAreaPadding from the SelectionList (rejected — diverges from the standard pattern and drops padding on the scrollable area).


    💡 Suggested AI code review rule

    This looks like a recurring, mechanically detectable edge-to-edge migration mistake (2 outliers vs. ~28 correct pages), so it may be worth a coding-standards rule so the AI reviewer catches the next one. Proposed for Expensify/App:

    • Rule: UI-4 — ScreenWrapper must enable edge-to-edge when a child adds bottom safe-area padding
    • Condition: When a page's SelectionList (or other child) uses addBottomSafeAreaPadding and/or a FixedFooter/confirmButtonOptions, the enclosing ScreenWrapper must pass enableEdgeToEdgeBottomSafeAreaPadding; otherwise the inset is applied twice.
    • Why: ScreenWrapper keeps its legacy bottom spacer unless it's in edge-to-edge mode, so it stacks with the child's inset → doubled bottom padding on native (mechanism).
    • Search pattern: files containing addBottomSafeAreaPadding or confirmButtonOptions where the <ScreenWrapper in the same file does not include enableEdgeToEdgeBottomSafeAreaPadding.
    • Offending code (❌): DynamicInviteReceiptPartnerPolicyPage.tsx:214
    • Fix (✅): DynamicWorkspaceInvitePage.tsx:252-256

    The full rule file (with ❌/✅ code inline in the repo's coding-standards format) would go in Expensify/App under .claude/skills/coding-standards/rules/. If it's worth adding, a maintainer can open it there as a draft PR.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/99763) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 28, 2026
  4. melvin-bot commented on Aug 28, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  5. melvin-bot commented on Aug 28, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  6. David-2002065 commented on Aug 30, 2026

    @David-2002065
    Contributor

    @mananjadhav one heads-up on Melvin's fix before this gets picked up.

    The edge-to-edge switch is correct for the SelectionList return, but the proposal also adds it to the "All set" branch (line 189), and that one would break the screen. That branch renders <ConfirmationPage>, whose internal FixedFooter doesn't set addBottomSafeAreaPadding — it relies on ScreenWrapper's legacy bottom inset. Flip it to edge-to-edge and the confirm button loses its bottom padding and sits on the home indicator. That's also why none of the pages using ConfirmationPage are in edge-to-edge mode.

    So the change should only go on the SelectionList return (line 214), not the ConfirmationPage branch. The Manage invites page has no footer, so it's already a single inset today — not actually doubled.

    Happy to raise a proposal with the exact diff if that helps.

  7. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    @mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!

  8. mananjadhav commented on Sep 2, 2026

    @mananjadhav
    Collaborator

    @yusufdeveloper2903's proposal seems good here.

    🎀 👀 🎀 C+ reviewed.

  9. melvin-bot commented on Sep 2, 2026

    @melvin-bot

    Triggered auto assignment to @NicolasBonet, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  10. 67 remaining items

  11. melvin-bot commented on Oct 19, 2026

    @melvin-bot

    @mananjadhav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  12. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    @mananjadhav Eep! 4 days overdue now. Issues have feelings too...

  13. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  14. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  15. mananjadhav commented on Oct 23, 2026

    @mananjadhav
    Collaborator

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: I couldn't trace it to a specific PR that caused this specific issue. I did check a few old PRs but couldn't have known this issue during that PRs.
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    • Have an Uber for Business account ready for setup.
    • An account with a workspace

    Test:

    1. Open a workspace you are an admin of, go to More features and enable Receipt partners.
    2. Open the Send invites page:
    3. With an Uber for Business account: go to Receipt partners, press Connect next to Uber for Business and finish the connection. The app lands on Send invites.
    4. On Android and iOS native, verify the space below the Confirm button is not oversized and matches the space below Next on Members > Invite member.
    5. On web and mWeb, verify the page looks the same as before. There is no bottom safe area inset in the browser, so nothing changes visually.

    Do we agree 👍 or 👎

  16. mallenexpensify commented on Oct 26, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @oqildev paid $250 via Upwork
    Contributor+: @mananjadhav due $250 via NewDot

    @oqildev can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022114795595566546629

  17. oqildev commented on Oct 27, 2026

    @oqildev
    Contributor
  18. mallenexpensify commented on Oct 27, 2026

    @mallenexpensify
    Contributor

    @oqildev paid, summary updated above. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions