Skip to content

[HOLD for payment 2022-08-08] [$250] "No results found" text is not shown when a user search a non existing currency - reported by @thesahindia  #9981

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on Fab icon > send money
  2. Click on currency
  3. Search a currency that doesn't exist

Expected Result:

We should see "No results found"

Actual Result:

We don't see the "No results found" text

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.84-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screenshot 2022-07-09 at 1 39 14 AM

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1657311583630489

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Jul 19, 2022

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Jul 19, 2022
  3. CortneyOfstad commented on Jul 19, 2022

    @CortneyOfstad
    Contributor

    I think this is by design, but going to escalate up just in case.

  4. melvin-bot commented on Jul 19, 2022

    @melvin-bot

    Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  5. removed their assignment
    on Jul 19, 2022
  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 19, 2022
  7. melvin-bot commented on Jul 19, 2022

    @melvin-bot

    Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  8. mountiny commented on Jul 19, 2022

    @mountiny
    Contributor

    I don't see in the code that this would be implemented for the currency search but it makes sense to add it there. Showing blank screen is not good UX.

  9. 27 remaining items

  10. arielgreen commented on Jul 28, 2022

    @arielgreen
    Contributor

    @dhairyasenjaliya can you please be sure to apply to the job on Upwork since we issue payment over there? https://www.upwork.com/jobs/~01b00a8524a966eef0

  11. dhairyasenjaliya commented on Jul 28, 2022

    @dhairyasenjaliya
    Contributor

    @arielgreen sorry totally missed out, applied now thanks for reminding

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 1, 2022
  13. changed the title [-][$250] "No results found" text is not shown when a user search a non existing currency - reported by @thesahindia [/-] [+][HOLD for payment 2022-08-08] [$250] "No results found" text is not shown when a user search a non existing currency - reported by @thesahindia [/+] on Aug 1, 2022
  14. melvin-bot commented on Aug 1, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-08-08. 🎊

  15. arielgreen commented on Aug 8, 2022

    @arielgreen
    Contributor

    @parasharrajat @thesahindia @dhairyasenjaliya hired in Upwork, please accept and I will remit payment

  16. dhairyasenjaliya commented on Aug 9, 2022

    @dhairyasenjaliya
    Contributor

    @arielgreen job expired

  17. arielgreen commented on Aug 9, 2022

    @arielgreen
    Contributor

    Paid @parasharrajat @thesahindia

    @dhairyasenjaliya I just sent a new offer.

  18. dhairyasenjaliya commented on Aug 9, 2022

    @dhairyasenjaliya
    Contributor

    @arielgreen accepted

  19. arielgreen commented on Aug 9, 2022

    @arielgreen
    Contributor

    Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions