You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-08-08] [$250] "No results found" text is not shown when a user search a non existing currency - reported by @thesahindia #9981
Version Number: 1.1.84-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
I don't see in the code that this would be implemented for the currency search but it makes sense to add it there. Showing blank screen is not good UX.
changed the title [-][$250] "No results found" text is not shown when a user search a non existing currency - reported by @thesahindia [/-][+][HOLD for payment 2022-08-08] [$250] "No results found" text is not shown when a user search a non existing currency - reported by @thesahindia [/+]on Aug 1, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
melvin-bot commentedon Jul 19, 2022
Triggered auto assignment to @CortneyOfstad (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.CortneyOfstad commentedon Jul 19, 2022
I think this is by design, but going to escalate up just in case.
melvin-bot commentedon Jul 19, 2022
Triggered auto assignment to @mountiny (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.melvin-bot commentedon Jul 19, 2022
Triggered auto assignment to @arielgreen (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.mountiny commentedon Jul 19, 2022
I don't see in the code that this would be implemented for the currency search but it makes sense to add it there. Showing blank screen is not good UX.
27 remaining items
arielgreen commentedon Jul 28, 2022
@dhairyasenjaliya can you please be sure to apply to the job on Upwork since we issue payment over there? https://www.upwork.com/jobs/~01b00a8524a966eef0
dhairyasenjaliya commentedon Jul 28, 2022
@arielgreen sorry totally missed out, applied now thanks for reminding
[-][$250] "No results found" text is not shown when a user search a non existing currency - reported by @thesahindia [/-][+][HOLD for payment 2022-08-08] [$250] "No results found" text is not shown when a user search a non existing currency - reported by @thesahindia [/+]melvin-bot commentedon Aug 1, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-08-08. 🎊
arielgreen commentedon Aug 8, 2022
@parasharrajat @thesahindia @dhairyasenjaliya hired in Upwork, please accept and I will remit payment
dhairyasenjaliya commentedon Aug 9, 2022
@arielgreen job expired
arielgreen commentedon Aug 9, 2022
Paid @parasharrajat @thesahindia
@dhairyasenjaliya I just sent a new offer.
dhairyasenjaliya commentedon Aug 9, 2022
@arielgreen accepted
arielgreen commentedon Aug 9, 2022
Paid!