Skip to content

Spend - Paid by does not show the payer after selecting Received payment #99969

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.65-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #98326
Email or phone of affected tester (no customers): sdsiodjnosdjiodsj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Search

Action Performed:

Precondition:

  • Disable Approvals and Payments in Workflows settings.
  1. Go to staging.new.expensify.com
  2. Create an expense in workspace chat.
  3. Open the report.
  4. Click Submit.
  5. Click More > Recevied payment > Yes, I've received payment.
  6. Go to Spend > Reports.
  7. Click Display > Edit columns.
  8. Select Paid by and click Save.

Expected Result:

Paid by will show the payer after selecting Received payment.

Actual Result:

Paid by does not show the payer after selecting Received payment.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7247565_1788204832371.6.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7247565

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 31, 2026
  2. applause-bot commented on Aug 31, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/88748b149aaec3c6a9f825320718ed7bcb26013a07c3cad31300ef8a4b658bd6

  3. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #98326

  4. github-actions commented on Aug 31, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    @JS00001 @hoangzinh you have been assigned to this deploy blocker because you reviewed the offending PR: #98326

  6. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    @c3024 you have been assigned to this deploy blocker because you authored the offending PR: #98326

  7. melvin-bot commented on Aug 31, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Aug 31, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #98326 - "Add Paid by search filter UI, table column, sorting, and export" by c3024 (High confidence)
    Related Issues: #99968 (same feature, same root cause area — Paid by column not populated)

    Recommendation: ROLL FORWARD

    The Paid by column is derived in App from a narrow allow-list of REIMBURSED-family report actions, and the "Received payment" flow does not produce one of those actions — a targeted fix in SearchUIUtils is much smaller and safer than reverting a 34-file feature PR that also regenerates the search/autocomplete parsers. If c3024 cannot land a fix quickly, revert #98326 as the fallback since the feature is new and self-contained.

    Assigned: c3024 (PR author), JS00001 and hoangzinh (approving reviewers) from the highest-confidence causing PR — already auto-assigned by Melvin.
    Labels: No label changes. DeployBlockerCash stays (App-side fix, and the issue is not reproducible on production). DeployBlocker was never applied and was not added.

    📋 Detailed Analysis

    Evidence

    Verification

    Affected files (all in Expensify/App, all touched by #98326):

    Root Cause

    Paid by is computed entirely client-side from the report actions in the search snapshot. The detection matches only the OldDot/backend REIMBURSED-family action names, but a report settled through "Received payment" (MarkReportPaymentReceived) — and, optimistically, any NewDot payment — is represented by an IOU action whose originalMessage.type is pay. No matching action is found, lastReimbursedActionByReportID has no entry for the report, paidByAccountID stays undefined, and the cell renders empty even though report.statusNum === REIMBURSED.

    Suggested targeted fix: include NewDot pay actions in the detection, e.g. also accept actions matching ReportActionsUtils.isPayAction (src/libs/ReportActionsUtils.ts:1835-1836) when picking the latest payment action, and add a unit test with a paid report for both the pay and REIMBURSED shapes. One product decision is needed: for a submitter-marked "Received payment" the actor is the submitter, so please confirm whether Paid by should show that actor or the report's payer.

    Backend note: no backend change is required for this bug — the payer is derived in App, not delivered as a snapshot field. The only backend-dependent assumption worth confirming while fixing is that the search snapshot returns the report's IOU pay action; if it turns out the snapshot omits payment actions for this flow, a separate internal investigation would be needed to have the payer represented in the snapshot.


    view run

  9. c3024 commented on Sep 1, 2026

    @c3024
    Contributor

    I think the expected behavior is not correct. For paid-by, we show whoever actually paid the expense. Here, we do not show anything because there is no actual payer paid here. payer, however, shows the policy's default reimburser in the paid column for this case.

    cc: @trjExpensify @JS00001

  10. trjExpensify commented on Sep 1, 2026

    @trjExpensify
    Contributor

    payer, however, shows the policy's default reimburser in the paid column for this case.

    What are you referring to here? A CSV export column or something? 🤔

    I think the expected behavior is not correct. For paid-by, we show whoever actually paid the expense. Here, we do not show anything because there is no actual payer paid here.

    I tend to agree with this though.

  11. c3024 commented on Sep 1, 2026

    @c3024
    Contributor

    Sorry, payer is not a column or filter or a CSV export column. payer is a backend-only search filter (used for the Pay to-do) and it resolves to the default reimburser. It is unrelated to the paid-by filter or column.

  12. trjExpensify commented on Sep 1, 2026

    @trjExpensify
    Contributor

    Cool, so I think we can demote and close this issue as expected then. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions