You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Spend - Paid by does not show the payer after selecting Received payment #99969
Version Number: 9.4.65-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#98326 Email or phone of affected tester (no customers):sdsiodjnosdjiodsj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Search
Action Performed:
Precondition:
Disable Approvals and Payments in Workflows settings.
Go to staging.new.expensify.com
Create an expense in workspace chat.
Open the report.
Click Submit.
Click More > Recevied payment > Yes, I've received payment.
Go to Spend > Reports.
Click Display > Edit columns.
Select Paid by and click Save.
Expected Result:
Paid by will show the payer after selecting Received payment.
Actual Result:
Paid by does not show the payer after selecting Received payment.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #98326 - "Add Paid by search filter UI, table column, sorting, and export" by c3024 (High confidence) Related Issues: #99968 (same feature, same root cause area — Paid by column not populated)
Recommendation: ROLL FORWARD
The Paid by column is derived in App from a narrow allow-list of REIMBURSED-family report actions, and the "Received payment" flow does not produce one of those actions — a targeted fix in SearchUIUtils is much smaller and safer than reverting a 34-file feature PR that also regenerates the search/autocomplete parsers. If c3024 cannot land a fix quickly, revert #98326 as the fallback since the feature is new and self-contained.
Assigned: c3024 (PR author), JS00001 and hoangzinh (approving reviewers) from the highest-confidence causing PR — already auto-assigned by Melvin. Labels: No label changes. DeployBlockerCash stays (App-side fix, and the issue is not reproducible on production). DeployBlocker was never applied and was not added.
The PR describes the column as "derived from the actor of the latest payment report action in the snapshot (same pattern as First approver)". The implementation defines "payment report action" as only REIMBURSED, MARKEDREIMBURSED, or ACTIONMARKEDREIMBURSEDFROMINTEGRATION: src/libs/SearchUIUtils.ts:1899-1910.
The "More > Received payment > Yes, I've received payment" flow calls markReportPaymentReceived, which records the payment as an IOU action with originalMessage.type === 'pay' and isSubmitterMarkedPaymentReceived: true — not a REIMBURSED-family action: src/libs/actions/IOU/PayMoneyRequest.ts:960-971, command dispatch at src/libs/actions/IOU/PayMoneyRequest.ts:1107.
App already documents that NewDot payments surface as an IOU pay action, with the REIMBURSED/MARKEDREIMBURSED twins hidden: src/libs/ReportActionsUtils.ts:1340-1346. So the IOU pay action is the canonical NewDot payment action, and the new code ignores it.
Staging only; there is no production behaviour to compare against because the column is new.
gh pr view 98326 --json files confirms both files are in the PR, along with SearchTableHeader.tsx, ListItem/types.ts and the column constants.
The unit tests added by the PR (tests/unit/Search/SearchUIUtilsTest.ts) only assert formattedPaidBy: '' for unpaid reports; no fixture covers a paid report, so no payment flow was covered by tests.
Root Cause
Paid by is computed entirely client-side from the report actions in the search snapshot. The detection matches only the OldDot/backend REIMBURSED-family action names, but a report settled through "Received payment" (MarkReportPaymentReceived) — and, optimistically, any NewDot payment — is represented by an IOU action whose originalMessage.type is pay. No matching action is found, lastReimbursedActionByReportID has no entry for the report, paidByAccountID stays undefined, and the cell renders empty even though report.statusNum === REIMBURSED.
Suggested targeted fix: include NewDot pay actions in the detection, e.g. also accept actions matching ReportActionsUtils.isPayAction (src/libs/ReportActionsUtils.ts:1835-1836) when picking the latest payment action, and add a unit test with a paid report for both the pay and REIMBURSED shapes. One product decision is needed: for a submitter-marked "Received payment" the actor is the submitter, so please confirm whether Paid by should show that actor or the report's payer.
Backend note: no backend change is required for this bug — the payer is derived in App, not delivered as a snapshot field. The only backend-dependent assumption worth confirming while fixing is that the search snapshot returns the report's IOU pay action; if it turns out the snapshot omits payment actions for this flow, a separate internal investigation would be needed to have the payer represented in the snapshot.
I think the expected behavior is not correct. For paid-by, we show whoever actually paid the expense. Here, we do not show anything because there is no actual payer paid here. payer, however, shows the policy's default reimburser in the paid column for this case.
payer, however, shows the policy's default reimburser in the paid column for this case.
What are you referring to here? A CSV export column or something? 🤔
I think the expected behavior is not correct. For paid-by, we show whoever actually paid the expense. Here, we do not show anything because there is no actual payer paid here.
Sorry, payer is not a column or filter or a CSV export column. payer is a backend-only search filter (used for the Pay to-do) and it resolves to the default reimburser. It is unrelated to the paid-by filter or column.
Activity
applause-bot commentedon Aug 31, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/88748b149aaec3c6a9f825320718ed7bcb26013a07c3cad31300ef8a4b658bd6
melvin-bot commentedon Aug 31, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #98326
github-actions commentedon Aug 31, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Aug 31, 2026
@JS00001 @hoangzinh you have been assigned to this deploy blocker because you reviewed the offending PR: #98326
melvin-bot commentedon Aug 31, 2026
@c3024 you have been assigned to this deploy blocker because you authored the offending PR: #98326
melvin-bot commentedon Aug 31, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Aug 31, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #98326 - "Add Paid by search filter UI, table column, sorting, and export" by
c3024(High confidence)Related Issues: #99968 (same feature, same root cause area —
Paid bycolumn not populated)Recommendation: ROLL FORWARD
The
Paid bycolumn is derived in App from a narrow allow-list ofREIMBURSED-family report actions, and the "Received payment" flow does not produce one of those actions — a targeted fix inSearchUIUtilsis much smaller and safer than reverting a 34-file feature PR that also regenerates the search/autocomplete parsers. Ifc3024cannot land a fix quickly, revert #98326 as the fallback since the feature is new and self-contained.Assigned:
c3024(PR author),JS00001andhoangzinh(approving reviewers) from the highest-confidence causing PR — already auto-assigned by Melvin.Labels: No label changes.
DeployBlockerCashstays (App-side fix, and the issue is not reproducible on production).DeployBlockerwas never applied and was not added.📋 Detailed Analysis
Evidence
Paid bycolumn, its filter, sorting and export were all introduced by [Payment due @hoangzinh] Add Paid by search filter UI, table column, sorting, and export #98326 (merged2026-08-31T18:12:05Z, in the9.4.65-0staging checklist). The column did not exist before, which matches "N/A - new feature, doesn't exist in prod".REIMBURSED,MARKEDREIMBURSED, orACTIONMARKEDREIMBURSEDFROMINTEGRATION: src/libs/SearchUIUtils.ts:1899-1910.markReportPaymentReceived, which records the payment as an IOU action withoriginalMessage.type === 'pay'andisSubmitterMarkedPaymentReceived: true— not aREIMBURSED-family action: src/libs/actions/IOU/PayMoneyRequest.ts:960-971, command dispatch at src/libs/actions/IOU/PayMoneyRequest.ts:1107.payaction, with theREIMBURSED/MARKEDREIMBURSEDtwins hidden: src/libs/ReportActionsUtils.ts:1340-1346. So the IOUpayaction is the canonical NewDot payment action, and the new code ignores it.Paid byonly appears after re-running the search following Mark as paid) is the same design issue seen from the optimistic-update side: App writes an IOUpayaction optimistically, which this detection also ignores.Verification
Affected files (all in
Expensify/App, all touched by #98326):processReportActionEntrybuildslastReimbursedActionByReportID(L1858-L1862, L1899-L1910) andgetReportSectionsturns it intopaidByAccountID/formattedPaidBy(L3148-L3152).item.paidByAccountIDis falsy, which is exactly the reported empty cell.gh pr view 98326 --json filesconfirms both files are in the PR, along withSearchTableHeader.tsx,ListItem/types.tsand the column constants.tests/unit/Search/SearchUIUtilsTest.ts) only assertformattedPaidBy: ''for unpaid reports; no fixture covers a paid report, so no payment flow was covered by tests.Root Cause
Paid byis computed entirely client-side from the report actions in the search snapshot. The detection matches only the OldDot/backendREIMBURSED-family action names, but a report settled through "Received payment" (MarkReportPaymentReceived) — and, optimistically, any NewDot payment — is represented by an IOU action whoseoriginalMessage.typeispay. No matching action is found,lastReimbursedActionByReportIDhas no entry for the report,paidByAccountIDstaysundefined, and the cell renders empty even thoughreport.statusNum === REIMBURSED.Suggested targeted fix: include NewDot pay actions in the detection, e.g. also accept actions matching
ReportActionsUtils.isPayAction(src/libs/ReportActionsUtils.ts:1835-1836) when picking the latest payment action, and add a unit test with a paid report for both thepayandREIMBURSEDshapes. One product decision is needed: for a submitter-marked "Received payment" the actor is the submitter, so please confirm whetherPaid byshould show that actor or the report's payer.Backend note: no backend change is required for this bug — the payer is derived in App, not delivered as a snapshot field. The only backend-dependent assumption worth confirming while fixing is that the search snapshot returns the report's IOU
payaction; if it turns out the snapshot omits payment actions for this flow, a separate internal investigation would be needed to have the payer represented in the snapshot.view run
c3024 commentedon Sep 1, 2026
I think the expected behavior is not correct. For
paid-by, we show whoever actually paid the expense. Here, we do not show anything because there is no actual payer paid here.payer, however, shows the policy's default reimburser in thepaidcolumn for this case.cc: @trjExpensify @JS00001
trjExpensify commentedon Sep 1, 2026
What are you referring to here? A CSV export column or something? 🤔
I tend to agree with this though.
c3024 commentedon Sep 1, 2026
Sorry,
payeris not a column or filter or a CSV export column.payeris a backend-only search filter (used for the Pay to-do) and it resolves to the default reimburser. It is unrelated to thepaid-byfilter or column.trjExpensify commentedon Sep 1, 2026
Cool, so I think we can demote and close this issue as expected then. 👍