Skip to content

[No QA] Update Edit-Expenses.md - #100078

Merged
stephanieelliott merged 1 commit into
mainfrom
brianlee-expensify-patch-7
Sep 4, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
brianlee-expensify-patch-7

Conversation

@brianlee-expensify

Copy link
Copy Markdown
Contributor

led to make updates based on confusion from one of my managed accounts

Explanation of Change

adding clarity on editing expenses for Draft, Outstanding, and Approved reports

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

adding clarity on editing expenses for Draft, Outstanding, and Approved reports
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, focused update to the FAQ section of the Edit-Expenses.md article. It adds two new question-based FAQ entries (editing on Draft/Outstanding reports and on Approved reports) and refines the wording of the existing Paid/Done answer for parallel phrasing. The changes are additive, clarifying, and align well with the FAQ structure defined in the governance files.

Scores Summary

  • Readability: 9/10 - New entries are concise, direct, and easy to scan. Each answer resolves the question clearly. Minor: trailing whitespace on the new heading lines.
  • AI Readiness: 9/10 - Question-based FAQ headings map cleanly to real user search intent ("Can I edit expenses on Approved reports?"). They sit correctly under the exempt FAQ heading and use ## only. Existing YAML frontmatter (including internalScope) is untouched and still valid.
  • Style Compliance: 9/10 - Report state terms (Draft, Outstanding, Approved, Paid, Done) are capitalized consistently, matching the existing article and UI. FAQ format follows the naming conventions and authoring guidelines. No UI-label or navigation violations introduced.

Key Findings

  • Positive: Additions genuinely fill a gap - the FAQ now covers all relevant report states (Draft/Outstanding, Approved, Paid/Done), improving retrieval coverage.
  • Positive: The Approved-report answer usefully explains the unapprove dependency, giving actionable guidance rather than a bare yes/no.
  • Positive: The Paid/Done refinement ("expenses on Paid and Done reports") improves parallelism with the surrounding answers.
  • Minor: Trailing whitespace after the two new question headings should be removed for cleanliness.

Recommendations

  • Remove trailing whitespace on the new heading lines.
  • Optional: The Approved-report answer could cross-link to the unapprove workflow (e.g. "Learn how to unapprove a report") if a dedicated article exists, per the Cross-Linking Standards.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Edit-Expenses.md - Approved. Two new FAQ entries plus a wording refinement; compliant with governance, only trivial nits.

Note: Detailed line-by-line feedback has been provided as inline comments.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9100b5d5d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions github-actions Bot changed the title Update Edit-Expenses.md [No QA] Update Edit-Expenses.md Sep 1, 2026
@OSBotify

OSBotify commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://2d841838.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott merged commit 518cd82 into main Sep 4, 2026
20 of 24 checks passed
@stephanieelliott
stephanieelliott deleted the brianlee-expensify-patch-7 branch September 4, 2026 05:11
@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants