Repository navigation
[No QA] Update Edit-Expenses.md - #100078
Conversation
adding clarity on editing expenses for Draft, Outstanding, and Approved reports
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, focused update to the FAQ section of the Edit-Expenses.md article. It adds two new question-based FAQ entries (editing on Draft/Outstanding reports and on Approved reports) and refines the wording of the existing Paid/Done answer for parallel phrasing. The changes are additive, clarifying, and align well with the FAQ structure defined in the governance files. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9100b5d5d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
A preview of your ExpensifyHelp changes have been deployed to https://2d841838.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
led to make updates based on confusion from one of my managed accounts
Explanation of Change
adding clarity on editing expenses for Draft, Outstanding, and Approved reports
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari