Repository navigation
[No QA] Docs updates for E/A#98887 Submit workspace creation via emailed deeplink #100097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming / UI-label consistency: This says the Spend "tab", but line 105 of the same article refers to the Spend "page" ("when you submit from the Spend page"). Per the naming conventions, UI elements must be referenced with the exact label consistently. Verify the live UI and use one consistent term (page vs. tab) throughout the article.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed — the article now says Spend tab in both places.
I verified against the live New Expensify web UI rather than picking one term arbitrarily. Spend is a top-level navigation tab (
role=tabin the nav rail, alongside Home, Inbox, Workspaces, Account), and Expenses is the page heading you land on inside it. So the new line 42 was already correct and the pre-existing line 113 was the wrong one — I changed**Spend** page→**Spend** tabthere.